Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use genderless pronouns in API docs | Guillermo Iguaran | 2013-12-01 | 1 | -1/+1 |
| | |||||
* | Revert "Used Yield instead of block.call" -- this causes all of ↵ | David Heinemeier Hansson | 2013-11-14 | 1 | -2/+2 |
| | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd. | ||||
* | Merge pull request #12889 from kuldeepaggarwal/speed_ups | Rafael Mendonça França | 2013-11-14 | 1 | -2/+2 |
|\ | | | | | Used Yield instead of block.call | ||||
| * | Used Yield instead of block.call | Kuldeep Aggarwal | 2013-11-15 | 1 | -2/+2 |
| | | |||||
* | | #presence used | Akshay Vishnoi | 2013-11-14 | 1 | -5/+1 |
| | | |||||
* | | Remove order attribute from collector | Lukasz Strzalkowski | 2013-11-10 | 1 | -4/+3 |
|/ | | | | Ruby 1.8 legacy. Since 1.9 hash preserves insertion order. No need for additional array to achieve this | ||||
* | calculate the ivars to remove in advance as a set and cache them in a | Aaron Patterson | 2013-11-06 | 1 | -3/+10 |
| | | | | | | | constant. `view_assigns` can use the precalculated sets and remove instance variables without allocating any extra arrays | ||||
* | Improve wording in AC::ParameterMissing error message | Guillermo Iguaran | 2013-11-02 | 1 | -1/+1 |
| | |||||
* | Revert "Merge pull request #9660 from ↵ | Guillermo Iguaran | 2013-11-02 | 1 | -23/+9 |
| | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour" This reverts commit c2b5a8e61ba0f35015e6ac949a5c8fce2042a1f2, reversing changes made to 1918b12c0429caec2a6134ac5e5b42ade103fe90. See: https://github.com/rails/rails/pull/9660#issuecomment-27627493 | ||||
* | Merge pull request #9660 from ↵ | Guillermo Iguaran | 2013-11-01 | 1 | -9/+23 |
|\ | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour Change ActionController::Parameters#require behavior when value is empty | ||||
| * | Change ActionController::Parameters#require behavior when value is empty | Sebastian Sogamoso | 2013-03-11 | 1 | -9/+23 |
| | | | | | | | | | | When the value for the required key is empty an ActionController::ParameterMissing is raised which gets caught by ActionController::Base and turned into a 400 Bad Request reply with a message in the body saying the key is missing, which is misleading. With these changes, ActionController::EmptyParameter will be raised which ActionController::Base will catch and turn into a 400 Bad Request reply with a message in the body saying the key value is empty. | ||||
* | | Fix typo in method description in Responder class | Lin Reid | 2013-11-01 | 1 | -1/+1 |
| | | | | | | | | Fixes a typo in the description for the call class method in Responder. | ||||
* | | don't mutate hash with fetch | Doug Cole | 2013-10-26 | 1 | -1/+8 |
| | | |||||
* | | pass app config to controller helper proxy | Tima Maslyuchenko | 2013-10-24 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this fix application config become available when calling helper outisde of view config/application.rb #... config.asset_host = 'http://mycdn.com' #... Somewhere else ActionController::Base.helpers.asset_path('fallback.png') # => http://mycdn.com/assets/fallback.png | ||||
* | | Typo fix [ci skip] | Arun Agrawal | 2013-10-09 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | Fixing the typo which is formed a not required link. Check here http://api.rubyonrails.org/classes/ActionController/Base.html under paramters section keeping it under tt tag gets reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4 | ||||
* | | Fixing repond_with working directly on the options hash | BlueHotDog | 2013-10-09 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | This fixes an issue where the respond_with worked directly with the given options hash, so that if a user relied on it after calling respond_with, the hash wouldn't be the same. Fixes #12029 | ||||
* | | Strong parameters should permit nested number as key. Closes #12293 | kennyj | 2013-09-27 | 1 | -1/+5 |
| | | |||||
* | | [ci skip] escape unintended url in docs | Chris Ciollaro | 2013-09-26 | 1 | -1/+1 |
| | | |||||
* | | Fix regex used to find URI schemes in redirect_to | Derek Prior | 2013-09-19 | 1 | -1/+1 |
| | | | | | | | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC. | ||||
* | | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -19/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | | NullSessionHash#destroy should be a no-op | Jonathan Baudanza | 2013-09-18 | 1 | -0/+3 |
| | | | | | | | | Previously it was raising a NilException | ||||
* | | Removing ActiveSupport::Concern, it's not needed | Attila Domokos | 2013-09-13 | 1 | -2/+0 |
| | | |||||
* | | Fixing comment typo in ActionController::Base | Attila Domokos | 2013-09-13 | 1 | -1/+1 |
| | | |||||
* | | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -1/+1 |
| | | | | | | | | subclasses. | ||||
* | | Merge pull request #12159 from nashby/issue-12149 | Rafael Mendonça França | 2013-09-12 | 1 | -1/+1 |
|\ \ | | | | | | | do not break params filtering on nil values | ||||
| * | | do not break params filtering on nil values | Vasiliy Ermolovich | 2013-09-07 | 1 | -1/+1 |
| | | | | | | | | | | | | closes #12149 | ||||
* | | | Remove remaining coupling with AV in MimeResponds | José Valim | 2013-09-09 | 2 | -5/+6 |
| | | | |||||
* | | | Remove BasicRendering and remove template functionality from AbsC::Rendering | José Valim | 2013-09-09 | 2 | -4/+7 |
|/ / | |||||
* | | Do not use instance variables if they are not reused elsewhere | Carlos Antonio da Silva | 2013-09-06 | 1 | -2/+1 |
| | | |||||
* | | render_to_string shouldn't play with response_body | Santiago Pastorino | 2013-09-04 | 1 | -4/+5 |
| | | |||||
* | | Fix a few typos. [ci skip] | namusyaka | 2013-09-04 | 1 | -1/+1 |
| | | |||||
* | | Move BasicRendering to AbstractController | Łukasz Strzałkowski | 2013-09-03 | 2 | -29/+1 |
| | | |||||
* | | Make Mime::TEXT default format in AbstractController | Łukasz Strzałkowski | 2013-09-03 | 1 | -4/+0 |
| | | |||||
* | | Revert "Port all remaining self.protected_instance_variables to class methods" | Łukasz Strzałkowski | 2013-09-02 | 1 | -6/+5 |
| | | | | | | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01. | ||||
* | | Stop messing up with instance variables, use protected as it was meant for | Carlos Antonio da Silva | 2013-08-30 | 1 | -2/+7 |
| | | |||||
* | | Port all remaining self.protected_instance_variables to class methods | Łukasz Strzałkowski | 2013-08-29 | 1 | -5/+6 |
| | | |||||
* | | Fix formatting of error message | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+1 |
| | | | | | | | | Make it oneliner | ||||
* | | Change description of BasicRendering#render | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 |
| | | | | | | | | | | | | We're not dealing with templates here [ci skip] | ||||
* | | Simplify if statements | Łukasz Strzałkowski | 2013-08-25 | 1 | -6/+4 |
| | | |||||
* | | Describe BasicRendering shortly | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+4 |
| | | | | | | | | [ci skip] | ||||
* | | Extend basic rendering, test it in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -3/+16 |
| | | |||||
* | | Fist stab on basic rendering | Łukasz Strzałkowski | 2013-08-25 | 2 | -0/+19 |
| | | |||||
* | | Do not include action_view/layouts | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | | | | | | | | We don't need them. They'll be loaded automaticly if AV will be included | ||||
* | | Add #rendered_format method to controllers | Łukasz Strzałkowski | 2013-08-25 | 1 | -4/+4 |
| | | |||||
* | | Do not load AV inside AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | | | | | | | | Move that part to AV railtie | ||||
* | | Revert "Move setting content_type to AV" | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 |
| | | | | | | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc. | ||||
* | | Change documentation of metal anonymous class | Łukasz Strzałkowski | 2013-08-25 | 1 | -5/+10 |
| | | | | | | | | | | | | Make it clearer [ci skip] | ||||
* | | Move setting content_type to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | | |||||
* | | Indent protected methods | Łukasz Strzałkowski | 2013-08-25 | 1 | -18/+18 |
| | | | | | | | | [ci skip] | ||||
* | | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 2 | -3/+0 |
| | |