Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 4 | -4/+4 |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | No need to :doc: a public method | Akira Matsuda | 2017-01-05 | 1 | -1/+1 |
| | |||||
* | Remove deprecated ActionController::Metal.call | Rafael Mendonça França | 2017-01-03 | 1 | -8/+0 |
| | |||||
* | Remove deprecated Metal#env | Rafael Mendonça França | 2017-01-03 | 1 | -5/+0 |
| | |||||
* | Extract variant setter to process method | Jon Moss | 2017-01-02 | 1 | -0/+6 |
| | | | | | | | Provide an API interface similar to how format is handled in Controllers. In situations where variants are not needed (ex: in Action Mailer) the method will simply trigger a no-op, and will not affect end users. | ||||
* | renderers typo fix [ci skip] | ota42y | 2016-12-27 | 1 | -1/+1 |
| | |||||
* | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 5 | -31/+30 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 3 | -6/+6 |
| | |||||
* | updating docs | Aaron Patterson | 2016-12-21 | 1 | -0/+4 |
| | |||||
* | Document and update API for `skip_parameter_encoding` | Aaron Patterson | 2016-12-21 | 2 | -12/+27 |
| | | | | | | | | This commit changes `parameter_encoding` to `skip_parameter_encoding`. `skip_parameter_encoding` will set encoding on all parameters to ASCII-8BIT for a given action on a particular controller. This allows the controller to handle data when the encoding of that data is unknown, for example file systems or truly binary parameters. | ||||
* | Merge pull request #27408 from matthewd/charset-fix | Matthew Draper | 2016-12-20 | 1 | -3/+3 |
|\ | | | | | Only default the response charset when it is first set | ||||
| * | Only default the response charset when it is first set | Matthew Draper | 2016-12-20 | 1 | -3/+3 |
| | | | | | | | | | | If it is explicitly cleared (e.g., response.sending_file = true), then we should not try to set it again. | ||||
* | | Merge pull request #27146 from maclover7/jm-fix-27145 | Eileen M. Uchitelle | 2016-12-19 | 1 | -2/+0 |
|\ \ | |/ |/| | Do not clear HTTP_COOKIES header after request | ||||
| * | Do not clear HTTP_COOKIES header after request | Jon Moss | 2016-12-11 | 1 | -2/+0 |
| | | |||||
* | | Missing require "active_support/testing/constant_lookup" | Akira Matsuda | 2016-12-14 | 1 | -0/+1 |
|/ | |||||
* | Do not try to set the content_type if the format is nil | Rafael Mendonça França | 2016-12-05 | 1 | -1/+1 |
| | |||||
* | Document 'false' as option for 'action_on_unpermitted_parameters' | Daniel Carral | 2016-11-29 | 1 | -2/+2 |
| | | | | [ci skip] | ||||
* | Fix a force ssl redirection bug that occur when session store disabled. | Taishi Kasuga | 2016-11-22 | 1 | -1/+1 |
| | |||||
* | Fixed CONTENT_LENGTH header in ActionController::TestRequest | Artem Rashev | 2016-11-15 | 1 | -2/+3 |
| | | | | | | | | | | | | | CONENT_LENGTH setted by string length, which is equal to number of characters in string but StringIO.length is byte sequence and when payload contains non-ASCII characters, stream's length will be different. That's why real byte length should be used for CONTENT_LENGTH header. Add unit test for CONTENT_LENGTH header fix It just passes non-ascii symbols as parameters and verifies that "CONTENT_LENGTH" header has content bytes count as value. | ||||
* | Merge pull request #26905 from bogdanvlviv/docs | Andrew White | 2016-11-13 | 2 | -2/+2 |
|\ | | | | | Add missing `+` around a some literals. | ||||
| * | Add missing `+` around a some literals. | bogdanvlviv | 2016-10-27 | 2 | -2/+2 |
| | | | | | | | | | | | | Mainly around `nil` [ci skip] | ||||
* | | removes unconventional "then" in case expression | Xavier Noria | 2016-11-13 | 1 | -1/+1 |
| | | |||||
* | | revises style in recent code (of mine) | Xavier Noria | 2016-11-13 | 1 | -5/+7 |
| | | | | | | | | | | This alternative case expressions read better for my taste, and look more uniform in a file where other similar case expressions are used (without dynamic clauses). | ||||
* | | significant speedup of AC::Parameters#permit | Xavier Noria | 2016-11-12 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation of AC::Parameters#permit builds permitted hashes and then calls permit! on them. This filtering is recursive, so we call permit! on terminal branches, but then ascendants call permit! on themselves when the recursion goes up the stack, which recurses all the way down again because permit! is recursive itself. Repeat this for every parent node and you get some scary O-something going on that I don't even want to compute. Instead, since the whole point of the permit recursion is to build permitted hashes along the way and at that point you know you've just come up with a valid filtered version, you can already switch the toggle on the spot. I have seen 2x speedups in casual benchmarks with small structures. As the previous description shows, the difference in performance is going to be a function of the nesting. Note that that the involved methods are private and used only by permit. | ||||
* | | adds a missing dot [ci skip] | Xavier Noria | 2016-11-11 | 1 | -1/+1 |
| | | |||||
* | | adds support for arbitrary hashes in strong parameters | Xavier Noria | 2016-11-11 | 1 | -0/+45 |
| | | |||||
* | | Merge pull request #26820 from y-yagi/add_bang_merge_to_parameters | Rafael França | 2016-11-10 | 1 | -0/+7 |
|\ \ | | | | | | | add `ActionController::Parameters#merge!` | ||||
| * | | add `ActionController::Parameters#merge!` | yuuji.yaginuma | 2016-10-18 | 1 | -0/+7 |
| |/ | | | | | | | | | This method has the same behavior as `Hash#merge!`, returns current `ActionController::Parameters`. | ||||
* | | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 10 | -12/+12 |
| | | |||||
* | | remove unused `RedirectBackError` class | yuuji.yaginuma | 2016-10-27 | 1 | -8/+0 |
|/ | | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8 | ||||
* | Allow any key in Renderer environment hash | Sammy Larbi | 2016-10-15 | 1 | -1/+3 |
| | | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering. | ||||
* | ActionController::Parameters#deep_dup (#26567) | Pavel Evstigneev | 2016-10-11 | 1 | -0/+7 |
| | | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev] | ||||
* | Add missing @, fix indents. [ci skip] | bogdanvlviv | 2016-10-10 | 1 | -6/+6 |
| | |||||
* | Remove deprecated support to passing strings to the middleware stack | Rafael Mendonça França | 2016-10-10 | 1 | -1/+1 |
| | |||||
* | Remove deprecated support to non-keyword arguments #process | Rafael Mendonça França | 2016-10-10 | 1 | -70/+16 |
| | |||||
* | Remove deprecated `xml_http_request` and `xhr` methods | Rafael Mendonça França | 2016-10-10 | 1 | -15/+0 |
| | |||||
* | Remove deprecated methods in ActionController::Parameters | Rafael Mendonça França | 2016-10-10 | 1 | -20/+0 |
| | |||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 1 | -9/+0 |
| | |||||
* | Remove deprecated support to :text in render | Rafael Mendonça França | 2016-10-10 | 1 | -12/+1 |
| | |||||
* | Remove deprecated support to :nothing in render | Rafael Mendonça França | 2016-10-09 | 1 | -5/+0 |
| | |||||
* | Remove deprecated support to `:back` in `redirect_to` | Rafael Mendonça França | 2016-10-09 | 1 | -8/+0 |
| | |||||
* | Remove deprecated support for status option in head | Rafael Mendonça França | 2016-10-09 | 1 | -7/+1 |
| | |||||
* | Remove deprecation at ActionController::BadRequest | Rafael Mendonça França | 2016-10-09 | 1 | -11/+1 |
| | |||||
* | Remove obsolete comment about class-level respond_to | Andrew White | 2016-10-01 | 1 | -2/+0 |
| | | | | | | The class-level respond_to was extracted in ee77770 to responders gem [ci skip] | ||||
* | Merge pull request #26573 from kirs/action-controller-as-format | Rafael França | 2016-09-27 | 1 | -4/+4 |
|\ | | | | | Make :as option also set request format (AC::TestCase) | ||||
| * | Make :as option also set request format (AC::TestCase) | Kir Shatrov | 2016-09-21 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | right now you'd have to specify both :as and :format: ``` post :create, params: { foo: "bar" } as: :json, format: :json ``` | ||||
* | | Correct `render text:` deprecation message | Jack Bracewell | 2016-09-14 | 1 | -1/+1 |
| | | | | | | The default Content-Type is `text/html`, not `text/plain`. | ||||
* | | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 4 | -15/+15 |
| | | | | | | | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | | Do not mutate AC::TestRequest::DEFAULT_OPTIONS | Kir Shatrov | 2016-09-10 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #26418 from y-yagi/fixes_26415 | Richard Schneeman | 2016-09-07 | 1 | -1/+1 |
|\ | | | | | call `.to_h` to avoid using deprecated method |