aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
...
* | | [ci skip] Fix capitalizationAkshay Vishnoi2014-06-071-1/+1
| | |
* | | eliminate wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|/ /
* | Avoid misuse of underscore argumentCorey Ward2014-06-051-2/+2
| | | | | | Per convention, underscore-only argument names should be used for unused parameters.
* | Convert StrongParameters cache to a hash. This fixes an unboundedRyan Davis2014-06-031-6/+6
| | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html
* | Merge branch 'constraints'Aaron Patterson2014-05-271-3/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * | skip the build business if the stack is emptyAaron Patterson2014-05-261-2/+6
| | |
| * | stop hardcoding path_parameters and get it from the requestAaron Patterson2014-05-261-1/+2
| | |
* | | Merge pull request #15325 from tgxworld/no_need_to_call_to_sYves Senn2014-05-261-1/+1
|\ \ \ | | | | | | | | Remove duplicated to_s method call.
| * | | Remove duplicated to_s method call.Guo Xiang Tan2014-05-251-1/+1
| |/ /
* / / Fix docs for ActionController::Renderers.addGuillermo Iguaran2014-05-261-1/+1
|/ /
* | use Proc.new to automatically do parameter checking for usAaron Patterson2014-05-231-3/+1
| |
* | use symbol keys for path_parametersAaron Patterson2014-05-222-6/+6
| |
* | we can just use Ruby hereAaron Patterson2014-05-211-2/+2
| |
* | fix formatting and text for ActionController::Redirecting docLaurel Fan2014-05-211-4/+8
| |
* | Merge pull request #11346 from tomykaira/fix_10257Rafael Mendonça França2014-05-201-2/+14
|\ \ | | | | | | Check authentication scheme in Basic auth
| * | Run login_procedure only when the auth_scheme is validtomykaira2013-07-081-7/+14
| | |
| * | Check authentication scheme in Basic authtomykaira2013-07-071-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257.
* | | Add ActionController::Renderers.remove.Zuhao Wan2014-05-201-0/+16
| | |
* | | fixes stack level too deep exception on action named 'status' returning ↵Christiaan Van den Poel2014-05-153-2/+6
| | | | | | | | | | | | 'head :ok'
* | | Merge pull request #14137 from dasch/better-fragment-cache-instrumentationRafael Mendonça França2014-05-141-1/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md
| * | | Add controller and action name to the instrumentation payloadDaniel Schierbeck2014-05-101-1/+7
| | | |
* | | | Add multiple lines message support for SSE moduleayaya2014-05-121-1/+2
| | | |
* | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵Tom Kadwill2014-05-061-1/+1
| | | | | | | | | | | | | | | | improved tests.
* | | | Fix examples indent and improve #process docs a bit [ci skip]Carlos Antonio da Silva2014-05-041-16/+14
| | | |
* | | | Document ActionController::TestCase::Behavior#processGaurish Sharma2014-05-041-0/+27
|/ / / | | | | | | | | | [ci skip]
* | | do not allocate strings while creating urlsAaron Patterson2014-04-301-1/+1
| | |
* | | don't allocate string on hash accessAaron Patterson2014-04-301-1/+1
| | |
* | | ActionController::Renderers documentation fixStevie Graham2014-04-201-2/+2
| | | | | | | | | | | | | | | ActionController::Renderers::RENDERERS is an instance of Set. Docs incorrectly state that it's a Hash.
* | | [ci skip] builtin -> built-inAkshay Vishnoi2014-04-201-1/+1
| | |
* | | Update AC::Metal documentation example [ci skip]Yury Velikanau2014-04-151-1/+2
| | | | | | | | | | | | Include proper module since AV was extracted form AP as mentioned in #14659.
* | | Fix subscriptions not being unsubscribed.Guo Xiang Tan2014-04-141-5/+7
| | |
* | | Tiny doc fix for Strong ParametersIan C. Anderson2014-03-301-1/+1
| | | | | | | | | - accepts_nested_attribute_for -> accepts_nested_attributes_for
* | | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-281-1/+1
| | |
* | | update comments to reflect that options support is not availableFrederick Cheung2014-03-251-2/+2
| | |
* | | re-raise error if error occurs before committing in streamingKevin Casey2014-03-141-10/+11
| | | | | | | | | | | | update the tests, using an if-else
* | | use the body proxy to freeze headersAaron Patterson2014-03-122-3/+9
| | | | | | | | | | | | | | | | | | avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
* | | just ask the response for the commit status, we do not need to ask the jarAaron Patterson2014-03-121-1/+1
| | |
* | | only write the jar if the response isn't committedAaron Patterson2014-03-122-5/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
* | | Merge pull request #14280 from joho/make_csrf_failure_logging_optionalSantiago Pastorino2014-03-081-1/+7
|\ \ \ | | | | | | | | Make CSRF failure logging optional/configurable.
| * | | Make CSRF failure logging optional/configurable.John Barton (joho)2014-03-051-1/+7
| | | | | | | | | | | | | | | | | | | | Added the log_warning_on_csrf_failure option to ActionController::RequestForgeryProtection which is on by default.
* | | | Do note remove `Content-Type` when `render :body`Prem Sichanugrist2014-03-052-5/+3
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da.
* | | Add spaces to deep_munge log message.Shuhei Kagawa2014-03-031-3/+3
| | |
* | | use built-in exception handling in live controllersAaron Patterson2014-02-281-2/+5
| | | | | | | | | | | | | | | | | | when an exception happens in an action before the response has been committed, then we should re-raise the exception in the main thread. This lets us reuse the existing exception handling.
* | | live controllers should have live responsesAaron Patterson2014-02-282-8/+36
| | | | | | | | | | | | | | | | | | detect the type of controller we're testing and return the right type of response based on that controller. This allows us to stop doing the weird sleep thing.
* | | set the error callback to a nice default in case nobody set an error ↵Aaron Patterson2014-02-281-1/+1
| | | | | | | | | | | | callback and an error happens
* | | Fix controller test not resetting @_url_optionsTony Wooster2014-02-262-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 4f2cd3e9 introduced a bug by reordering the call to `@controller.recycle!` above the call to `build_request_uri`. The impact of this was that the `@_url_options` cache ends up not being reset between building a request URI (occurring within the test controller) and the firing of the actual request. We encountered this bug because we had the following setup: class MinimumReproducibleController < ActionController::Base before_filter { @param = 'param' } def index render text: url_for(params) end def default_url_options { custom_opt: @param } end end def test_index get :index # builds url, then fires actual request end The first step in `get :index` in the test suite would populate the @_url_options cache. The subsequent call to `url_for` inside of the controller action would then utilize the uncleared cache, thus never calling the now-updated default_url_options. This commit fixes this bug calling recycle! twice, and removes a call to set response_body, which should no longer be needed since we're recycling the request object explicitly.
* | | Simple Sungularize ActionController::UnpermittedParameters error in case ↵Serj L2014-02-242-2/+2
| | | | | | | | | | | | when only 1 parameter is unpermitted.
* | | Update Docs in favor to use render plain instead of text optionrobertomiranda2014-02-183-8/+8
| | | | | | | | | | | | ref #14062
* | | Add `#no_content_type` attribute to `AD::Response`Prem Sichanugrist2014-02-182-8/+6
| | | | | | | | | | | | | | | Setting this attribute to `true` will remove the content type header from the request. This is use in `render :body` feature.
* | | Cleanup `ActionController::Rendering`Prem Sichanugrist2014-02-181-11/+27
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-21 11:16:21 +0000