aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* removes usage of Object#in? from the code base (the method remains defined ↵Xavier Noria2012-08-061-2/+2
| | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
* Renamed _path_segments to _recallBogdan Gusiev2012-08-042-2/+2
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-041-1/+1
|\ | | | | | | | | | | Conflicts: activemodel/lib/active_model/secure_password.rb activerecord/lib/active_record/associations/collection_proxy.rb
| * use 'HTTP_AUTHORIZATION' instead of :authorization as key when dealing with ↵Francesco Rodriguez2012-07-271-1/+1
| | | | | | | | HTTP Token authentication in integration tests
* | Collapsed dual checks (one for content headers and one for content) into a ↵Armand du Plessis2012-08-021-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | single check. Rails includes a single character body to a head(:no_content) response to work around an old Safari bug where headers were ignored if no body sent. This patch brings the behavior slightly closer to spec if :no_content/204 is explicity requested via a head only response. Status comparison done on symbolic and numeric values Not returning any content when responding with head and limited to a status code that explicitly states no content will be returned - 100..199, 204, 205, 304.
* | Merge pull request #7240 from steveklabnik/fix_2301Rafael Mendonça França2012-08-021-1/+1
|\ \ | | | | | | Fix for digest authentication bug - issue #2301 in rails/rails
| * | Fix for digest authentication bug - issue #2301 in rails/railsArthur Smith2012-08-021-1/+1
| | |
* | | load active_support/core_ext/class/attribute in active_support/railsXavier Noria2012-08-029-9/+0
| | |
* | | load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-021-1/+0
| | |
* | | load active_support/core_ext/object/blank in active_support/railsXavier Noria2012-08-025-5/+0
|/ /
* | Merge pull request #7204 from frodsan/update_conventionsRafael Mendonça França2012-07-311-8/+8
|\ \ | | | | | | Follow code conventions in metal/live
| * | update coding conventions in metal/liveFrancesco Rodriguez2012-07-301-8/+8
| | |
* | | fix nodoc in metal/liveFrancesco Rodriguez2012-07-301-4/+4
|/ /
* | fix typo in metal/live [ci skip]Francesco Rodriguez2012-07-301-6/+6
| |
* | close the response when the response body is set so that normal render calls ↵Aaron Patterson2012-07-291-0/+5
| | | | | | | | will work
* | header hash is duped before being sent up the rack stackAaron Patterson2012-07-291-0/+4
| |
* | freeze the header objectAaron Patterson2012-07-291-0/+5
| |
* | make sure set_response! sets the correct response objectAaron Patterson2012-07-291-0/+9
| |
* | adding a more docs on closing response streamsAaron Patterson2012-07-291-1/+4
| |
* | pushing Buffer up to LiveAaron Patterson2012-07-291-22/+22
| |
* | adding some docsAaron Patterson2012-07-291-1/+26
| |
* | Controller actions are processed in a separate thread for liveAaron Patterson2012-07-292-4/+36
| | | | | | | | | | | | | | | | | | | | responses. Processing controller actions in a separate thread allows us to work around the rack api - we can allow the user to set status and headers, then block until the first bytes are written. As soon as the first bytes are written, the main thread can return the status, headers, and (essentially) a queue for the body.
* | raise exceptions on header set after response committedAaron Patterson2012-07-291-0/+21
| |
* | added live responses which can be written and read in separate threadsAaron Patterson2012-07-291-0/+42
| |
* | adding a buffered stream to the response objectAaron Patterson2012-07-291-1/+1
| |
* | initialize ivars, refactor recycle! to call initializeAaron Patterson2012-07-291-9/+1
| |
* | issue a warning when we cannot construct a controllerAaron Patterson2012-07-281-2/+10
| |
* | threads can wait on responses to be committedAaron Patterson2012-07-271-0/+1
| |
* | * Do not convert digest auth strings to symbols. CVE-2012-3424Aaron Patterson2012-07-261-2/+2
|/ | | | | Conflicts: actionpack/lib/action_controller/metal/http_authentication.rb
* copy-edits 9674d2cXavier Noria2012-07-211-2/+2
|
* Merge pull request #7100 from shigeya/fix_mime_responds_to_docXavier Noria2012-07-201-1/+2
|\ | | | | Clarification to doc of ActionController::MimeResponse.respond_to
| * Clarification to doc of ActionController::MimeResponse.respond_toShigeya Suzuki2012-07-191-1/+2
| | | | | | | | | | - #respond_to's documentation refer to .respond_to, but it was written as just <respond_to>. Added class name for clarification.
* | Clean up Sweeper controller accessor when an Error is raisedBrian John2012-07-201-2/+7
|/
* Fix code comment to reflect its intent.Selem Delul2012-07-111-1/+1
|
* Don't raise an error if http auth token isn't well formattedPiotr Sarnacki2012-07-111-4/+6
| | | | | | | | | | | | | | When someone sends malformed authorization header, like: Authorization: Token foobar given token should be just ignored and resource should not be authorized, instead of raising error. Before this patch controller would return 401 header only for well formed tokens, like: Authorization: Token token=foobar and would return 500 in former case.
* deprecate `describe` without a block.Aaron Patterson2012-07-091-1/+1
| | | | | minitest/spec provides `describe`, so deprecate the rails version and have people use the superclass version
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-07-071-3/+0
|\
| * ActionDispatch::ClosedError no longer is raised. See d142572567 for more info.Nick Howard2012-06-301-3/+0
| |
* | Use "instance_accessor" for flash types class attributeCarlos Antonio da Silva2012-07-071-3/+3
| |
* | Added support add_flash_typeskennyj2012-07-071-8/+23
| |
* | Revert "push parameter instantiation to one method"Aaron Patterson2012-07-051-1/+1
| | | | | | | | | | | | | | This reverts commit 9669f6f7883787aa209207cab68b1069636aed9e. This breaks Sam Ruby's tests for some reason. Revert until we figure it out.
* | Merge branch 'master' into testcleanAaron Patterson2012-07-051-2/+7
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Add documentation for inheritance_column method Use ArgumentError vs. RuntimeError, which is more precise. CSV fixtures aren't supported by default anymore, update generated test_helper.rb to reflect that fix quoting for ActiveSupport::Duration instances Add few information on the field types Add the options method to action_controller testcase.
| * | Add the options method to action_controller testcase.François de Metz2012-07-041-2/+7
| | | | | | | | | | | | Signed-off-by: François de Metz <francois@stormz.me>
* | | push parameter instantiation to one methodAaron Patterson2012-07-031-1/+1
| | |
* | | add Mime.fetch so we can have default mime typesAaron Patterson2012-07-031-2/+1
| | |
* | | make the default environment have actual defaultsAaron Patterson2012-07-031-2/+9
| | | | | | | | | | | | | | | | | | instead of deleting keys on every instantiation, create defaults we actually use. eventually we can pass an environment in to the request, and create a new req / res object on each call.
* | | assing the request on the response only onceAaron Patterson2012-07-031-4/+5
| | |
* | | group things that are alikeAaron Patterson2012-07-032-10/+10
| | |
* | | push functional test specific methods to it's own moduleAaron Patterson2012-07-032-9/+15
| | |
* | | test should be testing to_param not to_s, remove Array subclassAaron Patterson2012-07-031-5/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 07:56:40 +0000