Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | push the cookie writing stuff out of the controller | Aaron Patterson | 2012-07-03 | 2 | -23/+8 | |
| | | | | | | | | | | | | merging cookies is responsibility of the test runner | |||||
* | | | extend the controller with special logic on recycle | Aaron Patterson | 2012-07-03 | 2 | -16/+28 | |
| | | | | | | | | | | | | | | | | | | For some reason, this special logic is only supposed to be executed on the second request. For now, we'll extend on recycle, but we should figure out why this functionality can't be run on every request | |||||
* | | | push req / res setting to the test runner | Aaron Patterson | 2012-07-03 | 2 | -5/+10 | |
| | | | | | | | | | | | | | | | Try to avoid making the controller mutate itself so that we can eventually make the response async | |||||
* | | | extract response setting to a method | Aaron Patterson | 2012-07-03 | 1 | -2/+8 | |
|/ / | ||||||
* | | push response creation down since third param is never used. | Aaron Patterson | 2012-07-02 | 1 | -3/+3 | |
| | | ||||||
* | | Remove ActiveModel dependency from ActionPack | Guillermo Iguaran | 2012-06-30 | 2 | -3/+17 | |
|/ | | | | | | | | ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key). | |||||
* | AS::Callbacks: deprecate monkey patch code | Bogdan Gusiev | 2012-06-26 | 1 | -0/+6 | |
| | | | | | Deprecate usage of filter object with #before and #after methods as around callback | |||||
* | Merge pull request #6805 from tim-vandecasteele/uploadedfile-paramify | Carlos Antonio da Silva | 2012-06-23 | 1 | -1/+1 | |
|\ | | | | | Don't paramify ActionDispatch::Http::UploadedFile in tests | |||||
| * | Don't paramify ActionDispatch::Http::UploadedFile in tests | Tim Vandecasteele | 2012-06-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | To test uploading a file without using fixture_file_upload, a posted ActionDispatch::Http::UploadedFile should not be paramified (just like Rack::Test::UploadedFile). (Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't share the same API, tempfile is not accessible on Rack::Test::UploadedFile as discussed in https://github.com/brynary/rack-test/issues/30) | |||||
* | | add :nodoc: to internal implementations [ci skip] | Francesco Rodriguez | 2012-06-22 | 1 | -1/+1 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-14 | 2 | -8/+26 | |
|\ | ||||||
| * | moar copy edits [ci skip] | Vijay Dev | 2012-06-14 | 1 | -2/+1 | |
| | | ||||||
| * | copy editing [ci skip] | Vijay Dev | 2012-06-14 | 1 | -4/+7 | |
| | | ||||||
| * | fixed http token authentication formatting | Jakub Kuźma | 2012-06-12 | 1 | -8/+13 | |
| | | ||||||
| * | on CSRF whitelisting the argument for :if must be a symbol | Daniel Lopes | 2012-06-07 | 1 | -1/+1 | |
| | | ||||||
| * | fix typos on the CSRF whitelisting doc | Daniel Lopes | 2012-06-07 | 1 | -3/+3 | |
| | | ||||||
| * | Document the CSRF whitelisting on get requests | Daniel Lopes | 2012-06-07 | 1 | -5/+16 | |
| | | ||||||
* | | ActionController::Caching depends on RackDelegation and ↵ | Santiago Pastorino | 2012-06-13 | 1 | -0/+3 | |
| | | | | | | | | AbstractController::Callbacks | |||||
* | | Symbol responds_to :upcase & :downcase in Ruby >= 1.9 | Akira Matsuda | 2012-06-06 | 1 | -1/+1 | |
|/ | ||||||
* | Extracted redirect logic from ActionController::Force::ClassMethods.force_ssl | Jeremy Friesen | 2012-05-31 | 1 | -7/+15 | |
| | | | | | | | | | | | | | Prior to this patch the existing .force_ssl method handles both defining the filter and handling the logic for performing the redirect. With this patch the logic for redirecting to the HTTPS protocol is separated from the filter logic that determines if a redirect should occur. By separating the two levels of behavior, an instance method for ActionController (i.e. #force_ssl_redirect) is exposed and available for more granular SSL enforcement. Cleaned up indentation. | |||||
* | Fix sorting of helpers from different paths | Piotr Sarnacki | 2012-05-28 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | When more than one directory for helpers is provided to a controller, it should preserver the order of directories. Given 2 paths: MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"] helpers from dir1 should be loaded first. Before this commit, all helpers were mixed and then sorted alphabetically, which essentially would require to rename helpers to get desired order. This is a problem especially for engines, where you would like to be able to predict accurately which engine helpers will load first. (closes #6496) | |||||
* | Escape the extension when normalizing the action cache path. | Andrew White | 2012-05-20 | 1 | -2/+3 | |
| | | | | | | | | | Although no recognized formats use non-ASCII characters, sometimes they can be included in the :format parameter because of invalid URLS. To prevent encoding incompatibility errors we need to escape them before passing the path to URI.unescape. Closes #4379 | |||||
* | Raise ActionController::BadRequest for malformed parameter hashes. | Andrew White | 2012-05-20 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051 | |||||
* | Show in log correct wrapped keys | Dmitry Vorotilin | 2012-05-20 | 1 | -1/+2 | |
| | ||||||
* | Make AC::LogSubscriber#send_file like #send_data | Alexey Vakhov | 2012-05-19 | 1 | -3/+1 | |
| | ||||||
* | Fix incorrect assert_block -> assert conversion. Assumed too much from the ↵ | Jeremy Kemper | 2012-05-17 | 1 | -2/+2 | |
| | | | | MiniTest deprecation message. | |||||
* | MiniTest deprecated #assert_block in favor of calling #assert with a block | Jeremy Kemper | 2012-05-17 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #2237 from jackdempsey/log_redirect_to | Aaron Patterson | 2012-05-16 | 1 | -0/+1 | |
|\ | | | | | log at debug level what line caused the redirect_to | |||||
| * | log at debug level what line caused the redirect_to | Jack Dempsey | 2012-05-16 | 1 | -0/+1 | |
| | | ||||||
* | | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 10 | -34/+12 | |
| | | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-12 | 1 | -42/+44 | |
|\ \ | | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | |||||
| * | | Move HTTP Token auth docs above the Token module | Elia Schito | 2012-05-11 | 1 | -42/+44 | |
| | | | ||||||
* | | | Move require to where it's needed | Santiago Pastorino | 2012-05-11 | 1 | -0/+1 | |
| | | | ||||||
* | | | remove duplicate usage of Rack::Utils.status_code in ↵ | Rafael Magana | 2012-05-10 | 1 | -1/+1 | |
|/ / | | | | | | | LogSubscriber#process_action | |||||
* | | If content_type is explicitly passed to the :head method use the value or ↵ | Kunal Shah | 2012-05-08 | 1 | -1/+2 | |
| | | | | | | | | fallback | |||||
* | | remove .new from raise ActionController::UnknownFormat | Steven Soroka | 2012-05-06 | 1 | -1/+1 | |
| | | ||||||
* | | Raise a rescuable exception when Rails doesn't know what to do with the ↵ | Steven Soroka | 2012-05-06 | 2 | -2/+4 | |
| | | | | | | | | format, rather than responding with a head :not_acceptable (406) | |||||
* | | Use Hash#fetch instead of has_key? check | Carlos Antonio da Silva | 2012-05-04 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #4445 from nragaz/role_based_params_wrapping | José Valim | 2012-05-04 | 1 | -2/+3 | |
| | | | | | | | | specify a role for identifying accessible attributes when wrapping params | |||||
* | | Improve assert_template layout checking | Alexey Vakhov | 2012-05-04 | 1 | -3/+15 | |
| | | ||||||
* | | Fix assert_template :layout => nil assertion | Alexey Vakhov | 2012-05-04 | 1 | -2/+5 | |
| | | ||||||
* | | Fix assert_template assertion with :layout option | Alexey Vakhov | 2012-05-04 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #6148 from twinturbo/head-fix | José Valim | 2012-05-03 | 1 | -1/+21 | |
|\ \ | | | | | | | Make ActionController#head pass rack-link | |||||
| * | | Remove content-length as well | twinturbo | 2012-05-03 | 1 | -2/+3 | |
| | | | ||||||
| * | | Make ActionController#head pass rack-link | twinturbo | 2012-05-03 | 1 | -1/+20 | |
| | | | ||||||
* | | | added proc evaluation for action cache's layout parameter | Nico | 2012-05-02 | 1 | -2/+4 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 2 | -2/+2 | |
|\ \ \ | |/ / |/| | | ||||||
| * | | Code-format references to config settings | Mark Rushakoff | 2012-04-27 | 1 | -1/+1 | |
| | | | ||||||
| * | | More using <tt>x</tt> instead of +x+ when the latter renders improperly. | Mark Rushakoff | 2012-04-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #6078 from lest/patch-4 | José Valim | 2012-04-30 | 1 | -18/+12 | |
|\ \ \ | | | | | | | | | allow send_file/send_data to skip disposition header, closes #2973 |