aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
...
* | | we don't really need an extra method to set the script nameAaron Patterson2015-07-101-5/+1
| | |
* | | Remove useless conditionalAaron Patterson2015-07-101-12/+0
| | | | | | | | | | | | PATH_INFO is already set, so this branch will never execute.
* | | default `PATH_INFO` to the generated pathAaron Patterson2015-07-101-1/+2
| | | | | | | | | | | | | | | | | | we were already generating a path in the previous code (it was just not returned), so lets just use the already computed path to popluate the PATH_INFO header
* | | always default the SCRIPT_NAME to whatever is on the controllerAaron Patterson2015-07-101-1/+1
| | |
* | | remove useless ivar clearingAaron Patterson2015-07-101-6/+0
| | | | | | | | | | | | Since we only work with new instances, these ivars will not be set.
* | | call the `path_parameters=` setter rather than rely on mutationsAaron Patterson2015-07-101-1/+3
| | | | | | | | | | | | | | | We should call the setter on `path_parameters` so that we know the hash will only contain the values that we've set.
* | | start collecting `env` mutationsAaron Patterson2015-07-101-5/+3
| | | | | | | | | | | | | | | I'd like to put all env mutations together so we can understand how to change this code to call `call` on the controller
* | | Parameters are converted to a query stringAaron Patterson2015-07-101-17/+0
| | | | | | | | | | | | | | | Since parameters are converted to a query string, they will automatically be turned in to strings by the query parser
* | | no more HWIAAaron Patterson2015-07-101-1/+1
| | | | | | | | | | | | | | | non_path_parameters is used internally (it never escapes this method) so we should be able to safely use a regular hash.
* | | remove param dup'ing logicAaron Patterson2015-07-101-8/+0
| | | | | | | | | | | | | | | since we are serializing parameters, we don't need to do all the dup checks on each object.
* | | encode / decode parameters before assigning them to the requestAaron Patterson2015-07-101-5/+58
|/ / | | | | | | | | | | We should roundtrip the parameters through their respective encoders / decoders so that the controller will get parameters similar to what they actually get in a real world situation
* | set parameters as a query stringAaron Patterson2015-07-091-6/+9
| | | | | | | | | | | | We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world
* | build and assign parameters rather than rely on mutationsAaron Patterson2015-07-081-1/+15
| | | | | | | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters`
* | assign the cookie hash on request allocationAaron Patterson2015-07-081-1/+1
| | | | | | | | this prevents mutations from being available globally
* | request objects are no longer recycledAaron Patterson2015-07-081-10/+8
| | | | | | | | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not.
* | add a new constructor for allocating test requestsAaron Patterson2015-07-081-11/+13
| |
* | pass the starting env and session to build_requestAaron Patterson2015-07-081-3/+3
| |
* | pass the session and env in to the test requestAaron Patterson2015-07-081-4/+8
| |
* | allocate new responses rather than recycling themAaron Patterson2015-07-081-12/+5
| | | | | | | | | | There is no reason to "recycle" response objects when we can just allocate a new one.
* | pass cookies from the jar in the HTTP_COOKIE headereileencodes2015-07-071-8/+7
| | | | | | | | | | we should be pushing the cookies in via headers rather than maintaining some object and "recycling" it.
* | Send cookies with requesteileencodes2015-07-071-1/+4
|/
* Merge pull request #20276 from davetron5000/revert-head-on-no-templateKasper Timm Hansen2015-06-271-2/+17
|\ | | | | Allow default_render to take a block to customize behavior when there's no template
| * Override default_render's behavior with a blockDave Copeland2015-06-201-2/+17
| | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
* | Merge pull request #20659 from ↵Yves Senn2015-06-221-2/+4
|\ \ | | | | | | | | | | | | | | | vngrs/strong_parameters_unpermitted_parameters_wrong_doc_fix Fix the documentation about ActionController::UnpermittedParameters [ci skip]
| * | Fix the documentation about ActionController::UnpermittedParameters [ci skip]Mehmet Emin İNAÇ2015-06-221-2/+4
|/ /
* / Fix the documentation about ActionController::ParameterMissing [ci skip]Mehmet Emin İNAÇ2015-06-221-5/+5
|/
* Deprecate passing hash as first parameter into ActionController::HeadMehmet Emin İNAÇ2015-06-151-2/+12
|
* A few documentation edits [ci skip]Robin Dupret2015-06-152-10/+12
|
* Add missing "header" word in documentation of Token#authentication_request ↵Prathamesh Sonpatki2015-06-141-1/+1
| | | | [ci skip]
* Update RDoc for ActionController::TestCase for kwargs.Victor Costan2015-06-121-1/+1
|
* Merge pull request #20522 from colby-swandale/doc-updateSean Griffin2015-06-111-1/+1
|\ | | | | fixed sring to be string in ActiveRecord::Base params documentation [ci skip]
| * fixed sring to be string in ActiveRecord::Base params documentationColby Swandale2015-06-121-1/+1
| |
* | Mention that doing nothing in Rails API controllers returns 204Santiago Pastorino2015-06-111-1/+1
| |
* | Return 204 if render is not called in API controllersJorge Bejar2015-06-113-6/+15
| |
* | Include ParamsWrapper in AC::APIJorge Bejar2015-06-111-1/+5
| | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it.
* | Fix MimeResponds example in AC::API documentationSantiago Pastorino2015-06-111-3/+5
| |
* | Do not say that Api Controllers are faster than regular ones in docsJorge Bejar2015-06-111-4/+4
| |
* | Remove Compatibility module since we don't remember why it was added :smile:Jorge Bejar2015-06-111-19/+0
| |
* | Remove api_rendering is not neededSantiago Pastorino2015-06-112-15/+1
| |
* | Add ActionController API functionalitySantiago Pastorino2015-06-112-0/+171
|/
* better clarity of params source in ActionController::Base documentation [ci ↵Colby Swandale2015-06-111-3/+3
| | | | skip]
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-06-051-1/+1
|\
| * [ci skip] Upcase `is`yui-knk2015-05-251-1/+1
| |
* | Merge pull request #19094 from phoet/have_bearer_be_valid_as_wellRafael Mendonça França2015-06-011-1/+1
|\ \ | | | | | | Have Bearer be valid as well
| * | allow `Bearer` as well as `Token`phoet2015-06-011-1/+1
| | |
* | | Merge pull request #20138 from tgxworld/deprecated_assert_templateRafael Mendonça França2015-06-012-188/+3
|\ \ \ | |/ / |/| | Deprecate `assert_template` and `assigns()`.
| * | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-302-188/+3
| | |
* | | Use `any?` rather than `present?` to check argseileencodes2015-05-311-1/+1
|/ / | | | | | | | | | | It's better to use Ruby methods when possible over methods defined by Active Support because then it does not need to rely on any dependencies.
* | Remove unused code.Guo Xiang Tan2015-05-291-2/+0
| | | | | | | | Code was moved into the `assign` method.
* | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-281-0/+1
| | | | | | | | `head` method works similar to `render` method with `:nothing` option