aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused requireRyuta Kamizono2017-02-121-2/+0
| | | | | | These files are not using `strip_heredoc`. Closes #27976
* Delete PATH_INFO after each controller test requestDominic Cleal2017-01-231-0/+1
| | | | | | | | | | Prevents PATH_INFO from being used to infer the request format in later test requests when no explicit format is given. As the request PATH_INFO may be set before a request, it can't be deleted during pre-request scrubbing. Fixes #27774
* Revert "significant speedup of AC::Parameters#permit" ↵David Heinemeier Hansson2017-01-161-3/+1
| | | | [26dd9b26ab7317f94fd285245879e888344143b2] as it broke Parameters#to_h on at least fields_for-style nested params.
* AC::ParamsWrapper::Options needs anonymous superclassAkira Matsuda2017-01-131-1/+1
| | | | | | it has some methods that override the accessors and calls the original accessors via `super` this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
* class Foo < Struct.new(:x) creates an extra unneeded anonymous classAkira Matsuda2017-01-131-1/+1
| | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
* fix method name in `Renderer` doc [ci skip]yuuji.yaginuma2017-01-121-1/+2
| | | | `ActionController::Renderer.defaults` was removed in 2db7304
* Revert "Merge pull request #27586 from maclover7/jm-fix-27584"Rafael Mendonça França2017-01-111-2/+3
| | | | | | | This reverts commit 5eff7a9ca7bb2ee7f16db1ab4d11cebe28757ba5, reversing changes made to 5f03172f54a58a57a48a3121562beb2cef866cbe. Reason: It caused a regression. The test case is on the PR.
* Update `cookies` helper on all HTTP requestsJon Moss2017-01-051-3/+2
| | | | | | | | | Regression introduced by ae29142142324545a328948e059e8b8118fd7a33 / 8363b879fe759f0645179f4521cc64795efbee6e. Previously, cookies were only updated on `GET` requests. Now we will update the helper for all requests, as part of `process`. Added regression tests for all available HTTP method helpers in `ActionController::TestCase`.
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-054-4/+4
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* No need to :doc: a public methodAkira Matsuda2017-01-051-1/+1
|
* Remove deprecated ActionController::Metal.callRafael Mendonça França2017-01-031-8/+0
|
* Remove deprecated Metal#envRafael Mendonça França2017-01-031-5/+0
|
* Extract variant setter to process methodJon Moss2017-01-021-0/+6
| | | | | | | Provide an API interface similar to how format is handled in Controllers. In situations where variants are not needed (ex: in Action Mailer) the method will simply trigger a no-op, and will not affect end users.
* renderers typo fix [ci skip]ota42y2016-12-271-1/+1
|
* Privatize unneededly protected methods in Action PackAkira Matsuda2016-12-245-31/+30
|
* No need to nodoc private methodsAkira Matsuda2016-12-243-6/+6
|
* updating docsAaron Patterson2016-12-211-0/+4
|
* Document and update API for `skip_parameter_encoding`Aaron Patterson2016-12-212-12/+27
| | | | | | | | This commit changes `parameter_encoding` to `skip_parameter_encoding`. `skip_parameter_encoding` will set encoding on all parameters to ASCII-8BIT for a given action on a particular controller. This allows the controller to handle data when the encoding of that data is unknown, for example file systems or truly binary parameters.
* Merge pull request #27408 from matthewd/charset-fixMatthew Draper2016-12-201-3/+3
|\ | | | | Only default the response charset when it is first set
| * Only default the response charset when it is first setMatthew Draper2016-12-201-3/+3
| | | | | | | | | | If it is explicitly cleared (e.g., response.sending_file = true), then we should not try to set it again.
* | Merge pull request #27146 from maclover7/jm-fix-27145Eileen M. Uchitelle2016-12-191-2/+0
|\ \ | |/ |/| Do not clear HTTP_COOKIES header after request
| * Do not clear HTTP_COOKIES header after requestJon Moss2016-12-111-2/+0
| |
* | Missing require "active_support/testing/constant_lookup"Akira Matsuda2016-12-141-0/+1
|/
* Do not try to set the content_type if the format is nilRafael Mendonça França2016-12-051-1/+1
|
* Document 'false' as option for 'action_on_unpermitted_parameters'Daniel Carral2016-11-291-2/+2
| | | | [ci skip]
* Fix a force ssl redirection bug that occur when session store disabled.Taishi Kasuga2016-11-221-1/+1
|
* Fixed CONTENT_LENGTH header in ActionController::TestRequestArtem Rashev2016-11-151-2/+3
| | | | | | | | | | | | | CONENT_LENGTH setted by string length, which is equal to number of characters in string but StringIO.length is byte sequence and when payload contains non-ASCII characters, stream's length will be different. That's why real byte length should be used for CONTENT_LENGTH header. Add unit test for CONTENT_LENGTH header fix It just passes non-ascii symbols as parameters and verifies that "CONTENT_LENGTH" header has content bytes count as value.
* Merge pull request #26905 from bogdanvlviv/docsAndrew White2016-11-132-2/+2
|\ | | | | Add missing `+` around a some literals.
| * Add missing `+` around a some literals.bogdanvlviv2016-10-272-2/+2
| | | | | | | | | | | | Mainly around `nil` [ci skip]
* | removes unconventional "then" in case expressionXavier Noria2016-11-131-1/+1
| |
* | revises style in recent code (of mine)Xavier Noria2016-11-131-5/+7
| | | | | | | | | | This alternative case expressions read better for my taste, and look more uniform in a file where other similar case expressions are used (without dynamic clauses).
* | significant speedup of AC::Parameters#permitXavier Noria2016-11-121-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation of AC::Parameters#permit builds permitted hashes and then calls permit! on them. This filtering is recursive, so we call permit! on terminal branches, but then ascendants call permit! on themselves when the recursion goes up the stack, which recurses all the way down again because permit! is recursive itself. Repeat this for every parent node and you get some scary O-something going on that I don't even want to compute. Instead, since the whole point of the permit recursion is to build permitted hashes along the way and at that point you know you've just come up with a valid filtered version, you can already switch the toggle on the spot. I have seen 2x speedups in casual benchmarks with small structures. As the previous description shows, the difference in performance is going to be a function of the nesting. Note that that the involved methods are private and used only by permit.
* | adds a missing dot [ci skip]Xavier Noria2016-11-111-1/+1
| |
* | adds support for arbitrary hashes in strong parametersXavier Noria2016-11-111-0/+45
| |
* | Merge pull request #26820 from y-yagi/add_bang_merge_to_parametersRafael França2016-11-101-0/+7
|\ \ | | | | | | add `ActionController::Parameters#merge!`
| * | add `ActionController::Parameters#merge!`yuuji.yaginuma2016-10-181-0/+7
| |/ | | | | | | | | This method has the same behavior as `Hash#merge!`, returns current `ActionController::Parameters`.
* | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-2910-12/+12
| |
* | remove unused `RedirectBackError` classyuuji.yaginuma2016-10-271-8/+0
|/ | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8
* Allow any key in Renderer environment hashSammy Larbi2016-10-151-1/+3
| | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering.
* ActionController::Parameters#deep_dup (#26567)Pavel Evstigneev2016-10-111-0/+7
| | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev]
* Add missing @, fix indents. [ci skip]bogdanvlviv2016-10-101-6/+6
|
* Remove deprecated support to passing strings to the middleware stackRafael Mendonça França2016-10-101-1/+1
|
* Remove deprecated support to non-keyword arguments #processRafael Mendonça França2016-10-101-70/+16
|
* Remove deprecated `xml_http_request` and `xhr` methodsRafael Mendonça França2016-10-101-15/+0
|
* Remove deprecated methods in ActionController::ParametersRafael Mendonça França2016-10-101-20/+0
|
* Remove deprecated comparing support with `ActionController::Parameters`Rafael Mendonça França2016-10-101-9/+0
|
* Remove deprecated support to :text in renderRafael Mendonça França2016-10-101-12/+1
|
* Remove deprecated support to :nothing in renderRafael Mendonça França2016-10-091-5/+0
|
* Remove deprecated support to `:back` in `redirect_to`Rafael Mendonça França2016-10-091-8/+0
|
* Remove deprecated support for status option in headRafael Mendonça França2016-10-091-7/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 03:09:59 +0000