Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Handle conditional get in live requests - this will prevent error when using ↵ | Bernard Potocki | 2013-03-14 | 1 | -0/+4 |
| | | | | stale on live streams(issue #9636) | ||||
* | Skip fetching path if the iteration is going to be skipped | Carlos Antonio da Silva | 2013-03-11 | 1 | -2/+2 |
| | |||||
* | Merge pull request #9626 from dasch/dasch/instrument-strong-params | José Valim | 2013-03-09 | 2 | -1/+7 |
|\ | | | | | Use AS::Notifications to instrument Strong Params | ||||
| * | Use the instrumentation framework to instrument Strong Params | Daniel Schierbeck | 2013-03-07 | 2 | -1/+7 |
| | | |||||
* | | ensure response.stream is closed | Sam Ruby | 2013-03-09 | 1 | -0/+1 |
| | | |||||
* | | Allow use of assert_template with the :file option. | Justin Coyne | 2013-03-01 | 1 | -1/+16 |
|/ | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1 | ||||
* | fix respond_to without blocks not working if one of the blocks is all | grosser | 2013-02-24 | 1 | -1/+1 |
| | |||||
* | This cache is not needed | Santiago Pastorino | 2013-02-21 | 1 | -2/+1 |
| | |||||
* | Use composition to figure out the forgery protection strategy | Santiago Pastorino | 2013-02-21 | 1 | -9/+27 |
| | |||||
* | Rack::Test::UploadedFile is a permitted scalar | Fabio Kreusch | 2013-02-21 | 1 | -3/+4 |
| | |||||
* | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 1 | -1/+1 |
| | |||||
* | partials inside directory work with `assert_template` | Yves Senn | 2013-02-04 | 1 | -1/+2 |
| | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'. | ||||
* | descriptive `assert_template` error when partial wasn't rendered | Yves Senn | 2013-02-04 | 1 | -0/+3 |
| | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error. | ||||
* | Missing require hash/keys | Akira Matsuda | 2013-02-01 | 2 | -0/+3 |
| | |||||
* | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 2 | -0/+2 |
| | |||||
* | Use \A in Regexps | Egor Homakov | 2013-02-01 | 1 | -1/+1 |
| | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A | ||||
* | Remove caching_allowed? from ActionController::Caching | Michiel Sikkes | 2013-01-28 | 1 | -4/+0 |
| | | | | | Where is this used? No other code references to this method and it isn't being tested anywhere. No tests fail when commented out. | ||||
* | Merge pull request #9032 from firmhouse/head-breaks-csrf | Santiago Pastorino | 2013-01-28 | 1 | -2/+2 |
|\ | | | | | Make HEAD work / convert to GET once more | ||||
| * | Added request.head? to forgery protection code | Michiel Sikkes | 2013-01-22 | 1 | -2/+2 |
| | | |||||
* | | Add keys/values methods to TestSession | Carlos Antonio da Silva | 2013-01-25 | 1 | -0/+8 |
| | | | | | | | | Bring back the same API we have with Request::Session. | ||||
* | | Integrate Action Pack with Rack 1.5 | Carlos Antonio da Silva | 2013-01-25 | 2 | -4/+18 |
| | | | | | | | | | | | | All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino] | ||||
* | | ActionDispatch::Http::UploadedFile is a permitted scalar [Closes #9051] | Xavier Noria | 2013-01-23 | 1 | -2/+5 |
|/ | |||||
* | Only check for unpermmited parameters if | Rafael Mendonça França | 2013-01-22 | 1 | -1/+1 |
| | | | | action_on_unpermitted_parameters is present | ||||
* | avoid creating an object in every call | Xavier Noria | 2013-01-22 | 1 | -1/+2 |
| | | | | This was a suggestion of @carlosantoniodasilva, thanks! | ||||
* | Refactor grep call to remove .each | Carlos Antonio da Silva | 2013-01-20 | 1 | -1/+1 |
| | | | | Grep already yields the matching keys to the given block. | ||||
* | Use 1.9 hash style in docs/comments [ci skip] | Carlos Antonio da Silva | 2013-01-20 | 1 | -3/+3 |
| | |||||
* | Removing warning: shadowing outer local variable | Arun Agrawal | 2013-01-20 | 1 | -3/+3 |
| | |||||
* | strong parameters filters permitted scalars | Xavier Noria | 2013-01-20 | 1 | -22/+92 |
| | |||||
* | Restore and adapt the implementation reverted at | Rafael Mendonça França | 2013-01-19 | 2 | -29/+58 |
| | | | | | | https://github.com/rails/rails/commit/cc1c3c5be061e7572018f734e5239750ab449e3f Now instead of raise, we log by default in development and test | ||||
* | Added ability to raise or log on unpermitted params. | Thomas Drake-Brockman | 2013-01-20 | 2 | -6/+34 |
| | |||||
* | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 2 | -3/+3 |
| | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | ||||
* | User Rails 4 find_by | robertomiranda | 2013-01-18 | 2 | -3/+3 |
| | |||||
* | Remove useless || operation | Carlos Antonio da Silva | 2013-01-17 | 1 | -2/+1 |
| | |||||
* | Deprecate direct calls to AC::RecordIdentifier.dom_id and dom_class | Carlos Antonio da Silva | 2013-01-16 | 1 | -5/+17 |
| | | | | Also add some generic tests to ensure they're properly deprecated. | ||||
* | strong parameters exception handling | Brian Alexander | 2013-01-15 | 1 | -6/+0 |
| | |||||
* | Revert "log at debug level what line caused the redirect_to" | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+0 |
| | | | | | | | | This reverts commit 3fa00070047b5d019d39e691598ee2890283d052. Reason: This message is usually not accurate and annoying: Redirected by ~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/1.9.1/logger.rb:371:in `add'` | ||||
* | Merge pull request #8876 from senny/extract_performance_tests | Guillermo Iguaran | 2013-01-10 | 1 | -3/+0 |
|\ | | | | | Extract ActionDispatch::PerformanceTest | ||||
| * | extract PerformanceTest into rails-performance_tests gem | Yves Senn | 2013-01-10 | 1 | -3/+0 |
| | | |||||
* | | Merge pull request #8821 from jamis/master | Rafael Mendonça França | 2013-01-10 | 1 | -5/+1 |
|\ \ | |/ |/| | | | | | | | | | Evaluate view_cache_dependencies at the instance level Conflicts: actionpack/lib/action_controller/caching.rb | ||||
| * | evaluate the dependency blocks at the instance level, not class level | Jamis Buck | 2013-01-08 | 1 | -5/+1 |
| | | |||||
* | | Fix typo in deprecation warning | Nathaniel Jones | 2013-01-09 | 1 | -1/+1 |
| | | |||||
* | | Fix warning: & interpreted as argument prefix | Carlos Antonio da Silva | 2013-01-08 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-01-09 | 4 | -10/+10 |
|\ \ | |/ |/| | | | | | Conflicts: guides/source/getting_started.md | ||||
| * | prefer american spelling of 'behavior' | Gosha Arinich | 2013-01-07 | 1 | -1/+1 |
| | | |||||
| * | HTTP 302 means Found, not Moved | Chase DuBois | 2013-01-05 | 1 | -1/+1 |
| | | |||||
| * | PUT => PATCH | Akira Matsuda | 2013-01-03 | 1 | -1/+1 |
| | | |||||
| * | find_or_create_by is deprecated in AR 4 | Akira Matsuda | 2013-01-02 | 1 | -3/+3 |
| | | |||||
| * | Model.scoped is deprecated in favour of Model.all | Akira Matsuda | 2013-01-02 | 1 | -4/+4 |
| | | |||||
* | | view_cache_dependency API | Jamis Buck | 2013-01-08 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | A declarative API for specifying dependencies that affect template cache digest computation. In your controller, specify any of said dependencies: view_cache_dependency { "phone" if using_phone? } When the block is evaluated, the resulting value is included in the cache digest calculation, allowing you to generate different digests for effectively the same template. (Mostly useful if you're mucking with template load paths.) | ||||
* | | Revert "unpermitted params" exception -- it's just not going to work. See ↵ | David Heinemeier Hansson | 2013-01-08 | 2 | -59/+11 |
| | | | | | | | | the discussion on https://github.com/rails/strong_parameters/pull/75. |