Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Also move asset_path to AbstractController. | José Valim | 2010-07-24 | 1 | -1/+0 | |
| | ||||||
* | Move config_accessor :asset_host from ActionController::Base to ↵ | Jeroen van Dijk and Josh Kalderimis | 2010-07-24 | 1 | -1/+1 | |
| | | | | | | | | AbstractController which fixes issues with asset_host in ActionMailer Including: - Moved mailer objects in separate directory - Added two tests for asset_host configuration option | |||||
* | No need to delegate. Simply include the whole RecordIdentifier module. | José Valim | 2010-07-21 | 1 | -0/+2 | |
| | ||||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 1 | -30/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Moved PolymorphicRoutes to ActionDispatch::Routing | Piotr Sarnacki | 2010-07-20 | 2 | -184/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add a test for elapsed and require missing benchmark file. | José Valim | 2010-07-20 | 1 | -0/+1 | |
| | ||||||
* | Add missing require to metal/streaming.rb | José Valim | 2010-07-20 | 1 | -0/+2 | |
| | ||||||
* | Remove unused orig_handler and unneeded parentheses | Santiago Pastorino | 2010-07-20 | 1 | -3/+3 | |
| | ||||||
* | There is absolutely no need to use __send__ here. | José Valim | 2010-07-19 | 1 | -3/+3 | |
| | ||||||
* | No need to create a new module in the previous commit. | José Valim | 2010-07-19 | 3 | -17/+10 | |
| | ||||||
* | Exceptions from views should be rescued based on the original exception. If ↵ | Neeraj Singh | 2010-07-19 | 2 | -2/+18 | |
| | | | | | | | | a handler for original exception is missing then apply ActiveView::TemplateError [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed many references to the old config/environment.rb and Rails::Initializer | Benjamin Quorning | 2010-07-13 | 1 | -1/+1 | |
| | ||||||
* | Fix setting helpers_path to a string or pathname | Jeremy Kemper | 2010-07-07 | 1 | -2/+3 | |
| | ||||||
* | Define a convention for descendants and subclasses. | José Valim | 2010-07-05 | 2 | -7/+0 | |
| | | | | | | The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children. By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts. | |||||
* | Fixes for "router" and "routes" terminology | Wincent Colaiuta | 2010-07-03 | 3 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit f7ba614c2db improved the internal consistency of the different means of accessing routes, but it introduced some problems at the level of code comments and user-visible strings. This commit applies fixes on three levels: Firstly, we remove or replace grammatically invalid constructs such as "a routes" or "a particular routes". Secondly, we make sure that we always use "the router DSL" or "the router syntax", because this has always been the official terminology. Finally, we make sure that we only use "routes" when referring to the application-specific set of routes that are defined in the "config/routes.rb" file, we use "router" when referring on a more abstract level to "the code in Rails used to handle routing", and we use "routing" when we need an adjective to apply to nouns such as "url_helpers. Again this is consistent with historical practice and other places in the documentation. Note that this is not a sweep over the entire codebase to ensure consistent usage of language; it is just a revision of the changes introduced in commit f7ba614c2db. Signed-off-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 3 | -6/+6 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use caller for helpers_dir deprecation warnings | Jeremy Kemper | 2010-06-28 | 1 | -2/+2 | |
| | ||||||
* | Strip_tags never ending attribute should not raise a TypeError [#4870 ↵ | Bruno Michel | 2010-06-28 | 2 | -0/+2 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Small changes to responder: | José Valim | 2010-06-26 | 1 | -5/+13 | |
| | | | | | | * resources is always an array; * Lazy retrieve request and formats; * Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods. | |||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 4 | -59/+58 | |
| | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] | |||||
* | Sessions should not be created until written to and session data should be ↵ | Michael Lovitt | 2010-06-23 | 1 | -0/+2 | |
| | | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Fix controller_name for non default controller paths [#4901 state:resolved] | knapo | 2010-06-23 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add support for specifying locals in view tests with assert template [#4927 ↵ | David Chelimsky | 2010-06-22 | 1 | -3/+13 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 4 | -10/+22 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | |||||
| * | Make polymorphic_url and scaffolding work with uncountable resources [#3930 ↵ | Andrew White | 2010-06-20 | 2 | -4/+13 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Remove a relic of #request being in RackDelegation | wycats | 2010-06-19 | 2 | -6/+9 | |
| | | ||||||
* | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 2 | -3/+3 | |
|\ \ | |/ |/| | ||||||
| * | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 2 | -3/+3 | |
| | | ||||||
* | | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 | |
|/ | | | | not "ActiveRecord" | |||||
* | class_attribute is not a direct replacement of class_inheritable_*. | José Valim | 2010-06-10 | 1 | -3/+3 | |
| | | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance. | |||||
* | cache_sweeper yields blank output | Neeraj Singh | 2010-06-08 | 1 | -0/+1 | |
| | | | | | | [#3914 state:open] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | regular expressions are usually ASCII-encoded, so force_encoding the content ↵ | wycats | 2010-06-07 | 1 | -0/+1 | |
| | | | | of a Node to the encoding of the regular expression is wrong. | |||||
* | Make named helpers unprotected without becoming actions [#4696 state:resolved] | wycats | 2010-06-07 | 1 | -0/+8 | |
| | ||||||
* | Reset request.parameters after assigning params for functional tests | Jeremy Kemper | 2010-06-06 | 1 | -2/+4 | |
| | ||||||
* | Memoizing methods on request means we need to clear them out on recycle! | wycats | 2010-06-04 | 1 | -3/+3 | |
| | ||||||
* | Add an asset_host accessor for consistency. | José Valim | 2010-06-02 | 1 | -2/+1 | |
| | ||||||
* | Extract assets paths and make them available to Action Mailer as well | David Heinemeier Hansson | 2010-06-02 | 1 | -1/+2 | |
| | ||||||
* | Changes made while working on upgrading cells to Rails 3 | wycats | 2010-06-02 | 2 | -4/+5 | |
| | ||||||
* | Add :only and :except to controllers MiddlewareStack. This allows | José Valim | 2010-05-30 | 1 | -3/+45 | |
| | | | | | | | | you to do the following: class PostsController < ApplicationController use AutheMiddleware, :except => [:index, :show] end | |||||
* | Fix a bug where responders were not working properly on method override. | José Valim | 2010-05-24 | 1 | -1/+1 | |
| | ||||||
* | Ruby 1.9: helper path may be a pathname, so convert to a string before ↵ | Jeremy Kemper | 2010-05-16 | 1 | -1/+1 | |
| | | | | quoting for regexp | |||||
* | Eliminate false positives when passing symbols to assert_template | David Chelimsky | 2010-05-03 | 1 | -1/+2 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Change event namespace ordering to most-significant first [#4504 state:resolved] | Justin George | 2010-05-02 | 4 | -11/+11 | |
| | | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | add HTTP Token Authorization support to complement Basic and Digest ↵ | rick | 2010-04-30 | 2 | -0/+159 | |
| | | | | Authorization. | |||||
* | ActionCachingTestController rescues from all exceptions. Making sure that ↵ | Neeraj Singh | 2010-04-29 | 1 | -1/+1 | |
| | | | | | | all the tests check for valid response. [#4468 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | extract ActionController::TestCase::Behavior | David Chelimsky | 2010-04-26 | 1 | -126/+133 | |
| | | | | | | | | | | - this makes it possible for other test frameworks to hook into testing facilities provided by Rails without having to subclass AC::TestCase. [#4474 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | allow unsubscribe by name or subscription [#4433 state:resolved] | David Chelimsky | 2010-04-24 | 1 | -0/+1 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Always downstream given options in :json, :xml and :js renderers and add ↵ | José Valim | 2010-04-22 | 1 | -2/+2 | |
| | | | | tests for it. | |||||
* | Clean up the config object in ActionPack. Create config_accessor which just ↵ | José Valim | 2010-04-22 | 8 | -165/+93 | |
| | | | | delegates to the config object, reducing the number of deprecations and add specific tests. | |||||
* | It should be possible to render :json with options | wycats | 2010-04-20 | 1 | -1/+1 | |
| |