|  | Commit message (Collapse) | Author | Age | Files | Lines | 
|---|
| | 
| 
| 
| | provided. | 
| | |  | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| | 1) Failure:
    test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]:
    Expected: "image/png"
      Actual: "image/png; charset=utf-8" | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| | Adding a test for the equal trun bug
Adding a test for the after equal trunc bug
Adding a test for the slash bug
Adding a test for the slash quote bug
Adding a helper method for creating a sample request object with token
Writing a method to create params array from raw params
Writing a method to rewrite param values in the params
Writing a method to get the token params from an authorization value
Refactoring the token_and_options method to fix bugs
Removing unnessecary test
A constant for this shared regex seemed appropriate
Wanting to split up this logic
Adding small documentation pieces | 
| | 
| 
| 
| 
| | I was trying to use those files without Rails and that require was
missing. | 
| | 
| 
| 
| 
| | This is apparently used by the railtie to setup the app helpers paths
correctly between initializers. I'll need to check it further. | 
| | 
| 
| 
| 
| 
| 
| 
| | * Avoid calling class_eval when not needed
* Remove helpers_path attr accessor, it's defined as a class attribute a
  few lines later
* Avoid creating extra arrays when finding helpers, use flat_map and sort!
* Remove not required refer variable when redirecting :back | 
| | |  | 
| | |  | 
| | |  | 
| |\ |  | 
| | | |  | 
| |/  
|   
|   
|   
|   
|   
|   
|   
|   
| | Sometimes, on Mac OS X, programmers accidentally press Option+Space
rather than just Space and don’t see the difference. The problem is
that Option+Space writes a non-breaking space (0XA0) rather than a
normal space (0x20).
This commit removes all the non-breaking spaces inadvertently
introduced in the comments of the code. | 
| | |  | 
| | |  | 
| | 
| 
| 
| | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3. | 
| | |  | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| 
| | They was extracted from a plugin.
See https://github.com/rails/rails-observers
[Rafael Mendonça França + Steve Klabnik] | 
| | 
| 
| 
| 
| | It's only possible to inherit from ActiveRecord::Base and not include
it. | 
| | 
| 
| 
| 
| 
| 
| 
| 
| | This file was using mime_types before load the Mime::Type class.
When trying to register first Mime::Type it load mime_type that loads
mime_types in the end.
Requiring mime_type ensure that we have the class definition and the
mime types | 
| | |  | 
| | |  | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| 
| | For instance, it prevents false positive in this case:
    file = nil
    get :index
    assert_template("#{file}") | 
| |\  
| | 
| | | Store FlashHashes in the session as plain hashes | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | | with unstable class names and instance variables.
Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value.
Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation.
Remove blank lines I introduced in controller/test_case.rb.
Unit tests for FlashHash#to_session_value.
Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+.
Test that Rails 3.2 session flashes are correctly converted to the new format.
Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys. | 
| |\ \  
| | | 
| | | | Encrypted cookies | 
| | | | |  | 
| | | | |  | 
| | |/ |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | |  | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| | | This reverts commit 36376560fdd02f955ae3bf6b7792b784443660ad, reversing
changes made to 3148ed9a4bb7efef30b846dc945d73ceebcc3f0f.
Conflicts:
	actionpack/lib/action_dispatch/middleware/flash.rb
Reason: it broke Sam's CI
https://github.com/rails/rails/pull/8017#issuecomment-10210655 | 
| |\ \  
| | | 
| | | | Store FlashHashes in the session as plain hashes | 
| | |/  
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| | | with unstable class names and instance variables.
Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value.
Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation.
Remove blank lines I introduced in controller/test_case.rb.
Unit tests for FlashHash#to_session_value.
Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+.
Test that Rails 3.2 session flashes are correctly converted to the new format.
Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. | 
| | | |  | 
| |/  
|   
|   
|   
| | There is no need to expose this accessor since we already have the query
method #permitted? that should handle this purpose. | 
| |\  
| | 
| | 
| | 
| | 
| | 
| | | Conflicts:
	actionpack/lib/action_controller/metal/mime_responds.rb
	activerecord/lib/active_record/attribute_methods.rb
	guides/source/working_with_javascript_in_rails.md | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | | This reverts commit cd17ee5598411728747011566abf6779166be9d3.
Reason: Let's note that this is discouraged, not remove the docs
[ci skip] |