aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller
Commit message (Collapse)AuthorAgeFilesLines
* Fix regex used to find URI schemes in redirect_toDerek Prior2013-09-191-1/+1
| | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC.
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-19/+20
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* NullSessionHash#destroy should be a no-opJonathan Baudanza2013-09-181-0/+3
| | | | Previously it was raising a NilException
* Removing ActiveSupport::Concern, it's not neededAttila Domokos2013-09-131-2/+0
|
* Fixing comment typo in ActionController::BaseAttila Domokos2013-09-131-1/+1
|
* Custom flash should be defined only for the class that defines it and it's ↵Ricardo de Cillo2013-09-131-1/+1
| | | | subclasses.
* Merge pull request #12159 from nashby/issue-12149Rafael Mendonça França2013-09-121-1/+1
|\ | | | | do not break params filtering on nil values
| * do not break params filtering on nil valuesVasiliy Ermolovich2013-09-071-1/+1
| | | | | | | | closes #12149
* | Remove remaining coupling with AV in MimeRespondsJosé Valim2013-09-092-5/+6
| |
* | Remove BasicRendering and remove template functionality from AbsC::RenderingJosé Valim2013-09-092-4/+7
|/
* Do not use instance variables if they are not reused elsewhereCarlos Antonio da Silva2013-09-061-2/+1
|
* render_to_string shouldn't play with response_bodySantiago Pastorino2013-09-041-4/+5
|
* Fix a few typos. [ci skip]namusyaka2013-09-041-1/+1
|
* Move BasicRendering to AbstractControllerŁukasz Strzałkowski2013-09-032-29/+1
|
* Make Mime::TEXT default format in AbstractControllerŁukasz Strzałkowski2013-09-031-4/+0
|
* Revert "Port all remaining self.protected_instance_variables to class methods"Łukasz Strzałkowski2013-09-021-6/+5
| | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01.
* Stop messing up with instance variables, use protected as it was meant forCarlos Antonio da Silva2013-08-301-2/+7
|
* Port all remaining self.protected_instance_variables to class methodsŁukasz Strzałkowski2013-08-291-5/+6
|
* Fix formatting of error messageŁukasz Strzałkowski2013-08-251-2/+1
| | | | Make it oneliner
* Change description of BasicRendering#renderŁukasz Strzałkowski2013-08-251-1/+1
| | | | | | We're not dealing with templates here [ci skip]
* Simplify if statementsŁukasz Strzałkowski2013-08-251-6/+4
|
* Describe BasicRendering shortlyŁukasz Strzałkowski2013-08-251-0/+4
| | | | [ci skip]
* Extend basic rendering, test it in railtiesŁukasz Strzałkowski2013-08-251-3/+16
|
* Fist stab on basic renderingŁukasz Strzałkowski2013-08-252-0/+19
|
* Do not include action_view/layoutsŁukasz Strzałkowski2013-08-251-1/+0
| | | | We don't need them. They'll be loaded automaticly if AV will be included
* Add #rendered_format method to controllersŁukasz Strzałkowski2013-08-251-4/+4
|
* Do not load AV inside APŁukasz Strzałkowski2013-08-251-1/+0
| | | | Move that part to AV railtie
* Revert "Move setting content_type to AV"Łukasz Strzałkowski2013-08-251-0/+1
| | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc.
* Change documentation of metal anonymous classŁukasz Strzałkowski2013-08-251-5/+10
| | | | | | Make it clearer [ci skip]
* Move setting content_type to AVŁukasz Strzałkowski2013-08-251-1/+0
|
* Indent protected methodsŁukasz Strzałkowski2013-08-251-18/+18
| | | | [ci skip]
* Load AV::Layouts dynamicly via railtiesŁukasz Strzałkowski2013-08-252-3/+0
|
* Code formatting & typo fixesŁukasz Strzałkowski2013-08-251-1/+1
|
* Move anonymous class to the top, add documentationŁukasz Strzałkowski2013-08-251-4/+9
|
* Create AbstractController::Rendering interfaceŁukasz Strzałkowski2013-08-251-1/+5
| | | | This interface should be use when implementing renderers.
* Fix AP test suite after moving stuff to AVŁukasz Strzałkowski2013-08-251-0/+1
|
* Hook up AV::Rendering on AV intializationŁukasz Strzałkowski2013-08-251-2/+0
|
* Move layouts to AVŁukasz Strzałkowski2013-08-251-1/+1
|
* Move rendering from AP to AVŁukasz Strzałkowski2013-08-252-2/+2
|
* Merge pull request #11443 from wangjohn/sse_reloader_classSantiago Pastorino2013-08-191-0/+74
|\ | | | | SSE class for ActionController::Live
| * Creating an SSE class to be used with ActionController::Live.wangjohn2013-07-301-0/+74
| |
* | Fail informatively in #respond_with when no appropriate #api_behavior ↵Ben Woosley2013-08-172-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-08-171-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md
| * | Revert "Merge branch 'master' of github.com:rails/docrails"Vijay Dev2013-08-171-1/+1
| |/ | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake.
* | Added data for permit array into scalar valueRahul P. Chaudhari2013-08-051-0/+1
| |
* | fix a gramatical mistakeRajeev N Bharshetty2013-08-021-1/+1
| |
* | Improve documentation for controller how to get included helpers [ci skip]Paul Nikitochkin2013-07-301-1/+1
|/ | | | Closes #11671
* Typo fixAnkit Gupta2013-07-251-1/+1
| | | | | [skip ci] Fixing the typo which is formed a not required link. Check here http://api.rubyonrails.org/classes/ActionController/Base.html under paramters section keeping it under tt tag
* Removed random dot in code sample [ci skip]Max Vasiliev2013-07-221-1/+1
|
* Add documentation for add_flash_types [ci skip]Robin Dupret2013-07-101-0/+17
| | | | | Document a little bit the ActionController::Flash::add_flash_types class method.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 09:59:17 +0000