Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | More perf work: | Yehuda Katz | 2009-08-11 | 2 | -2/+1 |
| | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare! | ||||
* | Got overhead down from 127 to 85. All tests pass: | Yehuda Katz | 2009-08-11 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve case but does handle converting Arrays to Strings in to_hash. This requires further discussion. * Moved default_charset to ActionDispatch::Response to avoid having to hop over to ActionController. Ideally, this would be a constant on AD::Response, but some tests expect to be able to change it dynamically and I didn't want to change them yet. * Completely override #initialize from Rack::Response. Previously, it was creating a HeaderHash, and then we were creating an entirely new one. There is no way to call super without incurring the overhead of creating a HeaderHash. * Override #write from Rack::Response. Its implementation tracks Content-Length, and doing so adds additional overhead that could be mooted if other middleware changes the body. It is more efficiently done at the top-level server. * Change sending_file to an instance_variable instead of header inspection. In general, if a state is important, it should be set as a property of the response not reconstructed later. * Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles Arrays fine, and it's more efficient to let it handle the body parts, since it is not forced to create a joined String. * If we detect the default cache control case, just set it, rather than setting the constituent parts and then running the normal (expensive) code to generate the string. | ||||
* | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 1 | -1/+1 |
| | | | | * Significantly simplifies setting and modifying cache control in other areas | ||||
* | Merge docrails | Pratik Naik | 2009-07-25 | 1 | -2/+2 |
| | |||||
* | Add some missing dependencies | Yehuda Katz | 2009-07-15 | 1 | -0/+1 |
| | |||||
* | Missed file from the previous commit 92b229e1251d7d3578c3f73e8185972354e76436 | Pratik Naik | 2009-06-25 | 1 | -0/+15 |
| | |||||
* | Make performance tests work again | Pratik Naik | 2009-06-25 | 1 | -15/+0 |
| | |||||
* | Merge process2 into process to people's regular tests run :P | Yehuda Katz + Carl Lerche | 2009-06-16 | 3 | -115/+12 |
| | |||||
* | Finish making things pass with updated internal content_type semantics | Yehuda Katz + Carl Lerche | 2009-06-15 | 1 | -0/+2 |
| | |||||
* | uses Object#metaclass and Object#class_eval in a few spots | Xavier Noria | 2009-06-12 | 1 | -1/+2 |
| | | | | | | [#2797 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -1/+1 |
| | | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern. | ||||
* | Get controller/test_test.rb to pass on new base | Carl Lerche | 2009-05-26 | 1 | -1/+2 |
| | |||||
* | Make assertion tests pass with the new base | Pratik Naik | 2009-05-22 | 1 | -0/+1 |
| | |||||
* | Remove some response content type concepts from ActionView | Yehuda Katz + Carl Lerche | 2009-05-21 | 1 | -0/+1 |
| | |||||
* | Add Streaming to new base | Pratik Naik | 2009-05-21 | 1 | -0/+1 |
| | |||||
* | Made ActionController::Verification work with new_base | Pratik Naik | 2009-05-21 | 1 | -1/+1 |
| | |||||
* | Added responds_to to new base. | Yehuda Katz + Carl Lerche | 2009-05-20 | 1 | -0/+1 |
| | |||||
* | Temporarily bundle rack-test while MockSession is baking | Joshua Peek | 2009-05-19 | 1 | -1/+2 |
| | |||||
* | Refactor ActionController instantiation capture | Bryan Helmkamp | 2009-05-19 | 1 | -14/+10 |
| | |||||
* | Integrating Rack::MockSession (from Rack::Test) | Bryan Helmkamp | 2009-05-19 | 1 | -12/+13 |
| | |||||
* | Change integration test helpers to accept Rack environment instead of just ↵ | Pratik Naik | 2009-05-19 | 1 | -6/+4 |
| | | | | | | | HTTP Headers. Before : get '/path', {}, 'Accept' => 'text/javascript' After : get '/path', {}, 'HTTP_ACCEPT' => 'text/javascript' | ||||
* | Rescue hack was supposed to be removed. Some how it crept back in. | Joshua Peek | 2009-05-17 | 1 | -3/+0 |
| | |||||
* | Cherry-pick core extensions | Jeremy Kemper | 2009-05-13 | 1 | -0/+1 |
| | |||||
* | Implemented redirects and partial rendering in new base. | Yehuda Katz + Carl Lerche | 2009-05-12 | 2 | -4/+7 |
| | |||||
* | Merge branch 'master' into wip_abstract_controller | Yehuda Katz + Carl Lerche | 2009-05-11 | 2 | -22/+30 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb | ||||
| * | Switch functional tests to run through the rack interface instead of process | Joshua Peek | 2009-05-02 | 1 | -2/+11 |
| | | |||||
| * | Functional test runner finalizes response just like the integration test ↵ | Joshua Peek | 2009-05-02 | 1 | -1/+4 |
| | | | | | | | | | | runner. In both runners, the @response object will now behave the same. Some functional tests will need to be updated if they are relying on preprocessed data on the response. | ||||
| * | Deprecate assert_redirect_to's partial hash matching | Joshua Peek | 2009-05-02 | 1 | -9/+9 |
| | | |||||
* | | Aliased AbstractController::ActionNotFound to ActionController::UnknownAction | Yehuda Katz + Carl Lerche | 2009-05-11 | 1 | -0/+1 |
| | | |||||
* | | Implement FooController.action(:name) | Yehuda Katz | 2009-05-02 | 1 | -0/+4 |
| | | | | | | | | | | | | * Rails actions are now Rack endpoints, and can be retrieved via FooController.action(name) and called with an env * Updated some tests that relied on the old internal #process/#call implementation | ||||
* | | Get render :inline working | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -1/+1 |
| | | |||||
* | | A few more tweaks to get new Base running old render tests again | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -2/+2 |
| | | |||||
* | | Starting to get new_base to run on old tests | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+68 |
|/ | |||||
* | alias method chain process with test | Joshua Peek | 2009-04-30 | 1 | -3/+6 |
| | |||||
* | Move TestRequest#query_parameters into AD TestRequest | Joshua Peek | 2009-04-30 | 1 | -12/+2 |
| | |||||
* | Set rack.input instead of RAW_POST_DATA in TestRequest | Joshua Peek | 2009-04-30 | 1 | -28/+11 |
| | |||||
* | Missed stray @request_uri | Joshua Peek | 2009-04-30 | 1 | -2/+0 |
| | |||||
* | Move TestRequest cookies accessor into AD TestRequest | Joshua Peek | 2009-04-30 | 1 | -2/+0 |
| | |||||
* | Start moving TestRequest and TestResponse into ActionDispatch | Joshua Peek | 2009-04-30 | 2 | -164/+17 |
| | |||||
* | Vendor new Rack::Mock changes | Joshua Peek | 2009-04-30 | 2 | -2/+2 |
| | |||||
* | Group integration test helpers and delegate other helpers to request and ↵ | Joshua Peek | 2009-04-30 | 1 | -147/+126 |
| | | | | response objects | ||||
* | Switch to action_dispatch rack namespace | Joshua Peek | 2009-04-30 | 1 | -1/+1 |
| | |||||
* | Move generic assertions into ActionDispatch | Joshua Peek | 2009-04-30 | 8 | -1114/+2 |
| | |||||
* | Test::Unit work arounds are handled by ActiveSupport | Joshua Peek | 2009-04-30 | 1 | -49/+0 |
| | |||||
* | Framework backtrace cleaning is handled by ActiveSupport now | Joshua Peek | 2009-04-30 | 6 | -113/+85 |
| | |||||
* | Deprecate template, session, assigns, and layout accessors on response ↵ | Joshua Peek | 2009-04-28 | 2 | -10/+13 |
| | | | | object. Instead access them through the controller instance. This mainly affects functional test assertions. | ||||
* | Move header injection back into integration tests | Joshua Peek | 2009-04-28 | 1 | -1/+6 |
| | |||||
* | Fix validate_request method name | Joshua Peek | 2009-04-28 | 1 | -4/+4 |
| | |||||
* | Refactor ActionView::Template | Yehuda Katz + Carl Lerche | 2009-04-27 | 1 | -5/+5 |
| | | | | | | | | ActionView::Template is now completely independent from template storage, which allows different back ends such as the database. ActionView::Template's only responsibility is to take in the template source (passed in from ActionView::Path), compile it, and render it. | ||||
* | Delegate controller.session to request.session and deprecate response session | Joshua Peek | 2009-04-27 | 1 | -1/+1 |
| |