aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/test_case.rb
Commit message (Collapse)AuthorAgeFilesLines
* Revert "fix the Flash middleware loading the session on every request (very ↵Rafael Mendonça França2012-06-051-0/+1
| | | | | | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called" This reverts commits e3069c64b2c5ddc7a5789b55b8efd4902d9e9729 and 2b2983d76fd11efc219273036a612f47cfaa5bfa. Reason: This add a non-backward compatible change in the way that flash works now (swept in every request).
* fix the Flash middleware loading the session on every request (very ↵Will Bryant2012-04-301-1/+0
| | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called
* Don't convert params if the request isn't HTML - fixes #5341Andrew White2012-04-291-6/+18
| | | | | | | | (cherry picked from commit 7a80b69e00f68e673c6ceb5cc684aa9196ed3d9f) Conflicts: actionpack/test/controller/test_test.rb
* We dont need to merge in the parameters as thats all being reset by the rack ↵David Heinemeier Hansson2012-03-201-1/+0
| | | | headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
* Remove ActionController::TestCase#rescue_action_in_public!Piotr Sarnacki2012-03-151-5/+0
| | | | | | This method has no effect since exception handling was moved to middlewares and ActionController tests do not use any middlewares.
* escape assigns[:person], assigns[person] etc in actioncontroller testcaseNick Howard2011-12-141-3/+3
|
* Fix bug in assert_template when using only `:layout` optionPrem Sichanugrist2011-12-061-13/+15
| | | | | | | | | | Currently if you're do this: assert_template :layout => "foo" Regardless of what layout you were using, the test will always pass. This was broken since the introduction of :layout option in [d9375f3f]. We have a lot of test cases in actionpack/test/controller/layout_test.rb that use this feature. This will make sure that those test cases are not true negative.
* Merge pull request #3193 from avakhov/patch-ac-test-case-safe-constantizeJosé Valim2011-10-031-3/+1
|\ | | | | use safe_constantize instead constantize in AC::TestCase
| * use safe_constantize instead constantize in AC::TestCaseAlexey Vakhov2011-10-031-3/+1
| |
* | normalize arg for AC::TestCase tests class methodAlexey Vakhov2011-10-031-2/+14
|/
* if ... nil? is more expensive than unlessMilan Dobrota2011-09-041-3/+3
|
* Make ActionController::TestCase#recycle! set @protocol to nilDavid Majda2011-08-231-1/+1
| | | | | | | | | | This ensures that the protocol does not get carried over when there are two or more requests in functional tests. This was a problem when e.g. the first request was HTTP and the second request was HTTPS. Closes #2654. Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* Don't modify params in place - fixes #2624Andrew White2011-08-231-5/+3
|
* Fix the issue where default_url_options is being cached on test cases. ↵thoefer2011-08-011-0/+1
| | | | | | Closes #1872. Closes #2031. Signed-off-by: José Valim <jose.valim@gmail.com>
* Call super here to allow SessionHash initialize new stuff for usSantiago Pastorino2011-06-191-1/+1
|
* Add backward compatibility for testing cookiesAndrew White2011-06-051-1/+8
| | | | | | | | | | | | | | | | | | | This commit restores the ability to assign cookies for testing via @request.env['HTTP_COOKIE'] and @request.cookies, e.g: @request.env['HTTP_COOKIE'] = 'user_name=david' get :index assert_equal 'david', cookies[:user_name] and @request.cookies[:user_name] = 'david' get :index assert_equal 'david', cookies[:user_name] Assigning via cookies[] is the preferred method and will take precedence over the other two methods. This is so that cookies set in controller actions have precedence and are carried over between calls to get, post, etc.
* Refactor ActionController::TestCase cookiesAndrew White2011-06-041-13/+8
| | | | | | | | | | | | | | | | | | Assigning cookies for test cases should now use cookies[], e.g: cookies[:email] = 'user@example.com' get :index assert_equal 'user@example.com', cookies[:email] To clear the cookies, use clear, e.g: cookies.clear get :index assert_nil cookies[:email] We now no longer write out HTTP_COOKIE and the cookie jar is persistent between requests so if you need to manipulate the environment for your test you need to do it before the cookie jar is created.
* Merge pull request #1203 from dchelimsky/stringify-parameter-values-in-testsJosé Valim2011-05-281-0/+19
|\ | | | | Stringify param values in controller tests.
| * use to_param (and change method to name accordingly)David Chelimsky2011-05-221-8/+8
| | | | | | | | | | - exclude Rack::Test::UploadedFile to pass existing tests. Are there any other types we're missing?
| * Stringify param values in controller tests.David Chelimsky2011-05-221-0/+19
| | | | | | | | | | | | | | | | This reduces false positives that come from using ints in params in tests, which do not get converted to strings in the tests. In implementations going through rack, they do get converted to strings. - David Chelimsky and Sam Umbach
* | Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵Jon Leighton2011-05-231-1/+1
|/ | | | and require 'securerandom' from the stdlib when active support is required.
* Use anonymous? that works on both Ruby 1.8 and 1.9.José Valim2011-05-171-3/+4
|
* add more robust test for wrapping params with anonymous classDavid Chelimsky2011-05-171-1/+5
|
* prevent errors when passing a frozen string as a param to ↵misfo2011-04-281-1/+3
| | | | | | | ActionController::TestCase#process since ActionDispatch::Http::Parameters#encode_params will force encoding on all params strings (when using an encoding aware Ruby), dup all strings passed into process. This prevents modification of params passed in and, more importantly, doesn't barf when a frozen string is passed thanks and high fives to kinsteronline
* Improve testing of cookies in functional tests:Andrew White2011-03-061-1/+10
| | | | | | | | | - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear [#6272 state:resolved]
* class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-201-2/+4
| | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* Move @assigns from the controller to the test itselfSantiago Pastorino2010-11-061-0/+1
|
* Fix problems trying to functional test AC::Metal controllersSantiago Pastorino2010-11-061-2/+2
| | | | [#5393 state:committed]
* Reset assert_template instance variables between requests [#5832 state:resolved]Andrew White2010-10-181-0/+7
|
* Solve some warnings and a failing test.José Valim2010-10-031-0/+1
|
* Rely on Rack::Session stores API for more compatibility across the Ruby world.José Valim2010-10-031-3/+5
|
* no need of nil checkNeeraj Singh2010-09-301-1/+1
|
* Remove more warnings: no need to define attr_accessor if already exists. ↵Emilio Tagua2010-09-281-3/+5
| | | | Initialize ivar.
* Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-271-4/+0
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Avoid uninitialized variable warning.Emilio Tagua2010-09-271-1/+1
|
* Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-271-1/+5
|
* Remove deprecated stuff in ActionControllerCarlos Antonio da Silva2010-09-261-1/+1
| | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController.
* escape constant namesJoost Baaij2010-08-261-4/+4
|
* Reset symbolized path parameters when a test request is recycled [#5437 ↵Andrew White2010-08-241-0/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-1/+1
| | | | 's/[ \t]*$//' -i {} \;)
* Change returning with tapSantiago Pastorino2010-07-251-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Sessions should not be created until written to and session data should be ↵Michael Lovitt2010-06-231-0/+2
| | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Add support for specifying locals in view tests with assert template [#4927 ↵David Chelimsky2010-06-221-3/+13
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-111-2/+2
|
* Reset request.parameters after assigning params for functional testsJeremy Kemper2010-06-061-2/+4
|
* Memoizing methods on request means we need to clear them out on recycle!wycats2010-06-041-3/+3
|
* Eliminate false positives when passing symbols to assert_templateDavid Chelimsky2010-05-031-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Change event namespace ordering to most-significant first [#4504 state:resolved]Justin George2010-05-021-4/+4
| | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com>
* extract ActionController::TestCase::BehaviorDavid Chelimsky2010-04-261-126/+133
| | | | | | | | | | - this makes it possible for other test frameworks to hook into testing facilities provided by Rails without having to subclass AC::TestCase. [#4474 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* allow unsubscribe by name or subscription [#4433 state:resolved]David Chelimsky2010-04-241-0/+1
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 13:55:31 +0000