Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Remove unused code. | Guo Xiang Tan | 2015-05-29 | 1 | -2/+0 | |
| | | | | Code was moved into the `assign` method. | |||||
* | Merge pull request #19808 from byroot/action-parameter | Rafael Mendonça França | 2015-05-27 | 1 | -15/+12 | |
|\ | | | | | [PoC] Stop shadowing parameters named `action` | |||||
| * | Allow to parameters named `action` or `controller` from AC::TestCase helpers | Jean Boussier | 2015-04-18 | 1 | -15/+12 | |
| | | ||||||
* | | Move `TemplateAssertions` to their own file | eileencodes | 2015-05-09 | 1 | -188/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | This moves `TemplateAssertions` out of the `test_case.rb` file and into it's own `template_assertions` file. It still inherits from `ActionController`.` This is in preparation for combining the code for Integration tests and Controller tests. This will need to be it's own file to be added to the `requires` for Integration tests. This does not currently change ANY behavior, just moving it for access later on. | |||||
* | | Use `args` instead of `*args` in `kwargs_request?` method | eileencodes | 2015-05-02 | 1 | -3/+3 | |
|/ | | | | | | `*args` is not required here and should be avoided when not necessary because `*args` are slower than `args` and create unnecessary array allocations. | |||||
* | Revert "Merge pull request #19682 from ↵ | Santiago Pastorino | 2015-04-12 | 1 | -5/+2 | |
| | | | | | | | supercaracal/fix_force_ssl_redirection_flash_error" This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3. | |||||
* | fix fails to force_ssl_redirection if session_store is disabled | Taishi Kasuga | 2015-04-09 | 1 | -2/+5 | |
| | ||||||
* | Use request.session.id instead of request.session_options[:id] | Brian John | 2015-03-12 | 1 | -1/+1 | |
| | | | | | | | | | As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6 | |||||
* | Merge pull request #18771 from kirs/deprecate-xhr | Rafael Mendonça França | 2015-02-05 | 1 | -3/+18 | |
|\ | | | | | Migrating xhr methods to keyword arguments syntax | |||||
| * | Migrating xhr methods to keyword arguments syntax | Kir Shatrov | 2015-02-01 | 1 | -3/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | in `ActionController::TestCase` and `ActionDispatch::Integration` Old syntax: `xhr :get, :create, params: { id: 1 }` New syntax example: `get :create, params: { id: 1 }, xhr: true` | |||||
* | | Merge pull request #18721 from sj26/pre-discard-flash | Aaron Patterson | 2015-02-01 | 1 | -0/+2 | |
|\ \ | | | | | | | Pre-discard flash messages | |||||
| * | | Fix flash remaining after last flash deleted | Samuel Cochran | 2015-01-29 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | Inside a controller functional test after the last flash is deleted it still persists the flash because to_session_value is nil. We should delete it from the session when the serialized version is nil, same as the flash middleware. | |||||
* | | | Fix a typo in deprecation warning. #process takes method instead of http_method. | Juanito Fatas | 2015-01-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | [ci skip] Document format parameter of process method in AC test_case. | Juanito Fatas | 2015-01-31 | 1 | -0/+1 | |
| |/ |/| | ||||||
* | | Use fixed fonts only in the name of the parameter | Rafael Mendonça França | 2015-01-29 | 1 | -8/+8 | |
| | | ||||||
* | | Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration | Kir Shatrov | 2015-01-29 | 1 | -28/+93 | |
|/ | | | | | | | | Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same | |||||
* | Reset template assertions without warnings | brainopia | 2015-01-05 | 1 | -2/+4 | |
| | ||||||
* | Remove deprecated option `use_route` in controller tests | Rafael Mendonça França | 2015-01-04 | 1 | -23/+1 | |
| | ||||||
* | Integration requests should work in contexts without setup and teardown | brainopia | 2015-01-02 | 1 | -1/+2 | |
| | ||||||
* | adding that assert_template with :layout will raise ArgumentError for ↵ | Carsten Wirth | 2014-12-16 | 1 | -0/+2 | |
| | | | | unknown layout type | |||||
* | Deprecate `use_route` in controller tests | Godfrey Chan | 2014-11-23 | 1 | -1/+22 | |
| | | | | Reference #17453 | |||||
* | Make sure assert_select can assert body tag | Rafael Mendonça França | 2014-11-18 | 1 | -4/+4 | |
| | | | | | | | | | This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13. Conflicts: actionpack/lib/action_controller/test_case.rb actionview/lib/action_view/test_case.rb | |||||
* | document_root_element need to be public | Rafael Mendonça França | 2014-11-17 | 1 | -4/+4 | |
| | ||||||
* | Pass the route name explicitly | Godfrey Chan | 2014-11-10 | 1 | -1/+2 | |
| | | | | | | Follow up to 212057b9. Since that commit, we need to pass the `route_name` explicitly. This is one of the left-over cases that was not handled in that commit, which was causing `use_route` to be ignored in functional tests. | |||||
* | Parse HTML as document fragment. | Kasper Timm Hansen | 2014-09-29 | 1 | -1/+1 | |
| | | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20. | |||||
* | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-17 | 1 | -0/+9 | |
|\ | | | | | | | | | Conflicts: actionpack/CHANGELOG.md | |||||
| * | Fix assert_template for files. | Guo Xiang Tan | 2014-08-14 | 1 | -0/+9 | |
| | | | | | | | | | | The test was not failing for `assert_template file: nil` when a file has been rendered. | |||||
* | | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-12 | 1 | -43/+14 | |
|\| | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md | |||||
| * | Remove ActionController::RaiseActionExceptions. | Guo Xiang Tan | 2014-08-07 | 1 | -34/+0 | |
| | | | | | | | | | | The latest modification to the code was done in https://github.com/rails/rails/commit/5e3517ea. In Rails 3.2, `ActionController#rescue_action` was deprecated and `rescue_action_without_handler` is no longer being used. | |||||
| * | avoid testing only_path | Aaron Patterson | 2014-08-04 | 1 | -2/+1 | |
| | | | | | | | | | | we know that this call only wants the path returned, so lets call a method that returns the path. | |||||
| * | Bug fix for assert_template when opening a new session. | Guo Xiang Tan | 2014-07-25 | 1 | -5/+9 | |
| | | | | | | | | See https://github.com/rails/rails/pull/16234#commitcomment-7115670. | |||||
| * | Fix AC::TemplateAssertions instance variables not resetting. | Guo Xiang Tan | 2014-07-21 | 1 | -5/+7 | |
| | | | | | | | | Fixes https://github.com/rails/rails/issues/16119. | |||||
* | | We don't need loofah for the assertions | Rafael Mendonça França | 2014-07-15 | 1 | -1/+0 | |
| | | | | | | | | We can just use nokogiri | |||||
* | | Merge pull request #11218 from kaspth/loofah-integration | Rafael Mendonça França | 2014-07-10 | 1 | -0/+9 | |
|\ \ | |/ |/| | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md | |||||
| * | Moved html_document to ActionDispatch::Assertions. Included the ↵ | Timm | 2014-06-16 | 1 | -6/+1 | |
| | | | | | | | | Rails::Dom::Testing::Assertions there as well. | |||||
| * | Support for changes in SelectorAssertions. | Timm | 2014-06-16 | 1 | -0/+14 | |
| | | ||||||
| * | Moved ActionView::Assertions dependency from Action Pack's lib to ↵ | Timm | 2014-06-16 | 1 | -2/+0 | |
| | | | | | | | | abstract_unit.rb. | |||||
| * | Require ActionView::Assertions in ActionController test_case.rb. | Timm | 2014-06-16 | 1 | -0/+1 | |
| | | ||||||
| * | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 1 | -0/+1 | |
| | | ||||||
* | | Reduce number of subscriptions created. | Guo Xiang Tan | 2014-07-08 | 1 | -17/+13 | |
| | | ||||||
* | | Remove symbolized_path_parameters. | Guo Xiang Tan | 2014-07-02 | 1 | -1/+0 | |
| | | | | | | | | This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d. | |||||
* | | Merge pull request #15537 from tgxworld/fix_state_leak | Matthew Draper | 2014-06-20 | 1 | -1/+0 | |
|\ \ | | | | | | | Fix state leak. | |||||
| * | | Prevent state leak. | Guo Xiang Tan | 2014-06-05 | 1 | -1/+0 | |
| |/ | ||||||
* / | Set flash in test session when necessary. | Guo Xiang Tan | 2014-06-12 | 1 | -2/+5 | |
|/ | | | | `to_session_value` returns nil when empty. | |||||
* | use symbol keys for path_parameters | Aaron Patterson | 2014-05-22 | 1 | -5/+5 | |
| | ||||||
* | Fix examples indent and improve #process docs a bit [ci skip] | Carlos Antonio da Silva | 2014-05-04 | 1 | -16/+14 | |
| | ||||||
* | Document ActionController::TestCase::Behavior#process | Gaurish Sharma | 2014-05-04 | 1 | -0/+27 | |
| | | | | [ci skip] | |||||
* | Fix subscriptions not being unsubscribed. | Guo Xiang Tan | 2014-04-14 | 1 | -5/+7 | |
| | ||||||
* | update comments to reflect that options support is not available | Frederick Cheung | 2014-03-25 | 1 | -2/+2 | |
| | ||||||
* | use the body proxy to freeze headers | Aaron Patterson | 2014-03-12 | 1 | -1/+1 | |
| | | | | | | avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header |