Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | push the cookie writing stuff out of the controller | Aaron Patterson | 2012-07-03 | 1 | -0/+6 | |
| | | | | | | | | merging cookies is responsibility of the test runner | |||||
* | | extend the controller with special logic on recycle | Aaron Patterson | 2012-07-03 | 1 | -6/+3 | |
| | | | | | | | | | | | | For some reason, this special logic is only supposed to be executed on the second request. For now, we'll extend on recycle, but we should figure out why this functionality can't be run on every request | |||||
* | | push req / res setting to the test runner | Aaron Patterson | 2012-07-03 | 1 | -1/+10 | |
|/ | | | | | Try to avoid making the controller mutate itself so that we can eventually make the response async | |||||
* | Merge pull request #6805 from tim-vandecasteele/uploadedfile-paramify | Carlos Antonio da Silva | 2012-06-23 | 1 | -1/+1 | |
|\ | | | | | Don't paramify ActionDispatch::Http::UploadedFile in tests | |||||
| * | Don't paramify ActionDispatch::Http::UploadedFile in tests | Tim Vandecasteele | 2012-06-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | To test uploading a file without using fixture_file_upload, a posted ActionDispatch::Http::UploadedFile should not be paramified (just like Rack::Test::UploadedFile). (Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't share the same API, tempfile is not accessible on Rack::Test::UploadedFile as discussed in https://github.com/brynary/rack-test/issues/30) | |||||
* | | add :nodoc: to internal implementations [ci skip] | Francesco Rodriguez | 2012-06-22 | 1 | -1/+1 | |
|/ | ||||||
* | Fix incorrect assert_block -> assert conversion. Assumed too much from the ↵ | Jeremy Kemper | 2012-05-17 | 1 | -2/+2 | |
| | | | | MiniTest deprecation message. | |||||
* | MiniTest deprecated #assert_block in favor of calling #assert with a block | Jeremy Kemper | 2012-05-17 | 1 | -1/+1 | |
| | ||||||
* | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 1 | -6/+1 | |
| | ||||||
* | Improve assert_template layout checking | Alexey Vakhov | 2012-05-04 | 1 | -3/+15 | |
| | ||||||
* | Fix assert_template :layout => nil assertion | Alexey Vakhov | 2012-05-04 | 1 | -2/+5 | |
| | ||||||
* | Fix assert_template assertion with :layout option | Alexey Vakhov | 2012-05-04 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #6034 from ↵ | Piotr Sarnacki | 2012-04-30 | 1 | -1/+0 | |
|\ | | | | | | | | | willbryant/flash_must_not_load_session_on_every_request_master Fix the Flash middleware loading the session on every request | |||||
| * | fix the Flash middleware loading the session on every request (very ↵ | Will Bryant | 2012-04-28 | 1 | -1/+0 | |
| | | | | | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called | |||||
* | | Fix controller_class_name for anonymous controllers. | Michael Schuerig | 2012-04-29 | 1 | -1/+1 | |
| | | ||||||
* | | Don't convert params if the request isn't HTML - fixes #5341 | Andrew White | 2012-04-29 | 1 | -6/+18 | |
| | | ||||||
* | | Merge session arg with existing session instead of overwriting | Andrew White | 2012-04-28 | 1 | -1/+1 | |
|/ | | | | | | | | | | | | | | | | | | | | | | | This may break existing tests that are asserting the whole session contents but should not break existing tests that are asserting individual keys - e.g: class SomeControllerTest < ActionController::TestCase setup do session['user_id'] = 1 end test "some test" do get :some_action, nil, { 'another_var' => 2 } # This assertion will now fail assert_equal({ 'another_var' => 2 }, session) # This assertion will still pass assert_equal 2, session['another_var] end end Fixes #1529. | |||||
* | remove unnecessary else statement | Vasiliy Ermolovich | 2012-04-26 | 1 | -3/+3 | |
| | ||||||
* | Remove obsolete code | Alexey Vakhov | 2012-04-12 | 1 | -3/+0 | |
| | ||||||
* | We dont need to merge in the parameters as thats all being reset by the rack ↵ | David Heinemeier Hansson | 2012-03-20 | 1 | -1/+0 | |
| | | | | headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing) | |||||
* | Remove ActionController::TestCase#rescue_action_in_public! | Piotr Sarnacki | 2012-03-15 | 1 | -5/+0 | |
| | | | | | | This method has no effect since exception handling was moved to middlewares and ActionController tests do not use any middlewares. | |||||
* | assert_template matches against Regexp | Grant Hutchins | 2012-03-10 | 1 | -2/+7 | |
| | | | | | | | | | | | | | | | This allows for more strict template assertions, while maintaining backward compatibility. For example, if you use assert_template("foo/bar") and "foo/bar/baz" was rendered, the test passes. But if you use assert_template(%r{\Afoo/bar\Z}), you will catch that a different template was rendered. Also, if you passed an unsupported argument to assert_template() in the past, it would silently succeed. Now it raises an ArgumentError. | |||||
* | force response body to be read in assert_template | Sergey Nartimov | 2012-03-05 | 1 | -0/+4 | |
| | ||||||
* | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | |||||
* | Dont do underscore and camelize, only camelize is fine | Semyon Perepelitsa | 2012-01-31 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-01-11 | 1 | -0/+1 | |
|\ | ||||||
| * | Add missing end | Rafael Mendonça França | 2012-01-10 | 1 | -0/+1 | |
| | | ||||||
* | | AC:TestCase::Behavior#head only accepts parameters as second argument | Rafael Mendonça França | 2012-01-10 | 1 | -1/+1 | |
| | | ||||||
* | | Fix ActionController::TestCase::Behavior.head | Rafael Mendonça França | 2012-01-10 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #4371 from rafaelfranca/test_unit_cleanup | Aaron Patterson | 2012-01-09 | 1 | -1/+1 | |
|\ \ | | | | | | | Test unit cleanup | |||||
| * | | Whitespaces :scissors: | Rafael Mendonça França | 2012-01-06 | 1 | -1/+1 | |
| | | | ||||||
* | | | get rid of using instance_variable_names method from AS | Sergey Nartimov | 2012-01-07 | 1 | -2/+2 | |
|/ / | | | | | | | | | - instance_variables return symbols in 1.9 - there is instance_variable_defined? method | |||||
* | | register spec subclasses for people who spec | Aaron Patterson | 2012-01-06 | 1 | -0/+6 | |
| | | ||||||
* | | convert build_message to sprintf | Aaron Patterson | 2012-01-06 | 1 | -9/+5 | |
| | | ||||||
* | | test response assertions | Aaron Patterson | 2012-01-06 | 1 | -2/+0 | |
| | | ||||||
* | | use assert_includes rather than calling includes? specifically | Aaron Patterson | 2012-01-06 | 1 | -2/+2 | |
| | | ||||||
* | | Revert "remove deprecated API" | Aaron Patterson | 2012-01-05 | 1 | -0/+12 | |
| | | | | | | | | This reverts commit f53c247d10acbaacb0d61824cfce888c4b0520d2. | |||||
* | | remove deprecated API | Aaron Patterson | 2012-01-05 | 1 | -12/+0 | |
| | | ||||||
* | | fix some whitespace errors | Aaron Patterson | 2012-01-05 | 1 | -5/+5 | |
|/ | ||||||
* | allow sending documents in AC::TestCase#post and friends. | Nick Sutterer | 2012-01-03 | 1 | -17/+44 | |
| | ||||||
* | escape assigns[:person], assigns[person] etc in actioncontroller testcase | Nick Howard | 2011-12-14 | 1 | -3/+3 | |
| | ||||||
* | Fix bug in assert_template when using only `:layout` option | Prem Sichanugrist | 2011-12-06 | 1 | -13/+15 | |
| | | | | | | | | | | Currently if you're do this: assert_template :layout => "foo" Regardless of what layout you were using, the test will always pass. This was broken since the introduction of :layout option in [d9375f3f]. We have a lot of test cases in actionpack/test/controller/layout_test.rb that use this feature. This will make sure that those test cases are not true negative. | |||||
* | Merge pull request #3193 from avakhov/patch-ac-test-case-safe-constantize | José Valim | 2011-10-03 | 1 | -3/+1 | |
|\ | | | | | use safe_constantize instead constantize in AC::TestCase | |||||
| * | use safe_constantize instead constantize in AC::TestCase | Alexey Vakhov | 2011-10-03 | 1 | -3/+1 | |
| | | ||||||
* | | normalize arg for AC::TestCase tests class method | Alexey Vakhov | 2011-10-03 | 1 | -2/+14 | |
|/ | ||||||
* | if ... nil? is more expensive than unless | Milan Dobrota | 2011-09-04 | 1 | -3/+3 | |
| | ||||||
* | Make ActionController::TestCase#recycle! set @protocol to nil | David Majda | 2011-08-23 | 1 | -1/+1 | |
| | | | | | | | | | | This ensures that the protocol does not get carried over when there are two or more requests in functional tests. This was a problem when e.g. the first request was HTTP and the second request was HTTPS. Closes #2654. Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | |||||
* | Don't modify params in place - fixes #2624 | Andrew White | 2011-08-23 | 1 | -5/+3 | |
| | ||||||
* | Fix the issue where default_url_options is being cached on test cases. ↵ | thoefer | 2011-08-01 | 1 | -0/+1 | |
| | | | | | | Closes #1872. Closes #2031. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Call super here to allow SessionHash initialize new stuff for us | Santiago Pastorino | 2011-06-19 | 1 | -1/+1 | |
| |