Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reduce Hash object creation when normalizing request env | Akira Matsuda | 2019-07-31 | 1 | -2/+3 |
| | |||||
* | Reduce unnecessary String creation by not `to_s`ing until nothing matches | Akira Matsuda | 2019-07-31 | 1 | -1/+1 |
| | |||||
* | Deduplicate strings held by the router | Jean Boussier | 2019-04-03 | 1 | -1/+1 |
| | |||||
* | [ci skip] Fix typos | Shailesh Kalamkar | 2019-03-07 | 1 | -1/+1 |
| | |||||
* | Use native `Array#append`, `Array#prepend`, `Hash#transform_keys`, and ↵ | Ryuta Kamizono | 2018-12-20 | 1 | -2/+0 |
| | | | | | | | | | | `Hash#transform_keys!` Since Rails 6 requires Ruby 2.5. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS Follow up #34754. | ||||
* | Fix unclosed tags [ci skip] | yuuji.yaginuma | 2018-08-18 | 1 | -1/+1 |
| | |||||
* | Add render options in action_controller/renderer for api documentation [ci skip] | Alireza Bashiri | 2018-07-22 | 1 | -0/+15 |
| | | | | | | Complete renderer documentation Fixes #28484 | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Merge pull request #28381 from shime/docs-action-controller-base | Vipul A M | 2017-03-13 | 1 | -2/+2 |
|\ | | | | | [docs] fix ActionController docs | ||||
| * | [docs] fix ActionController documentation | Hrvoje Šimić | 2017-03-12 | 1 | -2/+2 |
| | | | | | | | | [ci skip] | ||||
* | | Fixes ActionController::Rendering#with_defaults | alpaca-tc | 2017-03-12 | 1 | -1/+1 |
|/ | | | | `env` is undefined. | ||||
* | Fix malformed asset_url when rendering template with ActionController::Renderer | Giorgos Vrettos | 2017-03-06 | 1 | -0/+1 |
| | |||||
* | fix method name in `Renderer` doc [ci skip] | yuuji.yaginuma | 2017-01-12 | 1 | -1/+2 |
| | | | | `ActionController::Renderer.defaults` was removed in 2db7304 | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | |||||
* | Allow any key in Renderer environment hash | Sammy Larbi | 2016-10-15 | 1 | -1/+3 |
| | | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering. | ||||
* | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 1 | -12/+12 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix typo in ActionController::Renderer [ci skip] | Alex Kitchens | 2016-06-10 | 1 | -1/+1 |
| | |||||
* | Merge pull request #24845 from tomkadwill/action_controller_typos | Rafael França | 2016-05-04 | 1 | -2/+2 |
|\ | | | | | Fix actionpack typos [ci skip] | ||||
| * | Fix actionpack typos [ci skip] | Tom Kadwill | 2016-05-04 | 1 | -2/+2 |
| | | |||||
* | | Fix ApplicationController.renderer.defaults.merge! | Jon Moss | 2016-04-20 | 1 | -1/+1 |
|/ | | | | | | | Previously, users were trying to modify a frozen Hash. Includes a regression test :) Fixes #22975 | ||||
* | allocate request objects with the env hash, set routes on the request | Aaron Patterson | 2015-09-15 | 1 | -2/+6 |
| | | | | | This commit is to abstract the code away from the env hash. It no longer needs to have the routes key hard coded. | ||||
* | only "normalize" once | Aaron Patterson | 2015-09-14 | 1 | -1/+1 |
| | |||||
* | create a new renderer instance on calls to `for` | Aaron Patterson | 2015-09-14 | 1 | -39/+46 |
| | | | | | | | | | | | | This changes the renderer class to store the controller and defaults as an instance variable rather than allocating a new class. You can create a new renderer with an new env by calling `Renderer#new` or use new defaults by calling `Renderer#with_defaults` and saving the return value somewhere. Also I want to keep the `env` private since I would like to change the keys in the future. This commit only translates particular keys that the user requested. | ||||
* | Speed up `normalize_keys` by removing dup step. | Kasper Timm Hansen | 2015-01-22 | 1 | -9/+6 |
| | | | | | | | | Previously env was duplicated and then had it's keys mutated. This iterates through the hash twice. Using `transform_keys`, duplication and key mutation is a single iteration. `convert_symbols` was renamed to `http_header_format`. | ||||
* | Add ActionController::Renderer | brainopia | 2015-01-22 | 1 | -0/+103 |
Render arbitrary templates outside of controller actions |