aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/metal
Commit message (Collapse)AuthorAgeFilesLines
* Add always_permitted_parameters as an option.Rafael Chacón2014-06-261-5/+21
| | | | | | | | | * This commit adds back the always_permitted_parameters configuration option to strong paramaters. * The initial pull requests where this feature was added are the following: - https://github.com/rails/rails/pull/12682 - https://github.com/rails/strong_parameters/pull/174
* Fixing repond_with working directly on the options hashBlueHotDog2013-10-091-0/+1
| | | | | | | | This fixes an issue where the respond_with worked directly with the given options hash, so that if a user relied on it after calling respond_with, the hash wouldn't be the same. Fixes #12029
* Strong parameters should permit nested number as key. Closes #12293kennyj2013-09-271-1/+5
|
* Fix regex used to find URI schemes in redirect_toDerek Prior2013-09-191-1/+1
| | | | | The previous regex was allowing `_` in the URI scheme, which is not allowed by RFC 3986. This change brings the regex in line with the RFC.
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-19/+20
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* NullSessionHash#destroy should be a no-opJonathan Baudanza2013-09-181-0/+3
| | | | Previously it was raising a NilException
* Removing ActiveSupport::Concern, it's not neededAttila Domokos2013-09-131-2/+0
|
* Custom flash should be defined only for the class that defines it and it's ↵Ricardo de Cillo2013-09-131-1/+1
| | | | subclasses.
* Merge pull request #12159 from nashby/issue-12149Rafael Mendonça França2013-09-121-1/+1
|\ | | | | do not break params filtering on nil values
| * do not break params filtering on nil valuesVasiliy Ermolovich2013-09-071-1/+1
| | | | | | | | closes #12149
* | Remove remaining coupling with AV in MimeRespondsJosé Valim2013-09-092-5/+6
| |
* | Remove BasicRendering and remove template functionality from AbsC::RenderingJosé Valim2013-09-091-2/+6
|/
* Do not use instance variables if they are not reused elsewhereCarlos Antonio da Silva2013-09-061-2/+1
|
* render_to_string shouldn't play with response_bodySantiago Pastorino2013-09-041-4/+5
|
* Fix a few typos. [ci skip]namusyaka2013-09-041-1/+1
|
* Move BasicRendering to AbstractControllerŁukasz Strzałkowski2013-09-031-28/+0
|
* Make Mime::TEXT default format in AbstractControllerŁukasz Strzałkowski2013-09-031-4/+0
|
* Stop messing up with instance variables, use protected as it was meant forCarlos Antonio da Silva2013-08-301-2/+7
|
* Fix formatting of error messageŁukasz Strzałkowski2013-08-251-2/+1
| | | | Make it oneliner
* Change description of BasicRendering#renderŁukasz Strzałkowski2013-08-251-1/+1
| | | | | | We're not dealing with templates here [ci skip]
* Simplify if statementsŁukasz Strzałkowski2013-08-251-6/+4
|
* Describe BasicRendering shortlyŁukasz Strzałkowski2013-08-251-0/+4
| | | | [ci skip]
* Extend basic rendering, test it in railtiesŁukasz Strzałkowski2013-08-251-3/+16
|
* Fist stab on basic renderingŁukasz Strzałkowski2013-08-251-0/+18
|
* Add #rendered_format method to controllersŁukasz Strzałkowski2013-08-251-4/+4
|
* Revert "Move setting content_type to AV"Łukasz Strzałkowski2013-08-251-0/+1
| | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc.
* Move setting content_type to AVŁukasz Strzałkowski2013-08-251-1/+0
|
* Indent protected methodsŁukasz Strzałkowski2013-08-251-18/+18
| | | | [ci skip]
* Load AV::Layouts dynamicly via railtiesŁukasz Strzałkowski2013-08-251-2/+0
|
* Hook up AV::Rendering on AV intializationŁukasz Strzałkowski2013-08-251-2/+0
|
* Move rendering from AP to AVŁukasz Strzałkowski2013-08-252-2/+2
|
* Merge pull request #11443 from wangjohn/sse_reloader_classSantiago Pastorino2013-08-191-0/+74
|\ | | | | SSE class for ActionController::Live
| * Creating an SSE class to be used with ActionController::Live.wangjohn2013-07-301-0/+74
| |
* | Fail informatively in #respond_with when no appropriate #api_behavior ↵Ben Woosley2013-08-172-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not.
* | Added data for permit array into scalar valueRahul P. Chaudhari2013-08-051-0/+1
| |
* | Improve documentation for controller how to get included helpers [ci skip]Paul Nikitochkin2013-07-301-1/+1
|/ | | | Closes #11671
* Add documentation for add_flash_types [ci skip]Robin Dupret2013-07-101-0/+17
| | | | | Document a little bit the ActionController::Flash::add_flash_types class method.
* Remove duplicate letter 'a'. [ci skip]Uģis Ozols2013-06-191-1/+1
|
* Add `respond_with` `location` option to the docsTute Costa2013-06-181-2/+6
|
* [ci skip] document protect_against_forgery? methodWeston Platter2013-05-101-0/+1
|
* Fix generating route from engine to other enginePiotr Sarnacki2013-05-031-1/+2
| | | | | | | | | | | | A regression was introduced in 5b3bb6, generating route from within an engine to an another engine resulted in prefixing a path with the SCRIPT_NAME value. The regression was caused by the fact that SCRIPT_NAME should be appended only if it's the SCRIPT_NAME for the application, not if it's SCRIPT_NAME from the current engine. closes #10409
* Don't reprocess the options hash on every requestAndrew White2013-04-271-1/+2
|
* Add support for extra options to `force_ssl`Andrew White2013-04-251-17/+48
| | | | | | | | This commit adds support for passing additional url options along with a :status option and any of the flash-related options to `redirect_to` (i.e. :flash, :alert & :notice). Closes #7570.
* Use `request.fullpath` to build redirect url in `force_ssl`Andrew White2013-04-251-4/+7
| | | | | | | | | | | The `force_ssl` command now builds the redirect url from `request.fullpath`. This ensures that the format is maintained and it doesn't redirect to a route that has the same parameters but is defined earlier in `routes.rb`. Also any optional segments are maintained. Fixes #7528. Fixes #9061. Fixes #10305.
* fixed missing comma in exampleIlya Vorontsov2013-04-241-1/+1
|
* Return nil for Mime::NullType#refAndrew White2013-04-101-1/+1
|
* Reverts rendering behavior when format is unknownGrzegorz Świrski2013-04-101-1/+1
| | | | | | | | | If a request has unknown format (eg. /foo.bar), the renderer fallbacks to default format. This patch reverts Rails 3.2 behavior after c2267db commit. Fixes issue #9654.
* Fix typoRafael Mendonça França2013-04-091-2/+2
|
* fix AP warning; remove unused variableVipul A M2013-04-091-0/+1
|
* Merge pull request #9604 from sgrif/live_streaming_exceptionsRafael Mendonça França2013-04-081-0/+28
|\ | | | | Exceptions raised when using ActionController::Live cause server crash