aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/metal
Commit message (Collapse)AuthorAgeFilesLines
* No need to create a new module in the previous commit.José Valim2010-07-192-14/+9
|
* Exceptions from views should be rescued based on the original exception. If ↵Neeraj Singh2010-07-191-0/+14
| | | | | | | | a handler for original exception is missing then apply ActiveView::TemplateError [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed many references to the old config/environment.rb and Rails::InitializerBenjamin Quorning2010-07-131-1/+1
|
* Fix setting helpers_path to a string or pathnameJeremy Kemper2010-07-071-2/+3
|
* Fixes for "router" and "routes" terminologyWincent Colaiuta2010-07-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit f7ba614c2db improved the internal consistency of the different means of accessing routes, but it introduced some problems at the level of code comments and user-visible strings. This commit applies fixes on three levels: Firstly, we remove or replace grammatically invalid constructs such as "a routes" or "a particular routes". Secondly, we make sure that we always use "the router DSL" or "the router syntax", because this has always been the official terminology. Finally, we make sure that we only use "routes" when referring to the application-specific set of routes that are defined in the "config/routes.rb" file, we use "router" when referring on a more abstract level to "the code in Rails used to handle routing", and we use "routing" when we need an adjective to apply to nouns such as "url_helpers. Again this is consistent with historical practice and other places in the documentation. Note that this is not a sweep over the entire codebase to ensure consistent usage of language; it is just a revision of the changes introduced in commit f7ba614c2db. Signed-off-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: José Valim <jose.valim@gmail.com>
* Unify routes naming by renaming router to routesPiotr Sarnacki2010-07-021-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use caller for helpers_dir deprecation warningsJeremy Kemper2010-06-281-2/+2
|
* Small changes to responder:José Valim2010-06-261-5/+13
| | | | | | * resources is always an array; * Lazy retrieve request and formats; * Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods.
* Merge remote branch 'rails/master'Xavier Noria2010-06-201-4/+0
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * Remove a relic of #request being in RackDelegationwycats2010-06-191-4/+0
| |
* | Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-151-1/+1
|\ \ | |/ |/|
| * Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-111-1/+1
| |
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-141-1/+1
|/ | | | not "ActiveRecord"
* class_attribute is not a direct replacement of class_inheritable_*.José Valim2010-06-101-3/+3
| | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance.
* Make named helpers unprotected without becoming actions [#4696 state:resolved]wycats2010-06-071-0/+8
|
* Changes made while working on upgrading cells to Rails 3wycats2010-06-022-4/+5
|
* Fix a bug where responders were not working properly on method override.José Valim2010-05-241-1/+1
|
* Ruby 1.9: helper path may be a pathname, so convert to a string before ↵Jeremy Kemper2010-05-161-1/+1
| | | | quoting for regexp
* Change event namespace ordering to most-significant first [#4504 state:resolved]Justin George2010-05-021-5/+5
| | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com>
* add HTTP Token Authorization support to complement Basic and Digest ↵rick2010-04-301-0/+158
| | | | Authorization.
* Always downstream given options in :json, :xml and :js renderers and add ↵José Valim2010-04-221-2/+2
| | | | tests for it.
* Clean up the config object in ActionPack. Create config_accessor which just ↵José Valim2010-04-223-78/+48
| | | | delegates to the config object, reducing the number of deprecations and add specific tests.
* It should be possible to render :json with optionswycats2010-04-201-1/+1
|
* Move verification to a plugin as well: http://github.com/rails/verification.gitJosé Valim2010-04-101-130/+0
|
* Fix a bug in ActionDispatch::Static where Rails cannot find assets if ↵José Valim2010-04-081-2/+0
| | | | started in another directory which is not the RAILS_ROOT.
* Move the error raising to api_behavior.José Valim2010-04-071-1/+2
|
* Merge commit 'rails/master'Xavier Noria2010-04-062-7/+13
|\
| * Rename config.cookie_secret to config.secret_token and pass it as ↵José Valim2010-04-052-7/+13
| | | | | | | | configuration in request.env. This is another step forward removing global configuration.
* | revises some <%= in rdocXavier Noria2010-04-051-1/+1
|/
* Fix signed cookies by explicitly passing config to the cookie jarJeremy Kemper2010-04-041-2/+3
|
* * Change the object used in routing constraints to be an instance ofwycats2010-04-032-2/+2
| | | | | | | | | | | ActionDispatch::Request rather than Rack::Request. * Changed ActionDispatch::Request#method to return a String, to be compatible with the Rack::Request superclass. * Changed ActionDispatch::Request#method to return the original method in the case of methodoverride and #request_method not to, to be compatible with Rack::Request
* Deprecate cookie_verifier_secret in favor of config.cookie_secret allowing ↵José Valim2010-03-311-1/+0
| | | | signed cookies to work again.
* adds missing requires for Object#blank? and Object#present?Xavier Noria2010-03-282-0/+2
|
* Ensure details are frozen after @details_keys lookup. The implementation ↵José Valim2010-03-271-2/+1
| | | | waits to freeze until the last required moment, to avoid duping hashes.
* Improve performance of the rendering stack by freezing formats as a sign ↵José Valim2010-03-191-0/+1
| | | | that they shouldn't be further modified.
* All tests pass without memoizing view_contextCarlhuda2010-03-181-1/+1
|
* Modify assert_template to use notifications. Also, remove ↵Carlhuda2010-03-171-9/+0
| | | | ActionController::Base#template since it is no longer needed.
* Ensure json is loaded before using responders.José Valim2010-03-171-0/+2
|
* Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM ↵wycats2010-03-171-1/+1
| | | | warnings are in dependencies.
* Eliminate warnings for AM on 1.8wycats2010-03-161-4/+2
|
* Ensure controller filters are executed before stuff starts to happen.José Valim2010-03-131-1/+1
|
* Finish cleaning up rendering stack from views and move assigns evaluation to ↵José Valim2010-03-123-11/+14
| | | | controller (so plugins and/or controllers can overwrite just one method).
* ActionController::Base.request_forgery_protection_token should actually be ↵Carl Lerche2010-03-111-1/+1
| | | | the name of the token and not true.
* Remove uneeded methods.José Valim2010-03-101-18/+4
|
* Refactor the RouteSet so it uses a Generator object instead of one huge method.wycats2010-03-091-1/+0
|
* Simplify the action endpoint:Carlhuda2010-03-081-4/+1
| | | | | | | * Remove ActionEndpoint in favor of passing a block to MiddlewareStack * Always create a Request; the performance win of RackDelegation is around the response; the Request object hit is limited to a single object allocation * #dispatch takes a Request
* Clean LookupContext API.José Valim2010-03-081-1/+2
|
* Move request forgery protection configuration to the AC config objectCarl Lerche2010-03-081-4/+41
| | | | This is an interim solution pending revisiting the rails framework configuration situation.
* Finally moved the find template logic to the views.José Valim2010-03-083-33/+21
|
* More refactoring. Split _normalize_args and _normalize_options concerns.José Valim2010-03-081-6/+13
|