Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Document 'false' as option for 'action_on_unpermitted_parameters' | Daniel Carral | 2016-11-29 | 1 | -2/+2 |
| | | | | [ci skip] | ||||
* | Fix a force ssl redirection bug that occur when session store disabled. | Taishi Kasuga | 2016-11-22 | 1 | -1/+1 |
| | |||||
* | Merge pull request #26905 from bogdanvlviv/docs | Andrew White | 2016-11-13 | 2 | -2/+2 |
|\ | | | | | Add missing `+` around a some literals. | ||||
| * | Add missing `+` around a some literals. | bogdanvlviv | 2016-10-27 | 2 | -2/+2 |
| | | | | | | | | | | | | Mainly around `nil` [ci skip] | ||||
* | | removes unconventional "then" in case expression | Xavier Noria | 2016-11-13 | 1 | -1/+1 |
| | | |||||
* | | revises style in recent code (of mine) | Xavier Noria | 2016-11-13 | 1 | -5/+7 |
| | | | | | | | | | | This alternative case expressions read better for my taste, and look more uniform in a file where other similar case expressions are used (without dynamic clauses). | ||||
* | | significant speedup of AC::Parameters#permit | Xavier Noria | 2016-11-12 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation of AC::Parameters#permit builds permitted hashes and then calls permit! on them. This filtering is recursive, so we call permit! on terminal branches, but then ascendants call permit! on themselves when the recursion goes up the stack, which recurses all the way down again because permit! is recursive itself. Repeat this for every parent node and you get some scary O-something going on that I don't even want to compute. Instead, since the whole point of the permit recursion is to build permitted hashes along the way and at that point you know you've just come up with a valid filtered version, you can already switch the toggle on the spot. I have seen 2x speedups in casual benchmarks with small structures. As the previous description shows, the difference in performance is going to be a function of the nesting. Note that that the involved methods are private and used only by permit. | ||||
* | | adds a missing dot [ci skip] | Xavier Noria | 2016-11-11 | 1 | -1/+1 |
| | | |||||
* | | adds support for arbitrary hashes in strong parameters | Xavier Noria | 2016-11-11 | 1 | -0/+45 |
| | | |||||
* | | Merge pull request #26820 from y-yagi/add_bang_merge_to_parameters | Rafael França | 2016-11-10 | 1 | -0/+7 |
|\ \ | | | | | | | add `ActionController::Parameters#merge!` | ||||
| * | | add `ActionController::Parameters#merge!` | yuuji.yaginuma | 2016-10-18 | 1 | -0/+7 |
| |/ | | | | | | | | | This method has the same behavior as `Hash#merge!`, returns current `ActionController::Parameters`. | ||||
* | | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 8 | -10/+10 |
| | | |||||
* | | remove unused `RedirectBackError` class | yuuji.yaginuma | 2016-10-27 | 1 | -8/+0 |
|/ | | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8 | ||||
* | ActionController::Parameters#deep_dup (#26567) | Pavel Evstigneev | 2016-10-11 | 1 | -0/+7 |
| | | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev] | ||||
* | Add missing @, fix indents. [ci skip] | bogdanvlviv | 2016-10-10 | 1 | -6/+6 |
| | |||||
* | Remove deprecated methods in ActionController::Parameters | Rafael Mendonça França | 2016-10-10 | 1 | -20/+0 |
| | |||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 1 | -9/+0 |
| | |||||
* | Remove deprecated support to :text in render | Rafael Mendonça França | 2016-10-10 | 1 | -12/+1 |
| | |||||
* | Remove deprecated support to :nothing in render | Rafael Mendonça França | 2016-10-09 | 1 | -5/+0 |
| | |||||
* | Remove deprecated support to `:back` in `redirect_to` | Rafael Mendonça França | 2016-10-09 | 1 | -8/+0 |
| | |||||
* | Remove deprecated support for status option in head | Rafael Mendonça França | 2016-10-09 | 1 | -7/+1 |
| | |||||
* | Remove deprecation at ActionController::BadRequest | Rafael Mendonça França | 2016-10-09 | 1 | -11/+1 |
| | |||||
* | Remove obsolete comment about class-level respond_to | Andrew White | 2016-10-01 | 1 | -2/+0 |
| | | | | | | The class-level respond_to was extracted in ee77770 to responders gem [ci skip] | ||||
* | Correct `render text:` deprecation message | Jack Bracewell | 2016-09-14 | 1 | -1/+1 |
| | | | The default Content-Type is `text/html`, not `text/plain`. | ||||
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 4 | -15/+15 |
| | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | Merge pull request #26418 from y-yagi/fixes_26415 | Richard Schneeman | 2016-09-07 | 1 | -1/+1 |
|\ | | | | | call `.to_h` to avoid using deprecated method | ||||
| * | call `.to_h` to avoid using deprecated method | yuuji.yaginuma | 2016-09-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | `ActionController::Parameters#merge` call `HashWithIndifferentAccess#merge`. In addition, it calls `HashWithIndifferentAccess#update` from `HashWithIndifferentAccess#merge`, where it is called the `#to_hash` of argument. But `ActionController::Parameters#to_hash` is deprecated, warning message is displayed. To avoid this, modify to convert object to `Hash`. Fixes #26415 | ||||
* | | Merge pull request #26016 from nateberkopec/patch-1 | Vipul A M | 2016-09-07 | 1 | -2/+3 |
|\ \ | |/ |/| | Clarify expires_now documentation | ||||
| * | Clarify expires_now documentation | Nate Berkopec | 2016-09-06 | 1 | -2/+3 |
| | | | | | | | | [ci skip] | ||||
* | | RuboCop is 100% green :tada: | Xavier Noria | 2016-09-02 | 1 | -1/+1 |
| | | |||||
* | | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 3 | -3/+3 |
| | | |||||
* | | Move to_param undef closer to the deprecations. | Kasper Timm Hansen | 2016-08-31 | 1 | -2/+4 |
| | | | | | | | | | | | | | | Makes it clearer why we're doing this Add a comment to elaborate on what the undef means and move it closer to the deprecations so it's less likely for whoever pulls the deprecations that it should go too. | ||||
* | | Do not allow to_param on AC::Parameters | Kir Shatrov | 2016-08-31 | 1 | -0/+3 |
| | | |||||
* | | Allow `send_file` to declare a charset | Jon Moss | 2016-08-29 | 1 | -0/+1 |
| | | | | | | | | | | | | Removed my patch in favor of @tenderlove's less invasive approach. [Aaron Patterson & Jon Moss] | ||||
* | | yl - remove extra … | yunlei | 2016-08-23 | 1 | -1/+1 |
| | | |||||
* | | Include the content of the flash in the auto-generated etag (#26250) | David Heinemeier Hansson | 2016-08-22 | 1 | -0/+16 |
| | | | | | | Include the content of the flash in the auto-generated etag | ||||
* | | Merge pull request #26094 from igorkasyanchuk/master | Rafael França | 2016-08-16 | 1 | -2/+2 |
|\ \ | | | | | | | Show unpermitted parameters as symbols in logs (so they could be copy… | ||||
| * | | Show unpermitted parameters as symbols in logs (so they could be copy-pasted ↵ | Igor Kasyanchuk | 2016-08-10 | 1 | -2/+2 |
| | | | | | | | | | | | | to the code) | ||||
* | | | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 5 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | | | Fix deadlock that can occur when child live thread tries to load a constant ↵ | Alex Chinn | 2016-08-15 | 1 | -1/+6 |
| | | | | | | | | | | | | after writing to the stream. | ||||
* | | | AC::Metal is already defining default encoding as UTF 8, let's reuse it. | Prathamesh Sonpatki | 2016-08-14 | 1 | -1/+1 |
| | | | |||||
* | | | Mark method as nodoc | Rafael Mendonça França | 2016-08-12 | 1 | -3/+3 |
| | | | | | | | | | | | | They are not part of the public API | ||||
* | | | [ci skip] Add documentation to Parameter Encoding | Alex Kitchens | 2016-08-11 | 1 | -0/+1 |
| | | | |||||
* | | | Allow specifying encoding of parameters by action | Kerri Miller | 2016-08-09 | 1 | -0/+29 |
|/ / | | | | | | | | | At GitHub we need to handle parameter encodings that are not UTF-8. This patch allows us to specify encodings per parameter per action. | ||||
* | | revises more Lint/EndAlignment offenses | Xavier Noria | 2016-08-08 | 1 | -1/+1 |
| | | |||||
* | | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 4 | -4/+4 |
| | | | | | | | | | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 4 | -4/+0 |
| | | |||||
* | | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 8 | -118/+118 |
| | | |||||
* | | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 6 | -24/+24 |
| | | |||||
* | | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 17 | -73/+73 |
| | | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. |