Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | push req / res setting to the test runner | Aaron Patterson | 2012-07-03 | 1 | -4/+0 | |
| | | | | | | | | | | Try to avoid making the controller mutate itself so that we can eventually make the response async | |||||
* | | extract response setting to a method | Aaron Patterson | 2012-07-03 | 1 | -2/+8 | |
| | | ||||||
* | | push response creation down since third param is never used. | Aaron Patterson | 2012-07-02 | 1 | -3/+3 | |
|/ | ||||||
* | moar copy edits [ci skip] | Vijay Dev | 2012-06-14 | 1 | -2/+1 | |
| | ||||||
* | copy editing [ci skip] | Vijay Dev | 2012-06-14 | 1 | -4/+7 | |
| | ||||||
* | fixed http token authentication formatting | Jakub Kuźma | 2012-06-12 | 1 | -8/+13 | |
| | ||||||
* | on CSRF whitelisting the argument for :if must be a symbol | Daniel Lopes | 2012-06-07 | 1 | -1/+1 | |
| | ||||||
* | fix typos on the CSRF whitelisting doc | Daniel Lopes | 2012-06-07 | 1 | -3/+3 | |
| | ||||||
* | Document the CSRF whitelisting on get requests | Daniel Lopes | 2012-06-07 | 1 | -5/+16 | |
| | ||||||
* | Extracted redirect logic from ActionController::Force::ClassMethods.force_ssl | Jeremy Friesen | 2012-05-31 | 1 | -7/+15 | |
| | | | | | | | | | | | | | Prior to this patch the existing .force_ssl method handles both defining the filter and handling the logic for performing the redirect. With this patch the logic for redirecting to the HTTPS protocol is separated from the filter logic that determines if a redirect should occur. By separating the two levels of behavior, an instance method for ActionController (i.e. #force_ssl_redirect) is exposed and available for more granular SSL enforcement. Cleaned up indentation. | |||||
* | Fix sorting of helpers from different paths | Piotr Sarnacki | 2012-05-28 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | When more than one directory for helpers is provided to a controller, it should preserver the order of directories. Given 2 paths: MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"] helpers from dir1 should be loaded first. Before this commit, all helpers were mixed and then sorted alphabetically, which essentially would require to rename helpers to get desired order. This is a problem especially for engines, where you would like to be able to predict accurately which engine helpers will load first. (closes #6496) | |||||
* | Raise ActionController::BadRequest for malformed parameter hashes. | Andrew White | 2012-05-20 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051 | |||||
* | Show in log correct wrapped keys | Dmitry Vorotilin | 2012-05-20 | 1 | -1/+2 | |
| | ||||||
* | Merge pull request #2237 from jackdempsey/log_redirect_to | Aaron Patterson | 2012-05-16 | 1 | -0/+1 | |
|\ | | | | | log at debug level what line caused the redirect_to | |||||
| * | log at debug level what line caused the redirect_to | Jack Dempsey | 2012-05-16 | 1 | -0/+1 | |
| | | ||||||
* | | Removing ==Examples and last blank lines of docs from actionpack | Francesco Rodriguez | 2012-05-15 | 7 | -19/+0 | |
| | | ||||||
* | | Move HTTP Token auth docs above the Token module | Elia Schito | 2012-05-11 | 1 | -42/+44 | |
| | | ||||||
* | | If content_type is explicitly passed to the :head method use the value or ↵ | Kunal Shah | 2012-05-08 | 1 | -1/+2 | |
| | | | | | | | | fallback | |||||
* | | remove .new from raise ActionController::UnknownFormat | Steven Soroka | 2012-05-06 | 1 | -1/+1 | |
| | | ||||||
* | | Raise a rescuable exception when Rails doesn't know what to do with the ↵ | Steven Soroka | 2012-05-06 | 2 | -2/+4 | |
| | | | | | | | | format, rather than responding with a head :not_acceptable (406) | |||||
* | | Use Hash#fetch instead of has_key? check | Carlos Antonio da Silva | 2012-05-04 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #4445 from nragaz/role_based_params_wrapping | José Valim | 2012-05-04 | 1 | -2/+3 | |
| | | | | | | | | specify a role for identifying accessible attributes when wrapping params | |||||
* | | Merge pull request #6148 from twinturbo/head-fix | José Valim | 2012-05-03 | 1 | -1/+21 | |
|\ \ | | | | | | | Make ActionController#head pass rack-link | |||||
| * | | Remove content-length as well | twinturbo | 2012-05-03 | 1 | -2/+3 | |
| | | | ||||||
| * | | Make ActionController#head pass rack-link | twinturbo | 2012-05-03 | 1 | -1/+20 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 2 | -2/+2 | |
|\ \ \ | |/ / |/| | | ||||||
| * | | Code-format references to config settings | Mark Rushakoff | 2012-04-27 | 1 | -1/+1 | |
| | | | ||||||
| * | | More using <tt>x</tt> instead of +x+ when the latter renders improperly. | Mark Rushakoff | 2012-04-27 | 1 | -1/+1 | |
| | | | ||||||
* | | | no need to dup options in send_data | Sergey Nartimov | 2012-04-30 | 1 | -1/+1 | |
| | | | | | | | | | | | | options aren't modified inside send_file_headers! | |||||
* | | | allow send_file/send_data to skip disposition header, closes #2973 | Sergey Nartimov | 2012-04-30 | 1 | -17/+11 | |
| | | | ||||||
* | | | Add note about using 303 See Other for XHR requests other than GET/POST | Andrew White | 2012-04-30 | 1 | -0/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IE since version 6 and recently Chrome and Firefox have started following 302 redirects from XHR requests other than GET/POST using the original request method. This can lead to DELETE requests being redirected amongst other things. Although it doesn't directly affect the Rails framework since it doesn't return a 302 redirect to any non-GET/POST request a note has been added to raise awareness of the issue. Some references: Original article from @technoweenie: http://techno-weenie.net/2011/8/19/ie9-deletes-stuff/ Hacker News discussion of the article: http://news.ycombinator.com/item?id=2903493 WebKit bug report: https://bugs.webkit.org/show_bug.cgi?id=46183 Firefox bug report and changeset: https://bugzilla.mozilla.org/show_bug.cgi?id=598304 https://hg.mozilla.org/mozilla-central/rev/9525d7e2d20d Chrome bug report: http://code.google.com/p/chromium/issues/detail?id=56373 HTTPbis bug report and changeset: http://trac.tools.ietf.org/wg/httpbis/trac/ticket/160 http://trac.tools.ietf.org/wg/httpbis/trac/changeset/1428 Roy T. Fielding's history of the issue: http://ftp.ics.uci.edu/pub/ietf/http/hypermail/1997q3/0611.html Automated browser tests for the issue: http://www.mnot.net/javascript/xmlhttprequest/ Fixes #4144 | |||||
* | | | Avoid calling content type multiple times | José Valim | 2012-04-29 | 1 | -4/+6 | |
| | | | ||||||
* | | | Merge pull request #2321 from omjokine/master | José Valim | 2012-04-29 | 1 | -1/+4 | |
|\ \ \ | |/ / |/| | | JSONP should use mimetype application/javascript | |||||
| * | | Merge remote-tracking branch 'upstream/master' | Olli Jokinen | 2011-12-01 | 15 | -73/+83 | |
| |\ \ | ||||||
| * | | | Change mimetype to Mime::JS if JSONP is used | Olli Jokinen | 2011-07-28 | 1 | -1/+4 | |
| | | | | ||||||
* | | | | Use <tt>Foo::Bar</tt> instead of +Foo::Bar+ | Mark Rushakof | 2012-04-27 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The latter doesn't render as code in HTML output. Regex used in Rubymine to locate the latter form: (\+)(:*\w+:(?::|\w)+)(\+) | |||||
* | | | | #send_file leans on Rack::Sendfile to X-Accel-Redirect the file's path, so ↵ | Jeremy Kemper | 2012-04-12 | 1 | -1/+21 | |
| | | | | | | | | | | | | | | | | opening the file to set the response body is wasteful. Set a FileBody wrapper instead that responds to to_path and streams the file if needed. | |||||
* | | | | Remove unnecessary in HTML 5 type attribute with default value | Andrey A.I. Sitnik | 2012-04-05 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 3 | -3/+3 | |
|\ \ \ \ | | | | | | | | | | | Updated/changed unneeded tr/gsubs | |||||
| * | | | | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 3 | -3/+3 | |
| | | | | | ||||||
* | | | | | Fix AC responder example | Alexey Vakhov | 2012-04-04 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Remove non-obligatory params in AC respond_to examples | Alexey Vakhov | 2012-04-03 | 1 | -2/+2 | |
|/ / / / | ||||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-01 | 1 | -1/+0 | |
|\ \ \ \ | ||||||
| * | | | | CSRF messages are no longer controlled by 422.html because ↵ | Tony Primerano | 2012-03-28 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | InvalidAuthenticityToken is not raised | |||||
* | | | | | Remove obsolete reader from AC::MethodNotAllowed exception class | Alexey Vakhov | 2012-03-31 | 1 | -2/+0 | |
| | | | | | ||||||
* | | | | | Remove AC::RenderError class second declaration | Alexey Vakhov | 2012-03-31 | 1 | -3/+0 | |
|/ / / / | ||||||
* | | | | respond_with description: changed 'response' to 'format' | Mark Thomson | 2012-03-18 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Revised comments for respond_with | Mark Thomson | 2012-03-18 | 1 | -17/+18 | |
| | | | | ||||||
* | | | | Merge remote-tracking branch 'origin/master' | Mark Thomson | 2012-03-17 | 5 | -6/+27 | |
|\ \ \ \ | ||||||
| * | | | | strip null bytes from Location header as well | Brian Lopez | 2012-03-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | add tests for stripping \r\n chars since that's already happening |