aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/metal/testing.rb
Commit message (Collapse)AuthorAgeFilesLines
* remove RackDelegation moduleAaron Patterson2015-08-261-2/+0
| | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-291-1/+1
|
* Fix controller test not resetting @_url_optionsTony Wooster2014-02-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 4f2cd3e9 introduced a bug by reordering the call to `@controller.recycle!` above the call to `build_request_uri`. The impact of this was that the `@_url_options` cache ends up not being reset between building a request URI (occurring within the test controller) and the firing of the actual request. We encountered this bug because we had the following setup: class MinimumReproducibleController < ActionController::Base before_filter { @param = 'param' } def index render text: url_for(params) end def default_url_options { custom_opt: @param } end end def test_index get :index # builds url, then fires actual request end The first step in `get :index` in the test suite would populate the @_url_options cache. The subsequent call to `url_for` inside of the controller action would then utilize the uncleared cache, thus never calling the now-updated default_url_options. This commit fixes this bug calling recycle! twice, and removes a call to set response_body, which should no longer be needed since we're recycling the request object explicitly.
* group things that are alikeAaron Patterson2012-07-031-0/+3
|
* push functional test specific methods to it's own moduleAaron Patterson2012-07-031-8/+10
|
* push the cookie writing stuff out of the controllerAaron Patterson2012-07-031-23/+2
| | | | merging cookies is responsibility of the test runner
* extend the controller with special logic on recycleAaron Patterson2012-07-031-10/+25
| | | | | | For some reason, this special logic is only supposed to be executed on the second request. For now, we'll extend on recycle, but we should figure out why this functionality can't be run on every request
* push req / res setting to the test runnerAaron Patterson2012-07-031-4/+0
| | | | | Try to avoid making the controller mutate itself so that we can eventually make the response async
* Fix the issue where default_url_options is being cached on test cases. ↵thoefer2011-08-011-0/+5
| | | | | | Closes #1872. Closes #2031. Signed-off-by: José Valim <jose.valim@gmail.com>
* Move @assigns from the controller to the test itselfSantiago Pastorino2010-11-061-1/+0
|
* Fix problems trying to functional test AC::Metal controllersSantiago Pastorino2010-11-061-9/+1
| | | | [#5393 state:committed]
* Fix streaming by having it create a File object, which can be handled by ↵Carlhuda2010-02-231-1/+0
| | | | Rack servers as appropriate
* deOMGifying Railties, Active Support, and Action PackMikel Lindsaar2010-01-311-1/+1
|
* Cookies middlewareJoshua Peek2010-01-161-0/+3
|
* Rename RackConvenience => RackDelegationJoshua Peek2009-12-201-1/+1
|
* Rename /base to /metal and make base.rb and metal.rb top-level to reflect ↵Yehuda Katz2009-08-061-0/+39
their module locations