| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Reduce block execution | Akira Matsuda | 2019-07-31 | 1 | -3/+3 |
| | | |||||
| * | Reduce Array assignment by not giving a name for unused `*args` | Akira Matsuda | 2019-07-31 | 1 | -3/+3 |
| | | |||||
| * | No need to dup the payload for an instrumentation | Akira Matsuda | 2019-07-31 | 1 | -1/+1 |
| | | |||||
| * | Enable `Layout/EmptyLinesAroundAccessModifier` cop | Ryuta Kamizono | 2019-06-13 | 1 | -1/+0 |
| | | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost. | ||||
| * | Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin block | Ryuta Kamizono | 2018-12-21 | 1 | -5/+3 |
| | | | | | | | | | | | Currently we sometimes find a redundant begin block in code review (e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205). I'd like to enable `Style/RedundantBegin` cop to avoid that, since rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5 (https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with that situation than before. | ||||
| * | Keep `:api: plugin` methods in the doc [ci skip] | Ryuta Kamizono | 2017-10-20 | 1 | -2/+2 |
| | | | | | | | | `:api:` tag was removed in 5349f231 since RDoc doesn't support `:api:` tag. But those methods are not private API, they are public API for renderers. The renderers should be able to know that they can override this method. | ||||
| * | Remove `:api:` tag that has leaked on the doc directly [ci skip] | Ryuta Kamizono | 2017-09-30 | 1 | -4/+0 |
| | | | | | | | | | | | | | Currently `:api:` tag has leaked on the doc directly since RDoc doesn't support `:api:` tag directive. http://api.rubyonrails.org/v5.1/classes/AbstractController/Rendering.html So `:api: private` doesn't work as expected. We are using `:nodoc:` for the purpose. Related #13989. | ||||
| * | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
| * | [docs] fix ActionController documentation | Hrvoje Šimić | 2017-03-12 | 1 | -1/+1 |
| | | | | | [ci skip] | ||||
| * | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -2/+2 |
| | | |||||
| * | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | | |||||
| * | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -1/+1 |
| | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
| * | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 1 | -9/+9 |
| | | |||||
| * | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Actionpack documentation typos [ci skip] | Tom Kadwill | 2016-04-23 | 1 | -2/+2 |
| | | |||||
| * | Pass headers through to payload for logging. | Gareth du Plooy | 2016-03-08 | 1 | -0/+1 |
| | | | | | Make request headers available in the event payload so that it is available to attached ActionController::LogSubscribers. | ||||
| * | Request#fullpath should not raise an exception, so remove the rescue | Aaron Patterson | 2016-02-09 | 1 | -1/+1 |
| | | |||||
| * | AC::Request#format always returns a value, so we do not need to try | Aaron Patterson | 2016-02-09 | 1 | -1/+1 |
| | | |||||
| * | remove RackDelegation module | Aaron Patterson | 2015-08-26 | 1 | -1/+0 |
| | | | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response) | ||||
| * | Ensure append_info_to_payload is called even if an exception is raised. | Dieter Komendera | 2014-12-10 | 1 | -4/+7 |
| | | | | | | | | | See: * https://github.com/rails/rails/pull/14903 * https://github.com/roidrage/lograge/issues/37 Some code by mxrguspxrt from #14903. | ||||
| * | Use request method instead of ActionDispatch::Request#request_method instead ↵ | Ilya Katz | 2014-11-20 | 1 | -1/+1 |
| | | | | | of ActionDispatch::Request#method to pick up overrides by the middleware | ||||
| * | typos rectified [ci skip] | Aayush khandelwal | 2013-12-12 | 1 | -1/+1 |
| | | |||||
| * | Adding filter capability to ActionController logs | Fabrizio Regini | 2012-12-05 | 1 | -1/+1 |
| | | |||||
| * | Instrumentation requires RackDelegation | José Valim | 2012-08-30 | 1 | -0/+1 |
| | | | | Since it uses request and response methods | ||||
| * | Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵ | José Valim | 2011-11-30 | 1 | -1/+6 |
| | | | | | a before callback halts. | ||||
| * | Methods like status and location are interfering with redirect_to [Closes #2511] | Franck Verrot | 2011-08-14 | 1 | -3/+3 |
| | | |||||
| * | don't raise an exception if the format isn't recognized | dmathieu | 2011-05-26 | 1 | -1/+1 |
| | | | | | Fixed while traveling to heuruko | ||||
| * | Use .ref instead of .to_sym. | José Valim | 2011-05-07 | 1 | -1/+1 |
| | | |||||
| * | Improve performance for filtered parameters and add tests. | José Valim | 2011-05-03 | 1 | -1/+1 |
| | | |||||
| * | Action Pack typos. | R.T. Lechow | 2011-03-05 | 1 | -1/+1 |
| | | |||||
| * | Add a test for elapsed and require missing benchmark file. | José Valim | 2010-07-20 | 1 | -0/+1 |
| | | |||||
| * | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | | not "ActiveRecord" | ||||
| * | Change event namespace ordering to most-significant first [#4504 state:resolved] | Justin George | 2010-05-02 | 1 | -5/+5 |
| | | | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | ActionDispatch::Request deprecates #request_uri | Carl Lerche | 2010-03-03 | 1 | -1/+1 |
| | | | | | * Refactored ActionPatch to use fullpath instead | ||||
| * | Add method and path to AC notifications. | José Valim | 2010-02-03 | 1 | -1/+3 |
| | | |||||
| * | Tidy up new filter_parameters implementation. | José Valim | 2010-01-21 | 1 | -1/+0 |
| | | |||||
| * | Move filter_parameter_logging logic out of the controller and create ↵ | Prem Sichanugrist | 2010-01-21 | 1 | -1/+1 |
| | | | | | | | ActionDispatch::ParametersFilter to handle parameter filteration instead. This will make filteration not depending on controller anymore. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Bring normalize behavior to AbstractController::Rendering | José Valim | 2010-01-20 | 1 | -11/+5 |
| | | |||||
| * | Move parameters to the top on logging. | José Valim | 2010-01-19 | 1 | -7/+13 |
| | | |||||
| * | Add ActionDispatch::Railties::Subscriber and finish tidying up the logging. | José Valim | 2010-01-17 | 1 | -4/+0 |
| | | |||||
| * | Do not send the whole controller in notifications, cherry pick required pieces. | José Valim | 2010-01-15 | 1 | -9/+32 |
| | | |||||
| * | Move Dispatcher setup to Railties and add instrumentation hook. | José Valim | 2010-01-15 | 1 | -1/+1 |
| | | |||||
| * | Tidy up ActiveRecord and Views runtime information on process action logger. | José Valim | 2010-01-14 | 1 | -3/+5 |
| | | |||||
| * | Add subscriber for ActionPack and move all logging inside it. | José Valim | 2010-01-13 | 1 | -0/+77 |
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |