aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_controller/metal/instrumentation.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-131-1/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin blockRyuta Kamizono2018-12-211-5/+3
| | | | | | | | | | Currently we sometimes find a redundant begin block in code review (e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205). I'd like to enable `Style/RedundantBegin` cop to avoid that, since rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5 (https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with that situation than before.
* Keep `:api: plugin` methods in the doc [ci skip]Ryuta Kamizono2017-10-201-2/+2
| | | | | | | `:api:` tag was removed in 5349f231 since RDoc doesn't support `:api:` tag. But those methods are not private API, they are public API for renderers. The renderers should be able to know that they can override this method.
* Remove `:api:` tag that has leaked on the doc directly [ci skip]Ryuta Kamizono2017-09-301-4/+0
| | | | | | | | | | | | Currently `:api:` tag has leaked on the doc directly since RDoc doesn't support `:api:` tag directive. http://api.rubyonrails.org/v5.1/classes/AbstractController/Rendering.html So `:api: private` doesn't work as expected. We are using `:nodoc:` for the purpose. Related #13989.
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* [docs] fix ActionController documentationHrvoje Šimić2017-03-121-1/+1
| | | | [ci skip]
* No need to nodoc private methodsAkira Matsuda2016-12-241-2/+2
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* code gardening: removes redundant selfsXavier Noria2016-08-081-1/+1
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* modernizes hash syntax in actionpackXavier Noria2016-08-061-9/+9
|
* applies new string literal convention in actionpack/libXavier Noria2016-08-061-2/+2
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Actionpack documentation typos [ci skip]Tom Kadwill2016-04-231-2/+2
|
* Pass headers through to payload for logging.Gareth du Plooy2016-03-081-0/+1
| | | | Make request headers available in the event payload so that it is available to attached ActionController::LogSubscribers.
* Request#fullpath should not raise an exception, so remove the rescueAaron Patterson2016-02-091-1/+1
|
* AC::Request#format always returns a value, so we do not need to tryAaron Patterson2016-02-091-1/+1
|
* remove RackDelegation moduleAaron Patterson2015-08-261-1/+0
| | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
* Ensure append_info_to_payload is called even if an exception is raised.Dieter Komendera2014-12-101-4/+7
| | | | | | | | See: * https://github.com/rails/rails/pull/14903 * https://github.com/roidrage/lograge/issues/37 Some code by mxrguspxrt from #14903.
* Use request method instead of ActionDispatch::Request#request_method instead ↵Ilya Katz2014-11-201-1/+1
| | | | of ActionDispatch::Request#method to pick up overrides by the middleware
* typos rectified [ci skip]Aayush khandelwal2013-12-121-1/+1
|
* Adding filter capability to ActionController logsFabrizio Regini2012-12-051-1/+1
|
* Instrumentation requires RackDelegationJosé Valim2012-08-301-0/+1
| | | Since it uses request and response methods
* Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵José Valim2011-11-301-1/+6
| | | | a before callback halts.
* Methods like status and location are interfering with redirect_to [Closes #2511]Franck Verrot2011-08-141-3/+3
|
* don't raise an exception if the format isn't recognizeddmathieu2011-05-261-1/+1
| | | | Fixed while traveling to heuruko
* Use .ref instead of .to_sym.José Valim2011-05-071-1/+1
|
* Improve performance for filtered parameters and add tests.José Valim2011-05-031-1/+1
|
* Action Pack typos.R.T. Lechow2011-03-051-1/+1
|
* Add a test for elapsed and require missing benchmark file.José Valim2010-07-201-0/+1
|
* edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-141-1/+1
| | | | not "ActiveRecord"
* Change event namespace ordering to most-significant first [#4504 state:resolved]Justin George2010-05-021-5/+5
| | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com>
* ActionDispatch::Request deprecates #request_uriCarl Lerche2010-03-031-1/+1
| | | | * Refactored ActionPatch to use fullpath instead
* Add method and path to AC notifications.José Valim2010-02-031-1/+3
|
* Tidy up new filter_parameters implementation.José Valim2010-01-211-1/+0
|
* Move filter_parameter_logging logic out of the controller and create ↵Prem Sichanugrist2010-01-211-1/+1
| | | | | | ActionDispatch::ParametersFilter to handle parameter filteration instead. This will make filteration not depending on controller anymore. Signed-off-by: José Valim <jose.valim@gmail.com>
* Bring normalize behavior to AbstractController::RenderingJosé Valim2010-01-201-11/+5
|
* Move parameters to the top on logging.José Valim2010-01-191-7/+13
|
* Add ActionDispatch::Railties::Subscriber and finish tidying up the logging.José Valim2010-01-171-4/+0
|
* Do not send the whole controller in notifications, cherry pick required pieces.José Valim2010-01-151-9/+32
|
* Move Dispatcher setup to Railties and add instrumentation hook.José Valim2010-01-151-1/+1
|
* Tidy up ActiveRecord and Views runtime information on process action logger.José Valim2010-01-141-3/+5
|
* Add subscriber for ActionPack and move all logging inside it.José Valim2010-01-131-0/+77
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 10:32:39 +0000