Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make sure the flash method is defined even if helpers are not present | Rafael Mendonça França | 2018-09-13 | 1 | -5/+3 |
| | |||||
* | Conditionally use `helper_method` in Flash concern | Eric Anderson | 2018-08-09 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | | | I was attempting to use the `flash` functionality in a `Metal` controller. When including the `flash` concern I received the following error: NoMethodError: undefined method `helper_method'.... Either: - `AbstractController::Helpers` should be a dependency of `ActionController::Flash` - `ActionController::Flash` should not require the existence of `AbstractController::Helpers`. Since my use case (set a flash and redirect) has no need for the helper method and that is a common use case, making the dependency conditional seemed the better option. NOTE: This is similar to issue #21067 only the error is within Rails itself while that issue had the error within Devise. | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add option for class_attribute default (#29270) | David Heinemeier Hansson | 2017-05-29 | 1 | -2/+1 |
| | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation | ||||
* | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | |||||
* | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -1/+1 |
| | | | | subclasses. | ||||
* | Add documentation for add_flash_types [ci skip] | Robin Dupret | 2013-07-10 | 1 | -0/+17 |
| | | | | | Document a little bit the ActionController::Flash::add_flash_types class method. | ||||
* | Use "instance_accessor" for flash types class attribute | Carlos Antonio da Silva | 2012-07-07 | 1 | -3/+3 |
| | |||||
* | Added support add_flash_types | kennyj | 2012-07-07 | 1 | -8/+23 |
| | |||||
* | Move Flash into middleware | Joshua Peek | 2010-01-15 | 1 | -175/+2 |
| | |||||
* | Silence some trivial warnings: shadowed local vars, indentation mismatches | Jeremy Kemper | 2009-12-28 | 1 | -60/+59 |
| | |||||
* | Merge Session stuff into RackConvenience | Joshua Peek | 2009-12-20 | 1 | -6/+4 |
| | |||||
* | Added alert/notice from 2-3-stable and refactored redirect_to into just ↵ | David Heinemeier Hansson | 2009-12-17 | 1 | -0/+41 |
| | | | | living in Redirector [DHH] | ||||
* | Fix warning in AC flash | Joshua Peek | 2009-12-14 | 1 | -0/+1 |
| | |||||
* | Make controller.flash public to be used in responders. | José Valim | 2009-12-07 | 1 | -12/+12 |
| | | | | Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | Clean up flash a bit | Yehuda Katz | 2009-10-27 | 1 | -1/+1 |
| | |||||
* | Clean up flash a bit | Yehuda Katz | 2009-10-26 | 1 | -25/+23 |
| | |||||
* | Rename /base to /metal and make base.rb and metal.rb top-level to reflect ↵ | Yehuda Katz | 2009-08-06 | 1 | -0/+164 |
their module locations |