Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add `Style/RedundantFreeze` to remove redudant `.freeze` | Yasuo Honda | 2018-09-29 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | Since Rails 6.0 will support Ruby 2.4.1 or higher `# frozen_string_literal: true` magic comment is enough to make string object frozen. This magic comment is enabled by `Style/FrozenStringLiteralComment` cop. * Exclude these files not to auto correct false positive `Regexp#freeze` - 'actionpack/lib/action_dispatch/journey/router/utils.rb' - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb' It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333 Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed. * Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required - 'actionpack/test/controller/test_case_test.rb' - 'activemodel/test/cases/type/string_test.rb' - 'activesupport/lib/active_support/core_ext/string/strip.rb' - 'activesupport/test/core_ext/string_ext_test.rb' - 'railties/test/generators/actions_test.rb' | ||||
* | Encode Content-Disposition filenames on send_data and send_file | Fumiaki MATSUSHIMA | 2018-09-13 | 1 | -4/+3 |
| | |||||
* | [Action Pack] require => require_relative | Akira Matsuda | 2017-10-21 | 1 | -1/+1 |
| | | | | | This basically reverts e9fca7668b9eba82bcc832cb0061459703368397, d08da958b9ae17d4bbe4c9d7db497ece2450db5f, d1fe1dcf8ab1c0210a37c2a78c1ee52cf199a66d, and 68eaf7b4d5f2bb56d939f71c5ece2d61cf6680a3 | ||||
* | Update links to use https link instead of http [ci skip] | Yoshiyuki Hirano | 2017-08-22 | 1 | -3/+3 |
| | |||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Assign `content_type` only once | yui-knk | 2017-07-13 | 1 | -2/+2 |
| | |||||
* | [Action Controller] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -1/+1 |
| | |||||
* | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 1 | -2/+1 |
| | |||||
* | Only default the response charset when it is first set | Matthew Draper | 2016-12-20 | 1 | -3/+3 |
| | | | | | If it is explicitly cleared (e.g., response.sending_file = true), then we should not try to set it again. | ||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -1/+1 |
| | |||||
* | Allow `send_file` to declare a charset | Jon Moss | 2016-08-29 | 1 | -0/+1 |
| | | | | | | Removed my patch in favor of @tenderlove's less invasive approach. [Aaron Patterson & Jon Moss] | ||||
* | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 1 | -6/+6 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Actioncable and Actionpack documentation typos [ci skip] | Tom Kadwill | 2016-04-21 | 1 | -10/+9 |
| | |||||
* | Update send_data documentation [ci skip] | Anton Rieder | 2016-04-19 | 1 | -1/+1 |
| | | | Add missing period after sentence. | ||||
* | move file sending to the response object | Aaron Patterson | 2015-10-05 | 1 | -25/+1 |
| | | | | | | | Just a slight refactor that delegates file sending to the response object. This gives us the advantage that if a webserver (in the future) provides a response object that knows how to do accelerated file serving, it can implement this method. | ||||
* | Revert "this always sets :public to false, so just do that" | Aaron Patterson | 2015-08-27 | 1 | -1/+1 |
| | | | | | | This reverts commit cae2b5bb59212961c4a35c939381ebece48d1177. I am an idiot. | ||||
* | this always sets :public to false, so just do that | Aaron Patterson | 2015-08-27 | 1 | -1/+1 |
| | |||||
* | Stop using deprecated `render :text` in test | Prem Sichanugrist | 2015-07-17 | 1 | -1/+1 |
| | | | | | | | | | This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`. | ||||
* | move buffer caching on to the buffer | Aaron Patterson | 2015-07-13 | 1 | -0/+4 |
| | |||||
* | Update Docs in favor to use render plain instead of text option | robertomiranda | 2014-02-18 | 1 | -1/+1 |
| | | | | ref #14062 | ||||
* | Accept symbols as #send_data :disposition value | Elia Schito | 2012-11-27 | 1 | -0/+1 |
| | |||||
* | Multiple changes to 1,9 hash syntax | AvnerCohen | 2012-10-27 | 1 | -5/+5 |
| | |||||
* | Minor language fix. [ci skip] | Erich Menge | 2012-08-15 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 1 | -1/+1 |
|\ | |||||
| * | Code-format references to config settings | Mark Rushakoff | 2012-04-27 | 1 | -1/+1 |
| | | |||||
* | | no need to dup options in send_data | Sergey Nartimov | 2012-04-30 | 1 | -1/+1 |
| | | | | | | | | options aren't modified inside send_file_headers! | ||||
* | | allow send_file/send_data to skip disposition header, closes #2973 | Sergey Nartimov | 2012-04-30 | 1 | -17/+11 |
|/ | |||||
* | #send_file leans on Rack::Sendfile to X-Accel-Redirect the file's path, so ↵ | Jeremy Kemper | 2012-04-12 | 1 | -1/+21 |
| | | | | opening the file to set the response body is wasteful. Set a FileBody wrapper instead that responds to to_path and streams the file if needed. | ||||
* | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 1 | -1/+1 |
| | |||||
* | remove File#to_path alias | Vasiliy Ermolovich | 2011-12-25 | 1 | -2/+1 |
| | |||||
* | status is a number in Rails 3 | Akira Matsuda | 2011-10-12 | 1 | -2/+2 |
| | |||||
* | x_sendfile_header now defaults to nil and production.rb env file doesn't | Santiago Pastorino | 2011-08-07 | 1 | -1/+1 |
| | | | | | | | set a particular value for it. This allows servers to set it through X-Sendfile-Type, read https://github.com/rack/rack/blob/master/lib/rack/sendfile.rb for more info. Anyways you can force this value in your production.rb | ||||
* | TODO fix explicitly loading exceptations, autoload removed | Vishnu Atrai | 2011-07-11 | 1 | -0/+1 |
| | |||||
* | Make send_file guess content-type from file extension, if type wasn't ↵ | Esad Hajdarevic | 2011-06-28 | 1 | -2/+13 |
| | | | | supplied (Issue #1847). Update tests & documentation. | ||||
* | Remove extra white spaces on ActionPack docs. | Sebastian Martinez | 2011-05-23 | 1 | -3/+3 |
| | |||||
* | Rename it to DataStreaming. | José Valim | 2011-04-18 | 1 | -0/+145 |