Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixed a comment typo | Eric Hayes | 2011-04-14 | 1 | -1/+1 |
| | |||||
* | #948 template_inheritance | artemave | 2010-12-26 | 1 | -2/+2 |
| | |||||
* | Rewording existing comment | Neeraj Singh | 2010-11-29 | 1 | -6/+3 |
| | |||||
* | no need to call e.class | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Fix a small typo (ht: masterkain) | José Valim | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -3/+1 |
| | | | | everyone calls super as expected. | ||||
* | Define @_layout if it is not defined. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | |||||
* | change rdoc to conform to api guidelines | Joost Baaij | 2010-08-25 | 1 | -10/+12 |
| | |||||
* | refactor evals and adds some __FILE__ and __LINE__ | Santiago Pastorino | 2010-05-20 | 1 | -3/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | We seem to have removed the URL helpers from ActionView subclasses... | wycats | 2010-03-18 | 1 | -0/+1 |
| | |||||
* | Make render :partial, :layout consistent between AC and AV | Carlhuda | 2010-03-18 | 1 | -6/+0 |
| | |||||
* | Remove caching's dependency on view_context. Also, make it so that the ↵ | Carlhuda | 2010-03-18 | 1 | -4/+12 |
| | | | | layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render) | ||||
* | Make action_has_layout? non-private | Carlhuda | 2010-03-18 | 1 | -4/+4 |
| | |||||
* | Eliminate warnings for AM on 1.8 | wycats | 2010-03-16 | 1 | -0/+4 |
| | |||||
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 1 | -0/+6 |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | ||||
* | More refactoring on the views side of rendering. | José Valim | 2010-03-08 | 1 | -7/+2 |
| | |||||
* | Finally moved the find template logic to the views. | José Valim | 2010-03-08 | 1 | -3/+4 |
| | |||||
* | More refactoring. Split _normalize_args and _normalize_options concerns. | José Valim | 2010-03-08 | 1 | -2/+6 |
| | |||||
* | More cleanup on the layouts side. | José Valim | 2010-03-08 | 1 | -53/+28 |
| | |||||
* | Move layout lookup to views. | José Valim | 2010-03-08 | 1 | -19/+6 |
| | |||||
* | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -29/+8 |
| | | | | lookup. | ||||
* | Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵ | José Valim | 2010-02-26 | 1 | -3/+0 |
| | | | | status:resolved] | ||||
* | Convert to class_attribute | Jeremy Kemper | 2010-02-01 | 1 | -2/+6 |
| | |||||
* | Bring layouts with proc back alive. | José Valim | 2010-01-26 | 1 | -0/+3 |
| | |||||
* | controller_path is required by ActionView, so move it up to ↵ | José Valim | 2009-12-31 | 1 | -1/+157 |
| | | | | AbstractController and refactor AbstractController::Layouts. | ||||
* | Silence some trivial warnings: shadowed local vars, indentation mismatches | Jeremy Kemper | 2009-12-28 | 1 | -1/+1 |
| | |||||
* | Rename the RenderingController module to just plain Rendering | David Heinemeier Hansson | 2009-12-20 | 1 | -1/+1 |
| | |||||
* | Revert "Revert "Eliminate warning with layout is unset"" | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | | | | This reverts commit d8fd0499bfd6edc676ff3fbffc327656f6d5c320. | ||||
* | Revert "Eliminate warning with layout is unset" | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | | | | This reverts commit 1fcf32f8fef8fb5a63a66edacf556a107d12c049. | ||||
* | Eliminate warning with layout is unset | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | |||||
* | Revert "Eliminate warning with layout is unset" | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | | | | This reverts commit 90be80361f26d717f9842170315dd8659f35429d. | ||||
* | Eliminate warning with layout is unset | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | |||||
* | If class doesn't have a name, there's no implied layout name, so don't set ↵ | Jeremy Kemper | 2009-11-05 | 1 | -10/+12 |
| | | | | up a _layout method | ||||
* | Add some basic render_test to AbstractController. | José Valim | 2009-11-01 | 1 | -1/+1 |
| | |||||
* | Move all render and layout pieces required in ActionMailer from ↵ | José Valim | 2009-11-01 | 1 | -0/+9 |
| | | | | ActionController to AbstractController. | ||||
* | Refactor ActionMailer layout and remove legacy one. | José Valim | 2009-11-01 | 1 | -0/+20 |
| | |||||
* | Refactor ActionController to use find_template and template_exists? | Yehuda Katz + Carl Lerche | 2009-09-03 | 1 | -5/+5 |
| | |||||
* | Add a TODO so we remember to fix partial layouts | Yehuda Katz + Carl Lerche | 2009-08-25 | 1 | -0/+3 |
| | |||||
* | Caches and cache clearing seems to actually work, but the actual ↵ | Yehuda Katz | 2009-08-15 | 1 | -4/+9 |
| | | | | architecture is kind of messy. Next: CLEAN UP. | ||||
* | More perf work: | Yehuda Katz | 2009-08-11 | 1 | -17/+32 |
| | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare! | ||||
* | Add some more caching to the lookup | Yehuda Katz | 2009-08-11 | 1 | -4/+18 |
| | |||||
* | First pass at making partial rendering an Object. More cleanup to come. | Yehuda Katz | 2009-08-08 | 1 | -8/+10 |
| | |||||
* | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 1 | -2/+2 |
| | |||||
* | Renamed presenter to renderer, added some documentation and defined its API. | José Valim | 2009-08-07 | 1 | -1/+1 |
| | |||||
* | Get all ActionController partial rendering to use ActionView's partial code. ↵ | Yehuda Katz | 2009-08-07 | 1 | -0/+16 |
| | | | | | | | | | | | | | | Consequences: * It is not possible to always pre-determine the layout before going to ActionView. This was *already* broken for render :partial => @object, :layout => true. This is now handled by overriding render_to_body in layouts.rb and manually injecting the partial's response. This needs to be done in ActionController since ActionController knows enough to get _layout_for_option. There is probably a better abstraction here. * As a result, all partial rendering can correctly restrict their layouts to the mime type of the rendered partial. This could have previously caused a bug in some edge cases. * If other layout-like options are added, they might need to add special code for the case of render :partial. We should try to think of an alternate solution, if possible, but this works for the cases we know of now. | ||||
* | Move AbstractController to a top-level component | Yehuda Katz | 2009-08-06 | 1 | -0/+164 |