Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Removed non-standard and unused require 'active_support/deprecation' from ↵ | Vipul A M | 2015-02-27 | 1 | -2/+0 |
| | | | | parts out of active_support. | ||||
* | fix NameError in `skip_filter`. callback doesn't exist. | yuuji.yaginuma | 2015-02-27 | 1 | -1/+1 |
| | |||||
* | Deprecate `AbstractController::Callbacks#skip_action_callback` | Iain Beeston | 2015-02-24 | 1 | -0/+1 |
| | | | | | | | | | | As part of #19029, in future `skip_before_action`, `skip_after_action` and `skip_around_action` will raise an ArgumentError if the specified callback does not exist. `skip_action_callback` calls all three of these methods and will almost certainly result in an ArgumentError. If anyone wants to remove all three callbacks then they can still call the three individual methods. Therefore let's deprecate `skip_action_callback` now and remove it when #19029 is merged. | ||||
* | fix typo in `_filter` deprecation message. [ci skip] | Yves Senn | 2015-01-30 | 1 | -5/+5 |
| | |||||
* | Deprecate all *_filter callbacks in favor of *_action callbacks | Abdelkader Boudih | 2015-01-08 | 1 | -5/+27 |
| | |||||
* | Add test/doc for :if/:except in skip_before_action | claudiob | 2015-01-08 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | The new test/docs further explain the conflicts that can happen when mixing `:if`/`:unless` options with `:only`/`:except` options in `skip_before_action`. The gist is that "positive" filters always have priority over negative ones. The previous commit already showed that `:only` has priority over `:if`. This commit shows that `:if` has priority over `:except`. For instance, the following snippets are equivalent: ```ruby skip_before_action :some_callback, if: -> { condition }, except: action ``` ```ruby skip_before_action :some_callback, if: -> { condition } ``` | ||||
* | Add test case and documentation for skip_before_filter. | Lauro Caetano | 2015-01-08 | 1 | -0/+5 |
| | | | | | | | | Test case for using skip_before_filter with the options :only and :if both present. In this case, the :if option will be ignored and :only will be executed. Closes #14549 (the commit was cherry-picked from there). | ||||
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacks | Rafael Mendonça França | 2015-01-03 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md | ||||
| * | Throw :abort halts default CallbackChains | claudiob | 2015-01-02 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes arguments and default value of CallbackChain's :terminator option. After this commit, Chains of callbacks defined **without** an explicit `:terminator` option will be halted as soon as a `before_` callback throws `:abort`. Chains of callbacks defined **with** a `:terminator` option will maintain their existing behavior of halting as soon as a `before_` callback matches the terminator's expectation. For instance, ActiveModel's callbacks will still halt the chain when a `before_` callback returns `false`. | ||||
* | | Better docs for AbstractController | claudiob | 2014-12-22 | 1 | -4/+5 |
|/ | | | | | | Fixes internal links, adds examples and set fixed-width fonts. [ci skip] | ||||
* | Partially revert deprecation of *_filter | Rafael Mendonça França | 2014-06-03 | 1 | -27/+6 |
| | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md | ||||
* | Deprecate all *_filter callbacks in favor of *_action callbacks | Rafael Mendonça França | 2014-05-27 | 1 | -20/+24 |
| | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c | ||||
* | replace class_eval by define_method in abstract_controller/callbacks | kirill | 2014-04-20 | 1 | -35/+29 |
| | |||||
* | Execute conditional procs on controller filters only for current action. | Nicholas Jakobsen | 2013-08-10 | 1 | -1/+1 |
| | | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786. | ||||
* | use extract_options! | Neeraj Singh | 2013-07-02 | 1 | -1/+1 |
| | |||||
* | deprecating string based terminators | Aaron Patterson | 2013-05-14 | 1 | -1/+3 |
| | |||||
* | fix prepend_before_filter documentation [ci skip] | Francesco Rodriguez | 2012-12-07 | 1 | -3/+3 |
| | |||||
* | Rename all action callbacks from *_filter to *_action | David Heinemeier Hansson | 2012-12-07 | 1 | -64/+86 |
| | |||||
* | Removing duplication in callback normalization. | Steve Klabnik | 2012-11-09 | 1 | -7/+8 |
| | | | | These two things were 100% identical. | ||||
* | removing key argument from run_callbacks - fix build | Francesco Rodriguez | 2012-05-10 | 1 | -1/+1 |
| | |||||
* | Improve readability of metaprogramming annotations at AbstractController ↵ | Edward Tsech | 2012-05-08 | 1 | -10/+10 |
| | | | | callbacks. | ||||
* | Remove skip_filter block param | Alexey Vakhov | 2012-02-23 | 1 | -7/+7 |
| | |||||
* | Merge pull request #4866 from bogdan/terminate_after_callbacks | José Valim | 2012-02-04 | 1 | -3/+1 |
|\ | | | | | AS::Callbacks#define_callbacks: add :terminate_after_callbacks option | ||||
| * | AS::Callbacks: :skip_after_callbacks_if_terminated option | Bogdan Gusiev | 2012-02-03 | 1 | -3/+1 |
| | | |||||
* | | AC::Callbacks: remove usage of :per_key option from filters | Bogdan Gusiev | 2012-02-03 | 1 | -6/+4 |
|/ | |||||
* | Array.wrap is no longer needed in AbstractController::Callbacks | Rafael Mendonça França | 2012-01-05 | 1 | -2/+2 |
| | |||||
* | Fix comment in AbstractController callbacks | Alexey Vakhov | 2011-10-06 | 1 | -2/+2 |
| | |||||
* | update abstract_controller callbacks to document meta-programmed filters | geemus | 2011-08-13 | 1 | -18/+102 |
| | |||||
* | Revert to old semantics, use available_action? instead of action_method?. | José Valim | 2011-05-06 | 1 | -2/+2 |
| | |||||
* | Added missing </tt> | Oge Nnadi | 2011-04-11 | 1 | -1/+1 |
| | |||||
* | Pass the proper method_name instead of hardcoding to action_name. | José Valim | 2011-03-29 | 1 | -1/+1 |
| | | | | | | Conflicts: actionpack/lib/action_controller/metal/implicit_render.rb | ||||
* | Fix filter :only and :except with implicit actions | Andrew White | 2011-03-23 | 1 | -1/+1 |
| | | | | | | | The method_name argument is "default_render" for implicit actions so use the action_name attribute to determine which callbacks to run. [#5673 state:resolved] | ||||
* | process_action accepts multiple args, even with Callbacks. | Nick Sutterer | 2010-12-29 | 1 | -1/+1 |
| | |||||
* | Remove inline comment. | José Valim | 2010-11-11 | 1 | -17/+17 |
| | |||||
* | Make after_filter halt when before_filter renders or redirects [#5648 ↵ | Marcelo Giorgi | 2010-11-11 | 1 | -0/+2 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | change rdoc to conform to api guidelines | Joost Baaij | 2010-08-25 | 1 | -23/+22 |
| | |||||
* | Minor typo fix in callbacks.rb of abstract_controller | Rohit Arondekar | 2010-05-20 | 1 | -1/+1 |
| | |||||
* | Callbacks, DeprecatedCallbacks = NewCallbacks, Callbacks | Joshua Peek | 2009-10-12 | 1 | -5/+3 |
| | |||||
* | Use "run_callbacks :foo" since it is the public api for callbacks [#3329 | Joshua Peek | 2009-10-12 | 1 | -1/+1 |
| | | | | state:resolved] | ||||
* | Fix callbacks on ActionPack. | José Valim | 2009-09-08 | 1 | -1/+1 |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | ||||
* | Move AbstractController to a top-level component | Yehuda Katz | 2009-08-06 | 1 | -0/+115 |