aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Fix improperly configured host in generated urlsschneems2013-03-191-0/+6
| | | | | | | | | | | | | | | | | | | If the host in `default_url_options` is accidentally set with a protocol such as ``` host: "http://example.com" ``` then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention. This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host. I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted. This is based off of work in #7415 cc/ @pixeltrix ATP Action Mailer and Action Pack
* Digest auth should not 500 when given a basic header.Brad Dunbar2013-03-181-0/+5
|
* Include I18n fallbacks in :locale lookup contextJuan Barreneche2013-03-161-0/+5
|
* `Http::Headers` directly modifies the passed environment.Yves Senn2013-03-151-2/+6
| | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700.
* allow headers and env to be passed in `IntegrationTest`.Yves Senn2013-03-131-0/+11
| | | | Closes #6513.
* Http::Headers respects headers that are not prefixed with HTTP_Yves Senn2013-03-131-0/+4
|
* Use "Fixes" in place of "Fix" in changelogs for consistency [ci skip].Yves Senn2013-03-091-11/+11
|
* Fix incorrectly appended square brackets to a multiple select boxOlek Janiszewski2013-03-081-0/+15
| | | | | | | | | | | | | | If an explicit name has been given and it already ends with "[]" Before: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][][]" ...> After: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][]" ...>
* Move AP changelog entry to the top [ci skip]Carlos Antonio da Silva2013-03-071-6/+6
|
* Allow use of assert_template with the :file option.Justin Coyne2013-03-011-0/+6
| | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1
* Improve the CHANGELOG entryRafael Mendonça França2013-02-281-2/+6
| | | | [ci skip]
* Merge pull request #9366 from killthekitten/fix-content_for-regressionRafael Mendonça França2013-02-281-0/+2
|\ | | | | Fix for #9360 content_for regression
| * Fix #9360 regression in content_forNikolay Shebanov2013-02-251-0/+2
| |
* | Minor changelog improvement [ci skip]Carlos Antonio da Silva2013-02-281-1/+1
| |
* | `format: true` does not override existing format constraints.Yves Senn2013-02-271-0/+10
| | | | | | | | | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present.
* | allow non-String default params in the router.Yves Senn2013-02-261-0/+10
| | | | | | | | | | | | | | Closes #9435. Skip valid encoding checks for non-String parameters that come from the matched route's defaults.
* | the router allows String contraints.Yves Senn2013-02-261-1/+9
| | | | | | | | Closes #9432.
* | Move the CHANGELOG entry to the proper placeRafael Mendonça França2013-02-261-2/+4
| | | | | | | | [ci skip]
* | Merge pull request #9434 from zires/devRafael Mendonça França2013-02-261-0/+2
|\ \ | | | | | | Journey::Path::Pattern#new raise more meaningful exception message.
| * | Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful ↵zires2013-02-271-0/+2
| | | | | | | | | | | | exception message.
* | | Update CHANGELOGSRafael Mendonça França2013-02-261-0/+3
|/ /
* | Preparing for 4.0.0.beta1 releaseDavid Heinemeier Hansson2013-02-251-1/+1
| |
* | fix respond_to without blocks not working if one of the blocks is allgrosser2013-02-241-0/+2
| |
* | registers the encrypted session store in the AP changelogXavier Noria2013-02-231-0/+4
| |
* | Changelog improvements, use 1.9 style hash in examples [ci skip]Carlos Antonio da Silva2013-02-221-1/+1
| |
* | completes pass over the AP changelog [ci skip]Xavier Noria2013-02-211-14/+5
| |
* | tweaks to the AP changelog [ci skip]Xavier Noria2013-02-211-9/+3
| |
* | Merge pull request #9361 from senny/improved_match_shorthand_syntaxAndrew White2013-02-211-0/+14
|\ \ | | | | | | determine the match shorthand target early.
| * | determine the match shorthand target early.Yves Senn2013-02-211-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes.
* | | Revert "Revert "Merge pull request #4803 from lucascaton/master""Santiago Pastorino2013-02-211-0/+2
| |/ |/| | | | | This reverts commit 6871bd9818a9a7d9d8c7e21e253d64c0410fde1d.
* | Remove not necessary changelog about time zone array mutationCarlos Antonio da Silva2013-02-211-8/+0
| | | | | | | | | | | | | | | | This seemed to be introduced in master by 9dd64f2e0c1b3ce85b503b0f81c50c93f89ffbcd, so there's no need to add a changelog entry for fixing it. [ci skip]
* | tweaks to the AP changelog [ci skip]Xavier Noria2013-02-211-42/+27
|/
* Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-2/+0
| | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-201-3/+8
| | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-0/+8
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* moves a CHANGELOG entry from AR to APXavier Noria2013-02-191-0/+4
|
* Add message when you have no routes defined.Steve Klabnik2013-02-181-0/+6
| | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic.
* Improve changelog entry from #9221 [ci skip]Carlos Antonio da Silva2013-02-111-15/+13
|
* Improve img alt attribute for screen readersthenickcox2013-02-091-0/+21
| | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* Update actionpack/CHANGELOG.mdRafael Mendonça França2013-02-061-4/+4
| | | [ci skip]
* ruby constant syntax is not supported as routing `:controller` option.Yves Senn2013-02-061-0/+13
| | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide.
* partials inside directory work with `assert_template`Yves Senn2013-02-041-1/+13
| | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* Fix markdown syntax in actionpack CHANGELOG.Steve Klabnik2013-02-011-1/+2
| | | | Starting a line with an octothorpe makes an <h1>
* Fix `content_tag_for` with array html option.Semyon Perepelitsa2013-01-311-0/+18
| | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>'
* Changelog about BestStandardsSupport removalGuillermo Iguaran2013-01-291-5/+6
|
* s/ERb/ERB/Akira Matsuda2013-01-291-1/+1
|
* Move AS changelog entry to the top, improve AP changelog a bitCarlos Antonio da Silva2013-01-281-4/+4
| | | | [ci skip]
* Added a Changelog entry for fixing HEAD requests.Michiel Sikkes2013-01-281-0/+5
|
* Update actionpack's CHANGELOG for 445f14ePiotr Sarnacki2013-01-211-0/+5
|
* In Browser Path Matching with Javascriptschneems2013-01-201-0/+5
| | | | | | | | | | | When debugging routes ,it can sometimes be difficult to understand exactly how the paths are matched. This PR adds a JS based path matching widget to the `/rails/info/routes` output. You can enter in a path, and it will tell you which of the routes that path matches, while preserving order (top match wins). The matching widget in action: ![](http://f.cl.ly/items/3A2F0v2m3m1Z1p3P3O3k/path-match.gif) Prior to this PR the only way to check matching paths is via mental math, or typing in a path in the url bar and seeing where it goes. This feature will be an invaluable debugging tool by dramatically decreasing the time needed to check a path match. ATP actionpack