aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Merge pull request #28835 from fphilipe/masterRafael França2017-05-021-0/+1
| |\ \ | | | | | | | | Add missing require in ActionMailer::Base
| | * | Add missing require in ActionMailerPhilipe Fatio2017-05-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, Action Mailer doesn't work like it used to on version 4. The following snippet fails since version 5: > require 'action_mailer' > ActionMailer::Base NameError: uninitialized constant ActiveSupport::Rescuable
* | | | Avoid stubing on this testRafael Mendonça França2017-04-271-3/+2
|/ / / | | | | | | | | | | | | This will avoid to the test fail when running in isolation because the message generated is nil.
* | | Merge pull request #28244 from ixti/improve/action-mailer-preview-paramsRafael França2017-04-262-2/+24
|\ \ \ | |/ / |/| | Pass request params to ActionMailer::Preview
| * | Pass request params to ActionMailer::PreviewAlexey Zapparov2017-03-012-2/+24
| | |
* | | Remove duplicated `delivery_method` definitionyuuji.yaginuma2017-04-071-1/+0
| | | | | | | | | | | | | | | `ActionMailer::Base.delivery_method` is already defined in https://github.com/rails/rails/blob/master/actionmailer/test/parameterized_test.rb#L13
* | | Start Rails 5.2 developmentMatthew Draper2017-03-222-35/+3
| | |
* | | Use better duration aliases in testsAndrew White2017-03-151-2/+2
| | |
* | | Don't cast to float unnecessarilyAndrew White2017-03-151-2/+2
| | | | | | | | | | | | Adding durations to `Time` instances is perfectly okay.
* | | Document using `default_url_options` in an ActionMailer class.Krzysztof Zych2017-03-081-0/+3
| | |
* | | Deprecate implicit coercion of `ActiveSupport::Duration`Andrew White2017-03-021-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ActiveSupport::Duration` implicitly converts to a seconds value when used in a calculation except for the explicit examples of addition and subtraction where the duration is the receiver, e.g: >> 2 * 1.day => 172800 This results in lots of confusion especially when using durations with dates because adding/subtracting a value from a date treats integers as a day and not a second, e.g: >> Date.today => Wed, 01 Mar 2017 >> Date.today + 2 * 1.day => Mon, 10 Apr 2490 To fix this we're implementing `coerce` so that we can provide a deprecation warning with the intent of removing the implicit coercion in Rails 5.2, e.g: >> 2 * 1.day DEPRECATION WARNING: Implicit coercion of ActiveSupport::Duration to a Numeric is deprecated and will raise a TypeError in Rails 5.2. => 172800 In Rails 5.2 it will raise `TypeError`, e.g: >> 2 * 1.day TypeError: ActiveSupport::Duration can't be coerced into Integer This is the same behavior as with other types in Ruby, e.g: >> 2 * "foo" TypeError: String can't be coerced into Integer >> "foo" * 2 => "foofoo" As part of this deprecation add `*` and `/` methods to `AS::Duration` so that calculations that keep the duration as the receiver work correctly whether the final receiver is a `Date` or `Time`, e.g: >> Date.today => Wed, 01 Mar 2017 >> Date.today + 1.day * 2 => Fri, 03 Mar 2017 Fixes #27457.
* | Preparing for 5.1.0.beta1 releaseRafael Mendonça França2017-02-232-1/+3
| |
* | Add backticks around constantJon Moss2017-02-211-1/+1
| | | | | | | | [ci skip]
* | Freeze fragment cache related instrument name.Stan Lo2017-02-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | ActionMailer::Base#instrument_name and ActionController::Base#instrument_name will be frequently called once caching is enabled. So it's better to freeze them instead of create new string on every call. Also, the instrument name in #instrument_fragment_cache will usually be "write_fragment.action_controller" or "read_fragment.action_controller". So freezing them might also gain some performance improvement. We have done something like this in other places: https://github.com/rails/rails/blob/master/actionview/lib/action_view/template.rb#L348
* | Add `:args` to `process.action_mailer` eventyuuji.yaginuma2017-02-043-1/+25
| |
* | Don't mutate raw_source in mailer preview interceptorEugene Kenny2017-01-301-5/+1
| | | | | | | | | | | | | | | | The raw_source method is documented as returning the exact value that was used to create the body; mutating it breaks that contract. Additionally, if the value used to create the body is blank, raw_source returns a frozen string which causes the interceptor to raise an error.
* | add default value to `deliver_later_queue_name` option [ci skip]yuuji.yaginuma2017-01-311-1/+1
| |
* | Document with with an example an link to ParameterizedRafael Mendonça França2017-01-301-1/+6
| | | | | | | | | | Also change the class_methods to ClassMethods since the former document the method as an instance method of Parameterized not as a class method.
* | :scissors:Rafael Mendonça França2017-01-301-1/+1
| |
* | No need to advertise in the rdoc documentationRafael Mendonça França2017-01-301-3/+0
| |
* | Avoid should in test namesRafael Mendonça França2017-01-301-1/+1
| |
* | Implement respond_to_missing? in the Parameterized::Mailer classRafael Mendonça França2017-01-302-6/+25
| |
* | Remove unneeded nodocRafael Mendonça França2017-01-301-1/+1
| |
* | Override the initializers instead of using tapRafael Mendonça França2017-01-301-3/+6
| | | | | | | | We own the class so we can override the initialize.
* | Make internal classes internal for the documentationRafael Mendonça França2017-01-301-2/+2
| |
* | Make assert_enqueued_emails + assert_no_enqueued_emails consider ↵David Heinemeier Hansson2017-01-302-2/+20
| | | | | | | | | | | | parameterized delivery jobs Needed for testing of parameterized mailers
* | [ci skip] other -> order; expand ivarKasper Timm Hansen2017-01-281-1/+2
| |
* | restore `delivery_method` after testyuuji.yaginuma2017-01-291-4/+1
| | | | | | | | | | Currently use two variables to restore `delivery_method`, but the order of restoring the values is incorrect and does not restore is correctly.
* | Offer the option to use parameterization for shared processing of headers ↵David Heinemeier Hansson2017-01-286-7/+212
| | | | | | | | | | and ivars (#27825) Offer the option to use parameterization for shared processing of headers and ivars
* | Don't pollute Object with rubinius_skip and jruby_skipAkira Matsuda2017-01-171-9/+9
| | | | | | | | we call them only in the tests
* | ZOMG worst typo in my life :scream:Akira Matsuda2017-01-151-1/+1
| |
* | `respond_to_missing?` should fallback to `super` where method_missing could ↵Akira Matsuda2017-01-151-1/+1
| | | | | | | | call `super`
* | Reduce string objects by using \ instead of + or << for concatenating stringsAkira Matsuda2017-01-122-7/+7
| | | | | | | | (I personally prefer writing one string in one line no matter how long it is, though)
* | Use Encoding::UTF_8 constant for default_{internal,external} in the testsAkira Matsuda2017-01-111-2/+2
| |
* | Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail-bodyRafael Mendonça França2017-01-063-4/+38
|\ \ | | | | | | | | | Allow to custom content type when setting mailer body
| * | Remove unnecessary condition in content_typeMQuy2017-01-061-1/+1
| | |
| * | Add document in mailerMQuy2016-12-061-0/+13
| | |
| * | Fix wrong typo in testMQuy2016-12-051-1/+1
| | |
| * | Add changelog for custom content typeMQuy2016-12-011-0/+12
| | |
| * | allow context type when set body mailMQuy2016-11-302-4/+13
| | |
* | | `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-054-4/+4
| | | | | | | | | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* | | Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* | | Merge pull request #27550 from ↵Rafael França2017-01-031-1/+1
|\ \ \ | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * | | Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | | | Remove unneeded Deprecation.silenceRafael Mendonça França2017-01-031-3/+1
|/ / /
* | | Bump license years for 2017Jon Moss2016-12-312-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* | | Privatize unneededly protected methods in Action MailerAkira Matsuda2016-12-244-27/+20
| | |
* | | No need to nodoc private methodAkira Matsuda2016-12-241-1/+1
| | |
* | | Privatize unneededly protected methods in Action Mailer testsAkira Matsuda2016-12-243-3/+3
|/ /
* | update bin/test scripts to prevent double runs.Yves Senn2016-11-211-2/+0
| | | | | | | | | | The test runner was updated to make use of autorun. This caused the `bin/test` scripts to run Minitest twice.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 07:07:32 +0000