aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer
Commit message (Collapse)AuthorAgeFilesLines
* prefer __dir__ over __FILE__ in File.expand_pathXavier Noria2016-08-111-1/+3
| | | | | | Thinking .. relative to files is not natural, we are used to think "parent of a directory", and we have __dir__ nowadays.
* revises more Lint/EndAlignment offensesXavier Noria2016-08-081-3/+3
|
* code gardening: removes redundant selfsXavier Noria2016-08-081-2/+2
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* Modify LogSubscriber for single partial's cache message.Stan Lo2016-08-081-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-064-7/+5
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-068-122/+122
|
* applies new string literal convention to the rest of the projectXavier Noria2016-08-061-3/+3
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in the gemspecsXavier Noria2016-08-061-17/+17
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actionmailer/testXavier Noria2016-08-0617-257/+257
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actionmailer/libXavier Noria2016-08-0615-47/+47
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* remove `-t` option from default sendmail arguments [ci skip]yuuji.yaginuma2016-07-062-2/+2
| | | | Follow up to #24436
* Do not suggest nonsensical OpenSSL verify modes [ci skip]Jonne Haß2016-06-071-3/+2
| | | | | | | | | | | | | | | | | | | | | | | SSL_set_verify(3) explains: SSL_VERIFY_FAIL_IF_NO_PEER_CERT Server mode: if the client did not return a certificate, the TLS/SSL handshake is immediately terminated with a "handshake failure" alert. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored SSL_VERIFY_CLIENT_ONCE Server mode: only request a client certificate on the initial TLS/SSL handshake. Do not ask for a client certificate again in case of a renegotiation. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored The SMTP connection here uses a OpenSSL socket in client mode, suggesting invalid/ignored flags is rather misleading.
* fix grammarRajat Bansal2016-05-311-1/+1
|
* Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* Action Mailer: Declarative exception handling with `rescue_from`.Jeremy Daer2016-05-157-23/+161
| | | | | | | | | | | | | | | | | | | | | | | Follows the same pattern as controllers and jobs. Exceptions raised in delivery jobs (enqueued by `#deliver_later`) are also delegated to the mailer's rescue_from handlers, so you can handle the DeserializationError raised by delivery jobs: ```ruby class MyMailer < ApplicationMailer rescue_from ActiveJob::DeserializationError do … end ``` ActiveSupport::Rescuable polish: * Add the `rescue_with_handler` class method so exceptions may be handled at the class level without requiring an instance. * Rationalize `exception.cause` handling. If no handler matches the exception, fall back to the handler that matches its cause. * Handle exceptions raised elsewhere. Pass `object: …` to execute the `rescue_from` handler (e.g. a method call or a block to instance_exec) against a different object. Defaults to `self`.
* Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-102-142/+3
|
* Update rails-dom-testing gem to 2.0Connor Shea2016-05-091-1/+1
| | | | Resolves #24924.
* Add :ssl/:tls to ActionMailer [ci skip]Pedro Adame Vergara2016-05-091-0/+1
|
* Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-062-1/+6
|
* Merge pull request #24589 from vipulnsward/am-fragment-cacheRafael França2016-05-055-3/+62
|\ | | | | Expand on Action Mailer Fragment caching tests
| * Expand on Action Mailer Fragment caching testsVipul A M2016-04-175-3/+62
| |
* | Prep Rails 5 beta 4eileencodes2016-04-272-1/+3
| |
* | Clear ActionMailer deliveries on setup and teardownarktisklada2016-04-252-1/+42
| | | | | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Small typo on a method name:Edouard CHIN2016-04-151-2/+2
|/ | | | - clear_test_deliviers -> clear_test_deliveries
* Merge pull request #24525 from tomkadwill/action-mailer-base-docs2Vipul A M2016-04-141-3/+3
|\ | | | | Update ActionMailer base documentation [ci skip]
| * Update ActionMailer base documentation [ci skip]Tom Kadwill2016-04-131-3/+3
| |
* | Merge pull request #24497 from vipulnsward/am-changelog-passYves Senn2016-04-111-4/+3
|\ \ | | | | | | Pass over AM changelog [ci skip]
| * | Pass over AM changelogVipul A M2016-04-101-4/+3
| |/ | | | | | | | | | | | | | | - Fixed statement about setting `config.action_mailer.default_url_options = {protocol: 'https'}` . We are just setting the protocol key to 'https', not replacing/initializing the complete config. - Fixed grammar in assert_emails changlog - Added sentence separator for code ":" [ci skip]
* / Update ActionMailer Views documentation [ci skip]Tom Kadwill2016-04-101-1/+1
|/
* Merge pull request #24457 from ↵Jeremy Daer2016-04-083-2/+40
|\ | | | | | | | | jeremy/mailer/dont-deliver-later-after-message-is-loaded Disallow calling `#deliver_later` after local message modifications.
| * Disallow calling `#deliver_later` after local message modifications.Jeremy Daer2016-04-073-2/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They would be lost when the delivery job is enqueued, otherwise. Prevents a common, hard-to-find bug like: ```ruby message = Notifier.welcome(user, foo) message.message_id = my_generated_message_id message.deliver_later ``` The message_id is silently lost here! *Only the mailer arguments are passed to the delivery job.* This raises an exception now. Make modifications to the message within the mailer method or use a custom Active Job to manage delivery instead of using #deliver_later.
* | remove blank line generated in application_mailer.rbyuuji.yaginuma2016-04-081-1/+1
|/
* Sendmail default arguments match Mail::SendMailarktisklada2016-04-053-2/+8
| | | | Removes `-t`
* Suppress warningsyui-knk2016-03-312-6/+12
| | | | | "Using a dynamic :controller (or :action) segment in a route is deprecated" by 6520ea5f7e2215a763ca74bf6cfa87be2347d5df (#23980).
* Pass over CHANGELOGs [ci skip]Prathamesh Sonpatki2016-03-301-3/+1
|
* Merge pull request #24164 from prathamesh-sonpatki/fix-application-mailerRafael França2016-03-232-2/+13
|\ | | | | Correctly generate application_mailer.rb in mountable engines
| * Correctly generate application_mailer.rb in mountable enginesPrathamesh Sonpatki2016-03-122-2/+13
| | | | | | | | - Followup of https://github.com/rails/rails/pull/24161.
* | Fix generator test to match to use the stringRafael Mendonça França2016-03-211-1/+1
| |
* | switched layout :mailer to a string so that mail layout can be properly ↵Matt Hall2016-03-171-1/+1
|/ | | | found and mail can be delivered properly
* improve some codeSen-Zhang2016-03-111-2/+4
|
* generate application_mailer.rb if it is missingSen-Zhang2016-03-112-0/+8
|
* Remove redundant regexp escapes in generatorsGadzhi Gadzhiev2016-03-081-1/+1
|
* Prevent not-intended loading of `ActionDispatch::IntegrationTest`yui-knk2016-03-071-2/+2
| | | | | | | | | | After 9d378747326d26cf1afdac4433ead22967af0984 `ActionDispatch::IntegrationTest` class is loaded and defined in all Rails environments, not only test but also production. This is not-intended loading of a class which is only used in test environment. To prevent not-intended loading, add `ActiveSupport.run_load_hooks` to `ActionDispatch::IntegrationTest` with `action_dispatch_integration_test` name and use it in `ActionMailer`.
* Update base.rbSarah A2016-03-031-1/+1
|
* Change 'a HTML' to 'an HTML' [ci skip]Santosh Wadghule2016-03-031-1/+1
|
* Remove load_paths fileArthur Neves2016-02-271-1/+0
|
* Preparing for 5.0.0.beta3 releaseeileencodes2016-02-241-0/+2
| | | | Adds changelog headers for beta3 release
* Prep release for Rails 5 beta3eileencodes2016-02-241-1/+1
|
* Add changelog entry for #22825Rafael Mendonça França2016-02-241-0/+6
|