| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* ignore mailer suffix when generate test files
* add mailer suffix to view files
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
onwards.
|
| | | |
| | | |
| | | |
| | | | |
ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
|
| |_|/
|/| | |
|
|\ \ \
| | | |
| | | | |
Correct the views that the mail method sends in API docs.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In order to run whether the `welcome` method of the ActionMailer::Base
subclass raises an error, `message` must be called, otherwise the method
is not executed at all.
You could just replace with `def welcome; raise StandardError; end` and you
would still see a passing test.
This commit fixes the test so the assertion is actually executed, just like
any other tests in the file, where `.message` is called.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For mailers created via generators
Follow up to #18074
|
| |/ /
|/| | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Following the same naming convention used in
controllers and jobs.
|
| | |
| | |
| | |
| | | |
These requires were added only to change deprecation message
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
These methods were deprecated in Rails 4.2 (see f4ee1147) so they can
be safely removed in Rails 5.0.
|
|\ \ \
| | | |
| | | | |
Update copyright notices to 2015 [ci skip]
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Given the following templates:
mailer/demo.html.erb
mailer/demo.en.html.erb
mailer/demo.pt.html.erb
Before this change for a locale that doesn't have its related file
the `mailer/demo.html.erb` will
be rendered even if `en` is the default locale.
Now `mailer/demo.en.html.erb` has precedence over the file without
locale.
Also, it is possible to give a fallback.
mailer/demo.pt.html.erb
mailer/demo.pt-BR.html.erb
So if the locale is `pt-PT`, `mailer/demo.pt.html.erb` will be
rendered given the right I18n fallback configuration.
Fixes #11884.
|
| | |
| | |
| | |
| | |
| | | |
Stems from [this comment](https://github.com/rails/rails/pull/18203#issuecomment-68138096) by @robin850
and by the blog post http://weblog.rubyonrails.org/2014/12/19/Rails-4-2-final
|
|\ \ \
| |_|/
|/| |
| | | |
fix typo in nodoc [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
fixing mailer previews for apps with globbing route
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Don't remove mailer layouts files
|
| | | |
|
| | |
| | |
| | | |
Just a little syntax error I spotted by accident. Cannot pass hash with curly braces without normal parentheses.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
[This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that:
> Rails 5.0 is in most likelihood going to target Ruby 2.2.
Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383)
that **at least** version 2.1.0 **must** be required by the `gemspec` files.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We will support only Ruby >= 2.1.
But right now we don't accept pull requests with syntax changes to drop
support to Ruby 1.9.
|
| | |
| | |
| | | |
[skip ci]
|
| | | |
|
|/ /
| |
| | |
[skip ci]
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Creating mailer layouts by default, including html and body tags
|
| | | |
|
| | |
| | |
| | |
| | | |
tags to reduce spam score
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| | |
- Wrapped text in setting defaults section. Also added break, to a sentence.
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch uniformizes warning messages. I used the most common style
already present in the code base:
* Capitalize the first word.
* End the message with a full stop.
* "Rails 5" instead of "Rails 5.0".
* Backticks for method names and inline code.
Also, converted a few long strings into the new heredoc convention.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The current style for warning messages without newlines uses
concatenation of string literals with manual trailing spaces
where needed.
Heredocs have better readability, and with `squish` we can still
produce a single line.
This is a similar use case to the one that motivated defining
`strip_heredoc`, heredocs are super clean.
|
| | |
|
| | |
|