Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #17896 from GBH/globbing_route_mailer_preview | Rafael Mendonça França | 2014-12-08 | 1 | -1/+1 |
|\ | | | | | fixing mailer previews for apps with globbing route | ||||
| * | fixing mailer previews for apps with globbing route | Oleg | 2014-12-03 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #17797 from y-yagi/donot_delete_mailer_layouts | Rafael Mendonça França | 2014-12-04 | 1 | -1/+3 |
|\ \ | |/ |/| | Don't remove mailer layouts files | ||||
| * | Don't remove mailer layouts files | yuuji.yaginuma | 2014-11-27 | 1 | -1/+3 |
| | | |||||
* | | Fix documentation for #default | Sven Pachnit | 2014-12-01 | 1 | -1/+1 |
| | | | | | | Just a little syntax error I spotted by accident. Cannot pass hash with curly braces without normal parentheses. | ||||
* | | [ci skip] fix description of url_for | yuuji.yaginuma | 2014-11-30 | 1 | -5/+0 |
| | | |||||
* | | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -2/+2 |
| | | |||||
* | | Start Rails 5 development :tada: | Rafael Mendonça França | 2014-11-28 | 1 | -3/+3 |
|/ | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9. | ||||
* | Update docs to reflect changes to MailerGenerator. | Guo Xiang Tan | 2014-11-25 | 1 | -11/+17 |
| | |||||
* | Removing unnecessary File.join calls | Andy Jeffries | 2014-11-24 | 1 | -1/+1 |
| | |||||
* | Creates an ApplicationMailer and layout by default, including html and body ↵ | Andy Jeffries | 2014-11-21 | 3 | -2/+6 |
| | | | | tags to reduce spam score | ||||
* | Prepare for 4.2.0.beta4 release | Godfrey Chan | 2014-10-30 | 1 | -1/+1 |
| | |||||
* | edit pass over all warnings | Xavier Noria | 2014-10-28 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention. | ||||
* | let's warn with heredocs | Xavier Noria | 2014-10-28 | 1 | -4/+13 |
| | | | | | | | | | | | | The current style for warning messages without newlines uses concatenation of string literals with manual trailing spaces where needed. Heredocs have better readability, and with `squish` we can still produce a single line. This is a similar use case to the one that motivated defining `strip_heredoc`, heredocs are super clean. | ||||
* | Making the actionmailer docs more explicit to understand [ci skip] | Rishi Jain | 2014-10-26 | 2 | -3/+6 |
| | |||||
* | [ci skip] add :queue option to deliver_later and deliver_later! documentation | yuuji.yaginuma | 2014-10-19 | 1 | -0/+2 |
| | |||||
* | [ci skip] Fix word wrap, capitalization, and spacing of text from #17284 | Zachary Scott | 2014-10-18 | 1 | -4/+5 |
| | |||||
* | [ci skip] Add a note about headers overwriting | Nicolas Cavigneaux | 2014-10-18 | 1 | -5/+21 |
| | | | | | | | | | Since some headers can appear multiple times in an email it's required to set it to nil first when you want to overwrite an existing one. This commit add some information about this process. Fix #15912 | ||||
* | Only include the needed assertions | Rafael Mendonça França | 2014-10-07 | 1 | -1/+2 |
| | |||||
* | fix tests on action_mailer | schneems | 2014-10-07 | 1 | -1/+1 |
| | | | Include appropriate helpers and use `assert_dom_equal` where applicable | ||||
* | Preparing for 4.2.0.beta2 release | Rafael Mendonça França | 2014-09-26 | 1 | -1/+1 |
| | |||||
* | Allow attaching files while the mail view is rendered | Christian Felder (masone) | 2014-09-22 | 2 | -2/+3 |
| | |||||
* | Rename remaining :in / :at to :wait / :wait_until | Cristian Bica | 2014-09-04 | 1 | -12/+9 |
| | |||||
* | Active Job refactoring | Cristian Bica | 2014-09-03 | 1 | -9/+4 |
| | |||||
* | [ci skip] Fix a typo in the doc of MessageDelivery | yuuji.yaginuma | 2014-09-02 | 1 | -3/+3 |
| | |||||
* | Refer to the library name instead of the constant | Robin Dupret | 2014-08-30 | 1 | -1/+1 |
| | | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria] | ||||
* | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2014-08-29 | 5 | -30/+109 |
|\ | |||||
| * | Merge pull request #16598 from seuros/master | Matthew Draper | 2014-08-23 | 1 | -0/+1 |
| |\ | | | | | | | [ActionMailer] require activejob railtie | ||||
| | * | [ActionMailer] require activejob railtie | Abdelkader Boudih | 2014-08-22 | 1 | -0/+1 |
| | | | |||||
| * | | applies API guidelines to new AM docs | Xavier Noria | 2014-08-21 | 2 | -32/+32 |
| |/ | |||||
| * | [Rdoc] Make clear that we are sending an AR object [ci skip] | Abdelkader Boudih | 2014-08-20 | 2 | -16/+16 |
| | | |||||
| * | Fix typo in rdoc [ci skip] | Abdelkader Boudih | 2014-08-20 | 2 | -16/+16 |
| | | |||||
| * | Updated rdoc / guides / release notes related to ActiveJob / ActionMailer | Cristian Bica | 2014-08-20 | 4 | -34/+92 |
| | | |||||
| * | Deprecated .deliver / .deliver! to .deliver_now / .deliver_now! | Cristian Bica | 2014-08-20 | 1 | -2/+22 |
| | | |||||
* | | Preparing for 4.2.0.beta1 release | David Heinemeier Hansson | 2014-08-19 | 1 | -1/+1 |
|/ | |||||
* | Add `set_delivery_method` and `restore_delivery_method` to ↵ | Lucas Mazza | 2014-08-19 | 1 | -0/+9 |
| | | | | | | | | `ActionMailer::TestCase`. This way these methods are available outside the ActionMailer test suite, but they are still duplicated inside `test/abstract_unit` for test cases that don't inherit from the `ActionMailer::TestCase` class. | ||||
* | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-17 | 5 | -2/+66 |
|\ | | | | | | | | | Conflicts: actionpack/CHANGELOG.md | ||||
| * | [ActionMailer] Rename ActionMailer::DelayedDeliveryJob to ↵ | Abdelkader Boudih | 2014-08-17 | 3 | -4/+6 |
| | | | | | | | | ActionMailer::DeliveryJob | ||||
| * | Fixed indentation | Cristian Bica | 2014-08-16 | 1 | -1/+1 |
| | | |||||
| * | Removed method missing from ActionMailer::MessageDelivery | Cristian Bica | 2014-08-15 | 2 | -4/+4 |
| | | |||||
| * | Refactor DeliverLater into MessageDelivery | Abdelkader Boudih | 2014-08-14 | 7 | -73/+62 |
| | | |||||
| * | Make ActionMailer::Previews methods class methods. | Abdelkader Boudih | 2014-08-14 | 1 | -0/+2 |
| | | |||||
| * | Added ActionMailer::DeliverLater | Abdelkader Boudih | 2014-08-13 | 5 | -1/+72 |
| | | |||||
* | | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-12 | 3 | -14/+36 |
|\| | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md | ||||
| * | Deprecate `*_path` methods in mailers | @schneems and @sgrif | 2014-07-30 | 2 | -1/+6 |
| | | | | | | | | | | | | | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems | ||||
| * | Raise an exception when attachments are added after `mail` was called. | Yves Senn | 2014-07-29 | 1 | -1/+16 |
| | | | | | | | | | | | | | | | | | | Closes #16163 Adding attachments after a call to `mail` will result in invalid emails. This is related to the fact, that `mail` is making the required preparations before the email is ready to be sent. These change depending on your added attachments. | ||||
| * | Prefer to pass block when logging. | Guo Xiang Tan | 2014-07-18 | 1 | -11/+13 |
| | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance. | ||||
| * | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip] | Santosh Wadghule | 2014-07-14 | 1 | -1/+1 |
| | | |||||
* | | Include the selector assertions on the test case | Rafael Mendonça França | 2014-07-15 | 1 | -0/+2 |
| | | | | | | | | | | We don't need to require users to include this module on ActionMailer::TestCase | ||||
* | | Merge pull request #11218 from kaspth/loofah-integration | Rafael Mendonça França | 2014-07-10 | 1 | -3/+2 |
|\ \ | |/ |/| | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md |