aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Update ActionMailer Views documentation [ci skip]Tom Kadwill2016-04-101-1/+1
|/ /
* | Merge pull request #24457 from ↵Jeremy Daer2016-04-081-2/+14
|\ \ | | | | | | | | | | | | jeremy/mailer/dont-deliver-later-after-message-is-loaded Disallow calling `#deliver_later` after local message modifications.
| * | Disallow calling `#deliver_later` after local message modifications.Jeremy Daer2016-04-071-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They would be lost when the delivery job is enqueued, otherwise. Prevents a common, hard-to-find bug like: ```ruby message = Notifier.welcome(user, foo) message.message_id = my_generated_message_id message.deliver_later ``` The message_id is silently lost here! *Only the mailer arguments are passed to the delivery job.* This raises an exception now. Make modifications to the message within the mailer method or use a custom Active Job to manage delivery instead of using #deliver_later.
* | | remove blank line generated in application_mailer.rbyuuji.yaginuma2016-04-081-1/+1
|/ /
* | Sendmail default arguments match Mail::SendMailarktisklada2016-04-051-1/+1
| | | | | | | | Removes `-t`
* | Merge pull request #24164 from prathamesh-sonpatki/fix-application-mailerRafael França2016-03-232-2/+13
|\ \ | | | | | | Correctly generate application_mailer.rb in mountable engines
| * | Correctly generate application_mailer.rb in mountable enginesPrathamesh Sonpatki2016-03-122-2/+13
| | | | | | | | | | | | - Followup of https://github.com/rails/rails/pull/24161.
* | | Fix generator test to match to use the stringRafael Mendonça França2016-03-211-1/+1
| | |
* | | switched layout :mailer to a string so that mail layout can be properly ↵Matt Hall2016-03-171-1/+1
|/ / | | | | | | found and mail can be delivered properly
* | improve some codeSen-Zhang2016-03-111-2/+4
| |
* | generate application_mailer.rb if it is missingSen-Zhang2016-03-112-0/+8
| |
* | Remove redundant regexp escapes in generatorsGadzhi Gadzhiev2016-03-081-1/+1
| |
* | Prevent not-intended loading of `ActionDispatch::IntegrationTest`yui-knk2016-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | After 9d378747326d26cf1afdac4433ead22967af0984 `ActionDispatch::IntegrationTest` class is loaded and defined in all Rails environments, not only test but also production. This is not-intended loading of a class which is only used in test environment. To prevent not-intended loading, add `ActiveSupport.run_load_hooks` to `ActionDispatch::IntegrationTest` with `action_dispatch_integration_test` name and use it in `ActionMailer`.
* | Update base.rbSarah A2016-03-031-1/+1
| |
* | Change 'a HTML' to 'an HTML' [ci skip]Santosh Wadghule2016-03-031-1/+1
| |
* | Prep release for Rails 5 beta3eileencodes2016-02-241-1/+1
| |
* | Move private methods to the private visibilityRafael Mendonça França2016-02-241-12/+12
| |
* | Move Caching module to Abstract ControllerRafael Mendonça França2016-02-232-4/+1
| | | | | | | | | | | | Abstract Controller is the common component between Action Mailer and Action Controller so if we need to share the caching component it need to be there.
* | Change ActionMailer's default caching configuration and update generator's ↵Stan Lo2016-02-231-1/+1
| | | | | | | | environment templates
* | Move ActionMailer::Caching's content into ActionMailer::Base instead of ↵Stan Lo2016-02-232-23/+15
| | | | | | | | | | | | including it Remove useless helper in ActionDispatch::Caching and fix indentation
* | Make caching configuration more flexibleStan Lo2016-02-231-4/+7
| |
* | Move most caching methods to ActionDispatch::Caching, and let ActionMailer ↵Stan Lo2016-02-231-54/+3
| | | | | | | | and ActionController to include it
* | Move caching/fragments in ActionMailer and ActionController to ↵Stan Lo2016-02-232-153/+2
| | | | | | | | action_dispatch/caching/fragments
* | Porting ActionController::Caching to ActionMailer::CachingStan Lo2016-02-235-0/+224
| |
* | Prevent ActionMailer initializer from triggering load of ActionMailerDave Gynn2016-02-221-10/+12
| | | | | | | | | | | | | | | | the after_initialize block has been changed to use the configuration from `config.action_mailer` rather than `ActionMailer::Base` so that action mailer is not loaded before it is necessary. the mailer preview routes setup have been moved out of an `on_load(:action_mailer)` block.
* | Add `internal` attribute to routesJon Moss2016-02-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is meant to provide a way for Action Cable, Sprockets, and possibly other Rack applications to mark themselves as internal, and to exclude themselves from the routing inspector, and thus `rails routes` / `rake routes`. I think this is the only way to have mounted Rack apps be marked as internal, within AD/Journey. Another option would be to create an array of regexes for internal apps, and then to iterate over that everytime a request comes through. Also, I only had the first `add_route` method set `internal`'s default to false, to avoid littering it all over the codebase.
* | fix class name typo.Yves Senn2016-02-162-3/+3
| |
* | reset `ActionMailer::Base.deliveries` in `ActionDispatch::IntegrationTest`.Yves Senn2016-02-162-1/+18
| | | | | | | | | | | | | | | | | | Whenever you are sending emails in integration tests using the `:test` delivery method you need to make sure that `ActionMailer::Base.deliveries` is reset after every test. This piece of boilerplate code is present in all my applications that send emails. Let's have `ActionDispatch::IntegrationTest` reset the deliveries automatically.
* | Change x-gzip to gzip in docs [ci skip]Mehmet Emin İNAÇ2016-02-131-2/+2
| | | | | | | | For more information about GNU zip mime type please check IETF's web site [RFC6713](http://tools.ietf.org/html/rfc6713) or [IANA](http://www.iana.org/assignments/media-types/media-types.xhtml#application)
* | Revert "When generating a mailer, you must specify Mailer in the class name in"yuuji.yaginuma2016-02-062-2/+2
| | | | | | | | | | | | | | | | This reverts commit 8417d967e016f0219cc4ec30bf0d3908ce6cd29b. In 5697bdbb6da5d08e541a3b12251cec90269b059b and af3eb5961e55a46b011be797e71f615f20f56686, add mailer suffix to generated files and classes. Therefore, no longer need to specify `Mailer` to class name. [ci skip]
* | When generating a mailer, you must specify Mailer in the class name inAndrew Kaspick2016-02-052-2/+2
| | | | | | | | | | order to generate the proper files. Some of the docs/comments are missing this important detail.
* | Preparing for Rails 5.0.0.beta2Sean Griffin2016-02-011-1/+1
| |
* | Merge branch '5-0-beta-sec'Aaron Patterson2016-01-251-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password
| * | bumping versionAaron Patterson2016-01-251-1/+1
| | |
* | | Update copyright notice for 2016Guillermo Iguaran2016-01-011-1/+1
|/ /
* | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | :tada: :beers:
* | ApplicationMailer should be generated by default just like every other ↵David Heinemeier Hansson2015-12-172-7/+0
| | | | | | | | Application* parent
* | [ci skip] Fix grammar and sentence framingAkshay Vishnoi2015-12-171-6/+6
|/
* Make ActionMailer::Base.respond_to_missing? privateRyan Buckley2015-12-031-4/+6
|
* Replace ActionMailer::Base#respond_to? with respond_to_missing?Ryan Buckley2015-12-021-2/+2
|
* Move all nodoc methods to the private sectionRafael Mendonça França2015-11-241-43/+43
| | | | Since they are nodoc there is no need to be protected.
* Put all private method togetherRafael Mendonça França2015-11-241-36/+35
|
* Avoid mutating the headers hashRafael Mendonça França2015-11-241-2/+3
| | | | | We are already filtering the keys in the assign_headers_to_message method so we can just update the filter.
* nodoc in the private methodRafael Mendonça França2015-11-241-1/+1
|
* Merge pull request #22120 from hnatt/refactor-actionmailerRafael Mendonça França2015-11-241-55/+59
|\ | | | | | | Refactor ActionMailer::Base
| * Rename ActionMailer::Base#class_from_value -> observer_class_forhnatt2015-10-301-4/+4
| |
| * Don't mutate headers in ActionMailer::Base#collect_responses_from_templateshnatt2015-10-301-2/+2
| |
| * Pass message as argument to ActionMailer::Base#assign_headers_to_messagehnatt2015-10-301-4/+5
| |
| * Fix indentation in ActionMailer::Base#collect_responses_from_templateshnatt2015-10-291-5/+5
| |
| * Refactor out headers to message assignment from ActionMailer::Base#mailhnatt2015-10-291-3/+6
| |