Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Update Action Mailer doc [ci skip] | Yoshiyuki Hirano | 2017-08-30 | 3 | -8/+8 |
| | |||||
* | Use tt in doc for action_mailer [ci skip] | Yoshiyuki Hirano | 2017-08-26 | 1 | -1/+1 |
| | |||||
* | Merge pull request #29559 from kirs/eager-load-controller-actions | Rafael França | 2017-08-11 | 1 | -0/+6 |
|\ | | | | | Eager load controller actions to reduce response time of the first request | ||||
| * | Eager load controller and mailer actions | Kir Shatrov | 2017-07-29 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | | | | | | | On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77 | ||||
* | | Remove outdated comment [ci skip] | Youssef Boulkaid | 2017-08-06 | 1 | -4/+0 |
|/ | | | | | The comment was describing a previous version of the method with a different signature. This is outdated since e76c38e | ||||
* | Use frozen string literal in actionmailer/ | Kir Shatrov | 2017-07-23 | 16 | -0/+32 |
| | |||||
* | [Action Mailer] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -3/+3 |
| | |||||
* | Fix formatting of `ActionMailer::MessageDelivery` doc [ci skip] | Ryuta Kamizono | 2017-06-16 | 1 | -4/+4 |
| | |||||
* | Document setting the delivery_job for ActionMailer [ci skip] | Matthew Mongeau | 2017-06-16 | 1 | -0/+16 |
| | |||||
* | Allow mailers to configure their delivery job | Matthew Mongeau | 2017-06-15 | 2 | -1/+3 |
| | | | | | | | | | | | Setting delivery_job on a mailer class will cause MessageDelivery to use the specified job instead of ActionMailer::DeliveryJob: class MyMailer < ApplicationMailer self.delivery_job = MyCustomDeliveryJob ... end | ||||
* | Use mattr_accessor default: option throughout the project | Genadi Samokovarov | 2017-06-03 | 2 | -10/+4 |
| | |||||
* | Add option for class_attribute default (#29270) | David Heinemeier Hansson | 2017-05-29 | 2 | -6/+3 |
| | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation | ||||
* | Merge pull request #28244 from ixti/improve/action-mailer-preview-params | Rafael França | 2017-04-26 | 1 | -2/+8 |
|\ | | | | | Pass request params to ActionMailer::Preview | ||||
| * | Pass request params to ActionMailer::Preview | Alexey Zapparov | 2017-03-01 | 1 | -2/+8 |
| | | |||||
* | | Start Rails 5.2 development | Matthew Draper | 2017-03-22 | 1 | -2/+2 |
| | | |||||
* | | Document using `default_url_options` in an ActionMailer class. | Krzysztof Zych | 2017-03-08 | 1 | -0/+3 |
|/ | |||||
* | Preparing for 5.1.0.beta1 release | Rafael Mendonça França | 2017-02-23 | 1 | -1/+1 |
| | |||||
* | Freeze fragment cache related instrument name. | Stan Lo | 2017-02-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | ActionMailer::Base#instrument_name and ActionController::Base#instrument_name will be frequently called once caching is enabled. So it's better to freeze them instead of create new string on every call. Also, the instrument name in #instrument_fragment_cache will usually be "write_fragment.action_controller" or "read_fragment.action_controller". So freezing them might also gain some performance improvement. We have done something like this in other places: https://github.com/rails/rails/blob/master/actionview/lib/action_view/template.rb#L348 | ||||
* | Add `:args` to `process.action_mailer` event | yuuji.yaginuma | 2017-02-04 | 1 | -1/+2 |
| | |||||
* | Don't mutate raw_source in mailer preview interceptor | Eugene Kenny | 2017-01-30 | 1 | -5/+1 |
| | | | | | | | | The raw_source method is documented as returning the exact value that was used to create the body; mutating it breaks that contract. Additionally, if the value used to create the body is blank, raw_source returns a frozen string which causes the interceptor to raise an error. | ||||
* | add default value to `deliver_later_queue_name` option [ci skip] | yuuji.yaginuma | 2017-01-31 | 1 | -1/+1 |
| | |||||
* | Document with with an example an link to Parameterized | Rafael Mendonça França | 2017-01-30 | 1 | -1/+6 |
| | | | | | Also change the class_methods to ClassMethods since the former document the method as an instance method of Parameterized not as a class method. | ||||
* | :scissors: | Rafael Mendonça França | 2017-01-30 | 1 | -1/+1 |
| | |||||
* | No need to advertise in the rdoc documentation | Rafael Mendonça França | 2017-01-30 | 1 | -3/+0 |
| | |||||
* | Implement respond_to_missing? in the Parameterized::Mailer class | Rafael Mendonça França | 2017-01-30 | 1 | -6/+11 |
| | |||||
* | Remove unneeded nodoc | Rafael Mendonça França | 2017-01-30 | 1 | -1/+1 |
| | |||||
* | Override the initializers instead of using tap | Rafael Mendonça França | 2017-01-30 | 1 | -3/+6 |
| | | | | We own the class so we can override the initialize. | ||||
* | Make internal classes internal for the documentation | Rafael Mendonça França | 2017-01-30 | 1 | -2/+2 |
| | |||||
* | Make assert_enqueued_emails + assert_no_enqueued_emails consider ↵ | David Heinemeier Hansson | 2017-01-30 | 1 | -2/+2 |
| | | | | | | parameterized delivery jobs Needed for testing of parameterized mailers | ||||
* | [ci skip] other -> order; expand ivar | Kasper Timm Hansen | 2017-01-28 | 1 | -1/+2 |
| | |||||
* | Offer the option to use parameterization for shared processing of headers ↵ | David Heinemeier Hansson | 2017-01-28 | 2 | -7/+147 |
| | | | | | and ivars (#27825) Offer the option to use parameterization for shared processing of headers and ivars | ||||
* | ZOMG worst typo in my life :scream: | Akira Matsuda | 2017-01-15 | 1 | -1/+1 |
| | |||||
* | `respond_to_missing?` should fallback to `super` where method_missing could ↵ | Akira Matsuda | 2017-01-15 | 1 | -1/+1 |
| | | | | call `super` | ||||
* | Reduce string objects by using \ instead of + or << for concatenating strings | Akira Matsuda | 2017-01-12 | 1 | -2/+2 |
| | | | | (I personally prefer writing one string in one line no matter how long it is, though) | ||||
* | Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail-body | Rafael Mendonça França | 2017-01-06 | 1 | -4/+21 |
|\ | | | | | | | Allow to custom content type when setting mailer body | ||||
| * | Remove unnecessary condition in content_type | MQuy | 2017-01-06 | 1 | -1/+1 |
| | | |||||
| * | Add document in mailer | MQuy | 2016-12-06 | 1 | -0/+13 |
| | | |||||
| * | allow context type when set body mail | MQuy | 2016-11-30 | 1 | -4/+8 |
| | | |||||
* | | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 3 | -3/+3 |
| | | | | | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | | Privatize unneededly protected methods in Action Mailer | Akira Matsuda | 2016-12-24 | 3 | -24/+18 |
| | | |||||
* | | No need to nodoc private method | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
|/ | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 5 | -10/+10 |
| | |||||
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 1 | -15/+15 |
| | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | RuboCop is 100% green :tada: | Xavier Noria | 2016-09-02 | 1 | -4/+5 |
| | |||||
* | Add load hooks to all tests classes | Rafael Mendonça França | 2016-08-25 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed. | ||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 2 | -4/+4 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 2 | -98/+98 |
| | |||||
* | applies new string literal convention in actionmailer/lib | Xavier Noria | 2016-08-06 | 13 | -35/+35 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | remove `-t` option from default sendmail arguments [ci skip] | yuuji.yaginuma | 2016-07-06 | 2 | -2/+2 |
| | | | | Follow up to #24436 |