aboutsummaryrefslogtreecommitdiffstats
path: root/actionmailer/lib/action_mailer/base.rb
Commit message (Collapse)AuthorAgeFilesLines
* Removed method missing from ActionMailer::MessageDeliveryCristian Bica2014-08-151-0/+4
|
* Refactor DeliverLater into MessageDeliveryAbdelkader Boudih2014-08-141-6/+2
|
* Added ActionMailer::DeliverLaterAbdelkader Boudih2014-08-131-1/+5
|
* Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-301-0/+5
| | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* Raise an exception when attachments are added after `mail` was called.Yves Senn2014-07-291-1/+16
| | | | | | | | | Closes #16163 Adding attachments after a call to `mail` will result in invalid emails. This is related to the fact, that `mail` is making the required preparations before the email is ready to be sent. These change depending on your added attachments.
* Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip]Santosh Wadghule2014-07-141-1/+1
|
* allow preview interceptors to be registered through `config.action_mailer`.Yves Senn2014-06-151-1/+1
| | | | | | | | | | | | | | | This was partially broken because `preview_interceptors=` just assigned the raw values, whithout going through `register_preview_interceptor`. Now the Action Mailer railtie takes care of the `preview_interceptors` option. This commit is a partial revert of: Revert "Merge pull request #15739 from y-yagi/correct_doc_for_action_mailer_base" This reverts commit a15704d7f35f17d34d0118546799141d6f853656, reversing changes made to 1bd12a8609d275ad75fcc4b622ca4f5b32dc76be. /cc @kuldeepaggarwal @y-yagi
* [ci skip] correct doc for `register_preview_interceptor`yuuji.yaginuma2014-06-151-1/+1
|
* [ci skip] Improve enable_starttls_auto documentation.Juanito Fatas2014-06-111-2/+2
|
* Pass through AM documentation re: 02d048d [ci skip]Zachary Scott2014-05-261-4/+5
|
* [ci skip] Improve formatting and ymlGaurav Sharma2014-04-241-2/+2
|
* :scissors:Zachary Scott2014-02-231-1/+1
| | | | This commit also addresses rails/docrails#169 and rails/rails#14159
* Fix render plain docs example in AM::BaseGuillermo Iguaran2014-02-181-2/+2
| | | The errors were introduced in e220a34e39
* Update Docs in favor to use render plain instead of text optionrobertomiranda2014-02-181-3/+3
| | | | ref #14062
* add actionmailer test coverage for undefined delivery methodDmitry Polushkin2014-02-091-1/+1
|
* Remove an extra comment [ci skip]Robin Dupret2014-01-261-1/+0
|
* Support underscored symbols in Action Mailer configAndrew White2014-01-261-5/+18
| | | | | | We allow the use of underscored symbols to represent classes throughout other parts of Rails so it seems incongruous that it's not supported in `register_interceptor` and `register_observer`.
* Add the ability to intercept emails before previewingAndrew White2014-01-261-0/+15
| | | | | | | | | | | | | | | | To support the ability for tools like CSS style inliners to operate on emails being previewed this commit adds a hook in a similar fashion to the existing delivery interceptor hook, e.g: class CSSInlineStyler def self.previewing_email(message) # inline CSS styles end end ActionMailer::Base.register_preview_interceptor CSSInlineStyler Fixes #13622.
* docs should say `email` not `Email`. [ci skip]Yves Senn2014-01-201-1/+1
|
* removed extra comma [ci skip]Kuldeep Aggarwal2014-01-141-1/+1
|
* Improve font of some code in API documentation [ci skip]Chun-wei Kuo2013-12-261-17/+18
| | | | | * Add "<tt>" or "+" to improve font of some code and filenames in API documentation * Does not contain wording changes
* document how to access mail previews. [ci skip]Yves Senn2013-12-181-0/+3
| | | | /cc @pixeltrix
* Add mailer previews feature based on mail_view gemAndrew White2013-12-171-0/+20
|
* Include AV::Layouts directly in AM::BaseŁukasz Strzałkowski2013-12-051-0/+2
| | | | No need to do this in railtie as AM depends on AV either way
* `mail()` without arguments is a getter for the current mail.Yves Senn2013-12-021-0/+2
| | | | | | | | | | | | | | This behavior is documented in our guides (http://edgeguides.rubyonrails.org/action_mailer_basics.html#action-mailer-callbacks) but was broken in the past. This commit short curcuits the `mail` method if: 1. mail() was previously called 2. no headers are passed 3. no block is passed Closes #13090. /cc @pixeltrix
* Ruby's new Hash syntax applied in actionmailerMr A2013-11-141-2/+2
|
* calculate the ivars to remove in advance as a set and cache them in aAaron Patterson2013-11-061-1/+5
| | | | | | | constant. `view_assigns` can use the precalculated sets and remove instance variables without allocating any extra arrays
* Merge pull request #12591 from vipulnsward/remove_mail_mergeYves Senn2013-10-201-3/+3
|\ | | | | Remove extra variable creation and merge.
| * Remove extra variable creation and merge.Vipul A M2013-10-201-3/+3
| |
* | Instrument the generation of Action Mailer messagesDaniel Schierbeck2013-10-201-4/+11
|/ | | | | | The processing of outbound mail is instrumented with the key `process.action_mailer`. The payload includes the mailer name as well as the mailer method.
* Revert "Port all remaining self.protected_instance_variables to class methods"Łukasz Strzałkowski2013-09-021-4/+2
| | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01.
* Port all remaining self.protected_instance_variables to class methodsŁukasz Strzałkowski2013-08-291-2/+4
|
* Remove hard require to ActionView from ActionMailerŁukasz Strzałkowski2013-08-251-1/+0
|
* Load AV::Layout to AM::Base in railtiesŁukasz Strzałkowski2013-08-251-2/+0
|
* Include AbsC::Rendering interface in ActionMailerŁukasz Strzałkowski2013-08-251-0/+3
|
* Do not include AV::RenderingŁukasz Strzałkowski2013-08-251-1/+0
| | | | It's already included in Layouts, makes no sense to doubly include it
* Integrate ActionMailer with ActionViewŁukasz Strzałkowski2013-08-251-2/+5
|
* don't convert mailer default values to procsAlex Tsukernik2013-07-221-1/+1
| | | | | | Invoke mailer defaults as procs only if they are procs, do not convert with to_proc. That an object is convertible to a proc does not mean it's meant to be always used as a proc. Fixes #11533
* Revert "nodoc ActionMailer module from lib/action_mailer/*.rb"Vijay Dev2013-05-191-1/+1
| | | | | | | | This reverts commit 328e876a1569058e47eaf7ea3f4f045a83b585fa. Reason: Let's not nodoc without reason. [ci skip]
* Fix documentation for ActionMailer template names.Megan Bowra-Dean2013-05-171-4/+4
| | | | ActionMailer templates that are not plain text do not require *.text.* in the name and will fail to be picked up automatically if it is included in the name.
* nodoc ActionMailer module from lib/action_mailer/*.rbZachary Scott2013-05-151-1/+1
|
* Document ActionMailer::Base#set_content_typeZachary Scott2013-05-121-0/+9
|
* RDoc style for ActionMailer::Base#mailZachary Scott2013-05-101-23/+25
|
* Document ActionMailer::Base::default, ::mailer_name, and #mailer_nameZachary Scott2013-05-101-14/+25
|
* Fix grammar on AM.mailer_name documentation.Hendy Tanata2013-05-061-1/+1
|
* Add some documentation for AM.mailer_namePrem Sichanugrist2013-05-031-0/+2
|
* Remove superfluous `self.` in Action Mailer mail method documetationAlexey Vakhov2013-04-231-3/+3
| | | | | | Notation with `self` was sugestted at 0b05acd, when self.defaults was extlib_inheritable_accessor. But now all Action Mailer examples are without this self. It's nicer.
* Cosmetic fixes in AM::Base docs. Missed spaces in OpenSSL constants ↵Alexey Vakhov2013-04-231-2/+2
| | | | | | enumerations. Injected at a1639ad.
* Send paths argument as an array rather than converting it internallyCarlos Antonio da Silva2013-01-281-3/+3
|
* Allow passing interpolations to `#default_i18n_subject`, e.g.:Olek Janiszewski2013-01-241-2/+3
| | | | | | | | | | | | | | | # config/locales/en.yml en: user_mailer: welcome: subject: 'Hello, %{username}' # app/mailers/user_mailer.rb class UserMailer < ActionMailer::Base def welcome(user) mail(subject: default_i18n_subject(username: user.name)) end end