Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Document using `default_url_options` in an ActionMailer class. | Krzysztof Zych | 2017-03-08 | 1 | -0/+3 |
| | |||||
* | Freeze fragment cache related instrument name. | Stan Lo | 2017-02-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | ActionMailer::Base#instrument_name and ActionController::Base#instrument_name will be frequently called once caching is enabled. So it's better to freeze them instead of create new string on every call. Also, the instrument name in #instrument_fragment_cache will usually be "write_fragment.action_controller" or "read_fragment.action_controller". So freezing them might also gain some performance improvement. We have done something like this in other places: https://github.com/rails/rails/blob/master/actionview/lib/action_view/template.rb#L348 | ||||
* | Add `:args` to `process.action_mailer` event | yuuji.yaginuma | 2017-02-04 | 1 | -1/+2 |
| | |||||
* | add default value to `deliver_later_queue_name` option [ci skip] | yuuji.yaginuma | 2017-01-31 | 1 | -1/+1 |
| | |||||
* | Offer the option to use parameterization for shared processing of headers ↵ | David Heinemeier Hansson | 2017-01-28 | 1 | -7/+6 |
| | | | | | and ivars (#27825) Offer the option to use parameterization for shared processing of headers and ivars | ||||
* | ZOMG worst typo in my life :scream: | Akira Matsuda | 2017-01-15 | 1 | -1/+1 |
| | |||||
* | `respond_to_missing?` should fallback to `super` where method_missing could ↵ | Akira Matsuda | 2017-01-15 | 1 | -1/+1 |
| | | | | call `super` | ||||
* | Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail-body | Rafael Mendonça França | 2017-01-06 | 1 | -4/+21 |
|\ | | | | | | | Allow to custom content type when setting mailer body | ||||
| * | Remove unnecessary condition in content_type | MQuy | 2017-01-06 | 1 | -1/+1 |
| | | |||||
| * | Add document in mailer | MQuy | 2016-12-06 | 1 | -0/+13 |
| | | |||||
| * | allow context type when set body mail | MQuy | 2016-11-30 | 1 | -4/+8 |
| | | |||||
* | | Privatize unneededly protected methods in Action Mailer | Akira Matsuda | 2016-12-24 | 1 | -11/+7 |
| | | |||||
* | | No need to nodoc private method | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
|/ | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -2/+2 |
| | |||||
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 1 | -15/+15 |
| | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -94/+94 |
| | |||||
* | applies new string literal convention in actionmailer/lib | Xavier Noria | 2016-08-06 | 1 | -10/+10 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | remove `-t` option from default sendmail arguments [ci skip] | yuuji.yaginuma | 2016-07-06 | 1 | -1/+1 |
| | | | | Follow up to #24436 | ||||
* | Do not suggest nonsensical OpenSSL verify modes [ci skip] | Jonne Haß | 2016-06-07 | 1 | -3/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | SSL_set_verify(3) explains: SSL_VERIFY_FAIL_IF_NO_PEER_CERT Server mode: if the client did not return a certificate, the TLS/SSL handshake is immediately terminated with a "handshake failure" alert. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored SSL_VERIFY_CLIENT_ONCE Server mode: only request a client certificate on the initial TLS/SSL handshake. Do not ask for a client certificate again in case of a renegotiation. This flag must be used together with SSL_VERIFY_PEER. Client mode: ignored The SMTP connection here uses a OpenSSL socket in client mode, suggesting invalid/ignored flags is rather misleading. | ||||
* | fix grammar | Rajat Bansal | 2016-05-31 | 1 | -1/+1 |
| | |||||
* | Action Mailer: Declarative exception handling with `rescue_from`. | Jeremy Daer | 2016-05-15 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | Follows the same pattern as controllers and jobs. Exceptions raised in delivery jobs (enqueued by `#deliver_later`) are also delegated to the mailer's rescue_from handlers, so you can handle the DeserializationError raised by delivery jobs: ```ruby class MyMailer < ApplicationMailer rescue_from ActiveJob::DeserializationError do … end ``` ActiveSupport::Rescuable polish: * Add the `rescue_with_handler` class method so exceptions may be handled at the class level without requiring an instance. * Rationalize `exception.cause` handling. If no handler matches the exception, fall back to the handler that matches its cause. * Handle exceptions raised elsewhere. Pass `object: …` to execute the `rescue_from` handler (e.g. a method call or a block to instance_exec) against a different object. Defaults to `self`. | ||||
* | Add :ssl/:tls to ActionMailer [ci skip] | Pedro Adame Vergara | 2016-05-09 | 1 | -0/+1 |
| | |||||
* | Merge pull request #24525 from tomkadwill/action-mailer-base-docs2 | Vipul A M | 2016-04-14 | 1 | -3/+3 |
|\ | | | | | Update ActionMailer base documentation [ci skip] | ||||
| * | Update ActionMailer base documentation [ci skip] | Tom Kadwill | 2016-04-13 | 1 | -3/+3 |
| | | |||||
* | | Update ActionMailer Views documentation [ci skip] | Tom Kadwill | 2016-04-10 | 1 | -1/+1 |
|/ | |||||
* | Update base.rb | Sarah A | 2016-03-03 | 1 | -1/+1 |
| | |||||
* | Move private methods to the private visibility | Rafael Mendonça França | 2016-02-24 | 1 | -12/+12 |
| | |||||
* | Move Caching module to Abstract Controller | Rafael Mendonça França | 2016-02-23 | 1 | -3/+1 |
| | | | | | | Abstract Controller is the common component between Action Mailer and Action Controller so if we need to share the caching component it need to be there. | ||||
* | Move ActionMailer::Caching's content into ActionMailer::Base instead of ↵ | Stan Lo | 2016-02-23 | 1 | -1/+15 |
| | | | | | | including it Remove useless helper in ActionDispatch::Caching and fix indentation | ||||
* | Porting ActionController::Caching to ActionMailer::Caching | Stan Lo | 2016-02-23 | 1 | -0/+1 |
| | |||||
* | Change x-gzip to gzip in docs [ci skip] | Mehmet Emin İNAÇ | 2016-02-13 | 1 | -2/+2 |
| | | | | For more information about GNU zip mime type please check IETF's web site [RFC6713](http://tools.ietf.org/html/rfc6713) or [IANA](http://www.iana.org/assignments/media-types/media-types.xhtml#application) | ||||
* | Revert "When generating a mailer, you must specify Mailer in the class name in" | yuuji.yaginuma | 2016-02-06 | 1 | -1/+1 |
| | | | | | | | | This reverts commit 8417d967e016f0219cc4ec30bf0d3908ce6cd29b. In 5697bdbb6da5d08e541a3b12251cec90269b059b and af3eb5961e55a46b011be797e71f615f20f56686, add mailer suffix to generated files and classes. Therefore, no longer need to specify `Mailer` to class name. [ci skip] | ||||
* | When generating a mailer, you must specify Mailer in the class name in | Andrew Kaspick | 2016-02-05 | 1 | -1/+1 |
| | | | | | order to generate the proper files. Some of the docs/comments are missing this important detail. | ||||
* | [ci skip] Fix grammar and sentence framing | Akshay Vishnoi | 2015-12-17 | 1 | -6/+6 |
| | |||||
* | Make ActionMailer::Base.respond_to_missing? private | Ryan Buckley | 2015-12-03 | 1 | -4/+6 |
| | |||||
* | Replace ActionMailer::Base#respond_to? with respond_to_missing? | Ryan Buckley | 2015-12-02 | 1 | -2/+2 |
| | |||||
* | Move all nodoc methods to the private section | Rafael Mendonça França | 2015-11-24 | 1 | -43/+43 |
| | | | | Since they are nodoc there is no need to be protected. | ||||
* | Put all private method together | Rafael Mendonça França | 2015-11-24 | 1 | -36/+35 |
| | |||||
* | Avoid mutating the headers hash | Rafael Mendonça França | 2015-11-24 | 1 | -2/+3 |
| | | | | | We are already filtering the keys in the assign_headers_to_message method so we can just update the filter. | ||||
* | nodoc in the private method | Rafael Mendonça França | 2015-11-24 | 1 | -1/+1 |
| | |||||
* | Merge pull request #22120 from hnatt/refactor-actionmailer | Rafael Mendonça França | 2015-11-24 | 1 | -55/+59 |
|\ | | | | | | | Refactor ActionMailer::Base | ||||
| * | Rename ActionMailer::Base#class_from_value -> observer_class_for | hnatt | 2015-10-30 | 1 | -4/+4 |
| | | |||||
| * | Don't mutate headers in ActionMailer::Base#collect_responses_from_templates | hnatt | 2015-10-30 | 1 | -2/+2 |
| | | |||||
| * | Pass message as argument to ActionMailer::Base#assign_headers_to_message | hnatt | 2015-10-30 | 1 | -4/+5 |
| | | |||||
| * | Fix indentation in ActionMailer::Base#collect_responses_from_templates | hnatt | 2015-10-29 | 1 | -5/+5 |
| | | |||||
| * | Refactor out headers to message assignment from ActionMailer::Base#mail | hnatt | 2015-10-29 | 1 | -3/+6 |
| | | |||||
| * | Use attr_internal in ActionMailer::Base#mail instead of local var for message | hnatt | 2015-10-29 | 1 | -11/+9 |
| | | |||||
| * | Refactor out defaults handling from ActionMailer::Base#mail | hnatt | 2015-10-29 | 1 | -9/+15 |
| | | |||||
| * | Refactor ActionMailer::Base#collect_responses | hnatt | 2015-10-29 | 1 | -16/+16 |
| | | |||||
| * | Reduce code duplication in ActionMailer::Base#register_observer and ↵ | hnatt | 2015-10-29 | 1 | -16/+12 |
| | | | | | | | | #register_interceptor |