| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
When reloading is disabled, after_initialize hooks run after to_prepare hooks have already run for the last time. Since to_prepare hooks always run after application initializers, we don't need need to use an after_initialize hook.
|
|
|
|
|
|
|
|
|
|
|
|
| |
I implemented Foreign key create in `create_table` for SQLite3 at
#24743. This follows #24743 to implement `add_foreign_key` and
`remove_foreign_key`.
Unfortunately SQLite3 has one limitation that
`PRAGMA foreign_key_list(table-name)` doesn't have constraint name.
So we couldn't implement find/remove foreign key by name for now.
Fixes #35207.
Closes #31343.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In MySQL, the text column size is 65,535 bytes by default (1 GiB in
PostgreSQL). It is sometimes too short when people want to use a text
column, so they sometimes change the text size to mediumtext (16 MiB) or
longtext (4 GiB) by giving the `limit` option.
Unlike MySQL, PostgreSQL doesn't allow the `limit` option for a text
column (raises ERROR: type modifier is not allowed for type "text").
So `limit: 4294967295` (longtext) couldn't be used in Action Text.
I've allowed changing text and blob size without giving the `limit`
option, it prevents that migration failure on PostgreSQL.
|
|
|
|
| |
This reverts commit 30f666f87ab873258b797b39f29cf852f7621bea.
|
|
|
|
| |
Follow up #34956.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Active Record still support MySQL 5.5 which doesn't support datetime
with precision.
https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101
So we should check `supports_datetime_with_precision?` on the
connection.
|
|
|
|
| |
This makes sure the created email has checksum and message id columns set.
|
|
|
|
|
|
| |
does not exceed the limit.
Also, update test schema to reflect the recent changes.
|
|
|
|
|
|
|
| |
This also adds a new column, message_checksum, to the action_mailbox_inbound_emails table
for storing SHA1 digest of the email source. Additionally, it makes generating the missing
message id deterministic and adds a unique index on message_checksum and message_id to
detect duplicate emails.
|
|
|
|
| |
Use `+` instead of backquote.
|
|
|
|
| |
created_at and updated_at columns in Action Mailbox table aren't intended nullable.
|
| |
|
| |
|
| |
|
|\
| |
| | |
Bring in all of aws-sdk-sns if using Amazon ingress
|
| |
| |
| |
| |
| |
| |
| | |
Requiring _just_ the `Aws::SNS::MessageVerifier` does not work as it
references other classes in the AWS SDK that are not in this one class.
Bringing in the entire SNS SDK verifies the authenticity correctly.
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Frameworks collection was missing actiontext and actionmailbox,
this would mean they are skipped when running any tasks that
iterated through this collection
changes include
Breaking up frameworks declaration into multiple lines and put
them in order. This should make adding to the list easier and
if you need to scan it, they will be in order you would expect
Add `package` task to both actiontext and actionmailbox
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- config.load_defaults 6.0 in the dummy app and
fix the test since by default rails 6.0 configured
does not generate "utf8" hidden input, see #32125
- Use `ActiveRecord::Migration[6.0]` in the dummy app
since actiontext will be since Rails 6.0
- Fix `CreateActiveStorageTables` migration in the dummy app.
Add `t.foreign_key :active_storage_blobs, column: :blob_id`
It was added in 2ae3a29508e.
- `rails/actiontext$ yarn install`
|
| |
|
| |
|
|
|
|
| |
from API docs
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
bogdanvlviv/add-changelog-file-to-actionmailbox-specification
Add CHANGELOG.md to actionmailbox gem specification
|
| | |
|
|\ \
| |/
|/| |
Bump license years for 2019
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
bogdanvlviv/change-migration-version-of-actionmailbox
Use 6.0 version of `ActiveRecord::Migration` for Action Mailbox
|
| |
| |
| |
| |
| |
| | |
Since Action Mailbox will be introduced in Rails 6.0,
it makes more sense to generate migration of that version.
Also I changed its test dummy app to use default 6.0 configs.
|
|\ \
| |/
|/| |
Add Action Mailbox to guides
|
| |
| |
| |
| |
| |
| |
| | |
[ci skip]
I added WIP label to that guide since we definitely
want to complement it.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Follow up to d082439cf7e577e266bfeb7b443569f323df1673
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
```
rails/actionmailbox$ bundle exec rake tests
(snip)
...
rails/activerecord/lib/active_record/persistence.rb:48: warning: in `create!':
the last argument was passed as a single Hash
rails/actionmailbox/app/models/action_mailbox/inbound_email/message_id.rb:21:
warning: although a splat keyword arguments here
...
(snip)
```
|
|
|
|
| |
Follow up #34786
|
| |
|
| |
|