| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
controller passed along attachment file paths instead of their filenames
|
| |
|
|
|
|
|
| |
The BCC should be included as we show input field for BCC in view.
https://github.com/rails/rails/blob/bf625f7fecabbcda22b388e088ad5c29016b2385/actionmailbox/app/views/rails/conductor/action_mailbox/inbound_emails/new.html.erb#L21-L24
|
|
|
|
|
| |
Especially, somehow `CHANGELOG.md` in actiontext and activestorage in
master branch had used 3 spaces indentation.
|
|
|
|
|
|
|
| |
The other template files do not add `frozen_string_literal`, so should
behave the same.
Ref: #30342, #30348.
|
| |
|
| |
|
|
|
|
| |
per comments from CR
|
|
|
|
|
|
|
| |
Currently, the only exposed entry point into the ApplicationMailbox's configured
routing system is to call `route`, which performs a lot of work to fully
`process` inbound email. It'd be nice to have a way (e.g. in test) of checking
which mailbox an email would route to without necessarily processing it yet.
|
| |
|
|
|
| |
It's unusable and not ready to ship in Rails 6.0. We'll rewrite it for 6.1.
|
|
|
|
|
|
|
| |
When `default_protect_from_forgery` is false, `verify_authenticity_token`
callback does not define and `skip_forgery_protection` raise exception.
Fixes #34837.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`receive_inbound_email_from_source` should accept an argument list
(`*args`) instead, to allow for the `source` argument in
`create_inbound_email_from_source`.
```ruby
receive_inbound_email_from_source(source, status: :processing)
```
Accepting a keyword argument list (`**kwargs`) results in an
`ArgumentError`
```text
ArgumentError: wrong number of arguments (given 1, expected 0)
```
|
| |
|
|
|
|
|
|
|
| |
* add leading `#` before `=>` since hash rocket is valid Ruby code
* add backticks
* remove trailing spaces
* and more
|
|
|
|
|
|
|
| |
We need to create a secret token in the application so that the travis
build doesn't error when trying to create a file in the tmp directory.
Fixes https://travis-ci.org/rails/rails/jobs/505908163#L6811
|
|\
| |
| |
| | |
v6.0.0.beta3 release
|
| |
| |
| |
| |
| |
| |
| | |
* Update RAILS_VERSION
* Bundle
* rake update_versions
* rake changelog:header
|
|\ \
| | |
| | |
| | |
| | | |
abhaynikam/35492-follow-up-to-updates-links-to-https
Updated links from http to https in guides, docs, etc
|
| |/ |
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
When reloading is disabled, after_initialize hooks run after to_prepare hooks have already run for the last time. Since to_prepare hooks always run after application initializers, we don't need need to use an after_initialize hook.
|
|
|
|
|
|
|
|
|
|
|
|
| |
I implemented Foreign key create in `create_table` for SQLite3 at
#24743. This follows #24743 to implement `add_foreign_key` and
`remove_foreign_key`.
Unfortunately SQLite3 has one limitation that
`PRAGMA foreign_key_list(table-name)` doesn't have constraint name.
So we couldn't implement find/remove foreign key by name for now.
Fixes #35207.
Closes #31343.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In MySQL, the text column size is 65,535 bytes by default (1 GiB in
PostgreSQL). It is sometimes too short when people want to use a text
column, so they sometimes change the text size to mediumtext (16 MiB) or
longtext (4 GiB) by giving the `limit` option.
Unlike MySQL, PostgreSQL doesn't allow the `limit` option for a text
column (raises ERROR: type modifier is not allowed for type "text").
So `limit: 4294967295` (longtext) couldn't be used in Action Text.
I've allowed changing text and blob size without giving the `limit`
option, it prevents that migration failure on PostgreSQL.
|
|
|
|
| |
This reverts commit 30f666f87ab873258b797b39f29cf852f7621bea.
|
|
|
|
| |
Follow up #34956.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Active Record still support MySQL 5.5 which doesn't support datetime
with precision.
https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101
So we should check `supports_datetime_with_precision?` on the
connection.
|
|
|
|
| |
This makes sure the created email has checksum and message id columns set.
|
|
|
|
|
|
| |
does not exceed the limit.
Also, update test schema to reflect the recent changes.
|
|
|
|
|
|
|
| |
This also adds a new column, message_checksum, to the action_mailbox_inbound_emails table
for storing SHA1 digest of the email source. Additionally, it makes generating the missing
message id deterministic and adds a unique index on message_checksum and message_id to
detect duplicate emails.
|
|
|
|
| |
Use `+` instead of backquote.
|
|
|
|
| |
created_at and updated_at columns in Action Mailbox table aren't intended nullable.
|
| |
|
| |
|
| |
|
|\
| |
| | |
Bring in all of aws-sdk-sns if using Amazon ingress
|
| |
| |
| |
| |
| |
| |
| | |
Requiring _just_ the `Aws::SNS::MessageVerifier` does not work as it
references other classes in the AWS SDK that are not in this one class.
Bringing in the entire SNS SDK verifies the authenticity correctly.
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Frameworks collection was missing actiontext and actionmailbox,
this would mean they are skipped when running any tasks that
iterated through this collection
changes include
Breaking up frameworks declaration into multiple lines and put
them in order. This should make adding to the list easier and
if you need to scan it, they will be in order you would expect
Add `package` task to both actiontext and actionmailbox
|