Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Defer starting connection monitor until a connection is opened | Javan Makhmali | 2016-03-03 | 3 | -41/+52 |
| | |||||
* | Establish WebSocket connection when first subscription is created. Fixes #24026 | Javan Makhmali | 2016-03-03 | 3 | -9/+10 |
| | | | | | * More intention revealing than connecting on the first call to Connection#send * Fixes that calls to Connection#send would attempt to open a connection when the WebSocket's state is CONNECTING | ||||
* | Merge pull request #23992 from matthewd/em-option | Matthew Draper | 2016-03-04 | 29 | -51/+227 |
|\ | | | | | Support faye-websocket + EventMachine as an option | ||||
| * | Support faye-websocket + EventMachine as an option | Matthew Draper | 2016-03-02 | 29 | -51/+227 |
| | | |||||
* | | ConnectionMonitor is once again notified of disconnect | Daniel Rhodes | 2016-03-03 | 2 | -0/+2 |
| | | |||||
* | | Fix CHANGELOG spacing [ci skip] | Jeremy Daer | 2016-03-02 | 1 | -12/+12 |
| | | |||||
* | | Accept JSON with no backslashes/escaping | Jon Moss | 2016-03-02 | 4 | -8/+27 |
| | | | | | | | | | | | | | | Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer. | ||||
* | | Merge pull request #23976 from danielrhodes/enhancement/ac-ping-to-message-type | Matthew Draper | 2016-03-02 | 7 | -19/+24 |
|\ \ | | | | | | | | | | ActionCable: Add a "welcome" and "ping" message type | ||||
| * | | Make ping into a message type | Daniel Rhodes | 2016-03-01 | 6 | -15/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work. | ||||
| * | | Added welcome message type and fix test hacks | Daniel Rhodes | 2016-03-01 | 5 | -5/+14 |
| | | | |||||
* | | | Merge pull request #23932 from arthurnn/arthurnn/remove_load_paths | Arthur Nogueira Neves | 2016-03-01 | 1 | -3/+0 |
|\ \ \ | | | | | | | | | Remove load_paths file | ||||
| * | | | Remove load_paths file | Arthur Neves | 2016-02-27 | 1 | -3/+0 |
| | | | | |||||
* | | | | Merge pull request #23935 from y-yagi/convert_cable_coffee_to_javascript | Rafael França | 2016-03-01 | 1 | -1/+1 |
|\ \ \ \ | |_|_|/ |/| | | | convert cable.coffee to cable.js | ||||
| * | | | convert cable.coffee to cable.js | yuuji.yaginuma | 2016-02-28 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | In order to eliminate the dependecy of CoffeeScript. | ||||
* | | | | Use AS::Executor / AS::Reloader to support reloading in ActionCable | Matthew Draper | 2016-03-02 | 8 | -24/+96 |
| | | | | |||||
* | | | | Remove inconsistency in the Action Cable README [ci skip] | Bouke van der Bijl | 2016-02-29 | 1 | -6/+2 |
| |_|/ |/| | | |||||
* | | | Merge pull request #23811 from iamvery/string-channel | David Heinemeier Hansson | 2016-02-28 | 5 | -1/+37 |
|\ \ \ | |/ / |/| | | Ensure actioncable behaves as expected with non-string queues | ||||
| * | | Update changelog | Jay Hayes | 2016-02-24 | 1 | -0/+4 |
| | | | |||||
| * | | Ensure server broadcasts are to string queue names | Jay Hayes | 2016-02-24 | 2 | -1/+16 |
| | | | | | | | | | | | | | | | | | | Similar to the channel streaming side, these values must be strings for ActionCable to behave as expected. The conversion will allow users to send string-convertible values and get the expected behavior. | ||||
| * | | Convert stream broadcasting to a string | Jay Hayes | 2016-02-24 | 2 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | ActionCable does some things behind the scenes that expects these "broadcasting"s or "channel"s to be strings. However it's not immediately obvious that the value must be a string. So adding this conversion ensures things work as expected. | ||||
| * | | whitespace | Jay Hayes | 2016-02-24 | 1 | -1/+0 |
| | | | |||||
* | | | Add small Action Cable documentation fixes | Hayley Anderson | 2016-02-27 | 4 | -13/+13 |
| |/ |/| | | | | | | | * Fix typos/grammar errors * Make capitalization/naming consistent | ||||
* | | Merge pull request #23916 from ↵ | Jeremy Daer | 2016-02-26 | 1 | -2/+6 |
|\ \ | | | | | | | | | | | | | lifo/same-redis-connection-for-subscription-and-broadcast Always use redis_connector to create redis connections | ||||
| * | | Use redis_connector to create redis connections for both subscriptions and ↵ | Pratik Naik | 2016-02-26 | 1 | -2/+6 |
| | | | | | | | | | | | | broadcasts | ||||
* | | | The async.callback call should live with the hijack | Matthew Draper | 2016-02-26 | 1 | -4/+5 |
| | | | | | | | | | | | | If we're deferring one, we should defer the other too. | ||||
* | | | Merge pull request #23843 from maclover7/fix-23471 | Matthew Draper | 2016-02-25 | 3 | -10/+29 |
|\ \ \ | | | | | | | | | Only hijack Rack socket when first needed | ||||
| * | | | Only hijack Rack socket when first needed | Jon Moss | 2016-02-24 | 3 | -10/+29 |
| | |/ | |/| | | | | | | | Fixes #23471 | ||||
* | | | Only open Action Cable connection if data is being sent | Jon Moss | 2016-02-24 | 1 | -1/+3 |
| | | | |||||
* | | | Enable Action Cable routes by default | Jon Moss | 2016-02-24 | 4 | -5/+27 |
|/ / | | | | | | | This also marks Action Cable routes as internal to Rails. | ||||
* | | Add Ruby formatting to CHANGELOG entry | claudiob | 2016-02-24 | 1 | -4/+5 |
| | | | | | | | | [ci skip] | ||||
* | | Preparing for 5.0.0.beta3 release | eileencodes | 2016-02-24 | 1 | -0/+2 |
| | | | | | | | | Adds changelog headers for beta3 release | ||||
* | | Prep release for Rails 5 beta3 | eileencodes | 2016-02-24 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #23789 from ↵ | Rafael França | 2016-02-23 | 1 | -3/+3 |
|\ \ | | | | | | | | | | | | | wisetara/wisetara/deprecate-args-ActiveSupport__TestCase#assert_nothing_raised-for-pr Wisetara/deprecate args active support test case#assert nothing raised for pr | ||||
| * | | remove args from assert_nothing_raised in tests | Tara Scherner de la Fuente | 2016-02-22 | 1 | -3/+3 |
| | | | |||||
* | | | Merge pull request #23813 from lifo/faye-websocket | David Heinemeier Hansson | 2016-02-23 | 5 | -7/+51 |
|\ \ \ | |/ / |/| | | Improve Action Cable reconnection reliability | ||||
| * | | Fix isAlive condition and add more logging | Javan Makhmali | 2016-02-23 | 1 | -5/+7 |
| | | | |||||
| * | | ActionCable.log | Javan Makhmali | 2016-02-23 | 3 | -14/+25 |
| | | | |||||
| * | | Uninstall event handlers when replacing WebSocket instance | Javan Makhmali | 2016-02-23 | 1 | -0/+6 |
| | | | | | | | | | | | | Ensures we don't get "onclose" events from a previous WebSocket that was in the "closing" state | ||||
| * | | Connection#isAlive | Javan Makhmali | 2016-02-23 | 1 | -3/+3 |
| | | | |||||
| * | | Log ConnectionMonitor connect | Pratik Naik | 2016-02-23 | 1 | -0/+1 |
| | | | |||||
| * | | Confirm connection monitor subscription on open | Pratik Naik | 2016-02-23 | 2 | -2/+9 |
| | | | |||||
| * | | Treat 'closing' state as closed. | Pratik Naik | 2016-02-23 | 1 | -3/+6 |
| | | | | | | | | | | | | | | | | | | We are seeing cases where the websockets get stuck in the 'closing' state after a tab has been in background for a while. So lets treat those websockets as closed. | ||||
| * | | Add client-side console logging to help debug reconnect issues | Javan Makhmali | 2016-02-23 | 2 | -1/+15 |
| |/ | |||||
* | | Action Cable readme fix [ci skip] | Mehmet Emin İNAÇ | 2016-02-23 | 1 | -4/+4 |
| | | |||||
* | | Merge pull request #23668 from maclover7/cable-docs | Rafael França | 2016-02-22 | 16 | -70/+67 |
|\ \ | | | | | | | Full Action Cable documentation read through | ||||
| * | | Full Action Cable documentation read through | Jon Moss | 2016-02-17 | 16 | -70/+67 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR checks all active Action Cable documentation for typos and other fixes. It aims to make sure that when Rails 5 is released, that the Action Cable docs are up to snuff with the other documentation included with Rails. [ci skip] | ||||
* | | | Add notes for future selves | Jon Moss | 2016-02-22 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | Once RubyGems 2.5.0 is required, then the duplicated files can be removed, and symlinks can be used instead. [ci skip] | ||||
* | | | Generate ApplicationCable files if they do not already exist | Jon Moss | 2016-02-22 | 3 | -0/+26 |
| |/ |/| | |||||
* | | Fixed typo | Chashmeet Singh | 2016-02-21 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #23709 from jankeesvw/set-action-cable-logging-to-debug | David Heinemeier Hansson | 2016-02-19 | 1 | -1/+1 |
|\ \ | | | | | | | Make ActionCable logging less verbose in development |