| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
| |
Method description improved to reflect little bit more complicated scenario when names are camel-cased.
|
| |\
| |
| |
| |
| | |
Conflicts:
guides/source/configuring.md
|
| | | |
|
| | |
| |
| |
| | |
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
In #23935, cable file was to be provided by the javascript instead of coffeescript,
doc was also been modified to use javascript.
|
| |\ \
| | |
| | |
| | | |
Preparing for 5.0.0.rc1 release
|
| | | | |
|
| |/ /
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This is an engine living in action_cable/engine.rb, convention is to
call these things *::Engine.
Looking at thi git history looks like the current *::Railtie was just
an accident.
|
| |/
|
|
| |
default worker pool size was changed from 100 to 4 at #24376
|
| | |
|
| |\
| |
| | |
Actioncable and Actionpack documentation typos [ci skip]
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
| |
* Use separate stream handler builders for easy override and testing.
* Fix worker pool execution that was silently failing since it only
expected connection receivers.
Sparked by code in #24162.
|
| |
|
|
|
|
|
|
|
| |
* Rewrite docs
* Support blocks in addition to method names and Proc args
* Check for valid arguments
* Convert `periodically :method_name` to Proc callbacks
* Drop periodic runner methods from the worker pool
* Ensure we clear active periodic timers after shutdown
|
| |\
| |
| | |
Fix typos in ActionCable Channel [ci skip]
|
| | | |
|
| | |
| |
| |
| | |
`cable.js` is required for other Channels.
|
| |\ \
| | |
| | | |
Fixed ActionCable::Connection::ClientSocketTest test
|
| | | |
| | |
| | |
| | |
| | |
| | | |
ActionCable::Connection::StreamTest test name
- Only add attr_readers for required attributes
|
| |\ \ \
| |/ /
|/| | |
update example to specify the Action Cable mount path [ci skip]
|
| | | |
| | |
| | |
| | | |
Follow up to 8b69f1e
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Alternate implementation of #24162 with tests. The code had diverged
too far on master to pull that implemenation directly.
Fixes #23778
Close #24162
[Mattew Draper & Sean Griffin]
|
| |/
|
|
|
|
|
|
|
| |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
| | |
|
| |\
| |
| |
| | |
ActionCable protocol negotiation
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
This is primarily for backwards compatibility for when
or if the protocol is changed in future versions.
If the server fails to respond with an acceptable
protocol, the client disconnects and disables
the monitor.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Introduce a connection coder responsible for encoding Cable messages
as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck-
typing to any object responding to `#encode` and `#decode`.
* Consolidate encoding responsibility to the connection. No longer
explicitly JSON-encode from channels or other sources. Pass Cable
messages as Hashes to `#transmit` and rely on it to encode.
* Introduce stream encoders responsible for decoding pubsub messages.
Preserve the currently raw encoding, but make it easy to use JSON.
Same duck type as the connection encoder.
* Revert recent data normalization/quoting (#23649) which treated
`identifier` and `data` values as nested JSON objects rather than as
opaque JSON-encoded strings. That dealt us an awkward hand where we'd
decode JSON strings… or not, but always encode as JSON. Embedding
JSON object values directly is preferably, no extra JSON encoding,
but that should be a purposeful protocol version change rather than
ambiguously, inadvertently supporting multiple message formats.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whack it down from 100 to 4.
Large worker pools means large db connection counts. We aren't set up
for that by default and most apps won't need it out of the box.
We're better off tuning the default worker pool for low traffic, low
resource consumption apps. Those who have higher traffic will scale up
to meet demand.
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
To move Action Cable logging to a LoggingSubscriber we need to pass the
log tags in the notification payload since Action Cable logging use the
Channel instance to tag the logs.
|
| |\ \
| | |
| | |
| | | |
Add ActiveSupport::Notification to Channel::Base#perform_action
|
| | | |
| | |
| | |
| | |
| | | |
This commit adds ActiveSupport::Notifications instrumentation hooks
and a LogSuscriber to ActionCable::Channel::Base.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`skip` raises an exception to abort the execution of the test, so
`super` would never be called and thus `@rx_adapter` and `@tx_adapter`
would never have been defined at the time of teardown.
Define them just before skipping and zap the warnings.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
EM::Hiredis were spewing screenfuls of warnings when running the Action Cable tests.
Copied over the technique that shushes up faye-websocket in the client tests, so
we can reduce the noise ratio.
Note: there's still warnings spewed after tests have finished when EM::Hiredis shuts
down. I haven't been able to shush them up yet.
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Cable: Gracefully handle disconnected clients
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We'll get `Errno::ECONNRESET` if the client forcibly disconnected.
Just close the socket rather than raising the exception.
Handle other errors in `ClientSocket#write`, too, mirroring the Faye
error handling which swallows all `StandardError` on write.
|
| | | | | |
|
| |/ / / |
|
| | |/
|/|
| |
| | |
[ci skip]
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
| |
subscription object
|
| | |
|
| | |
|
