aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable
Commit message (Collapse)AuthorAgeFilesLines
* applies new string literal convention to the rest of the projectXavier Noria2016-08-061-6/+6
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in the gemspecsXavier Noria2016-08-061-14/+14
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actioncable/testXavier Noria2016-08-0629-260/+260
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actioncable/libXavier Noria2016-08-0628-90/+90
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Give importance to rails command in the comment section.Santosh Wadghule2016-07-131-1/+1
|
* Correct changelog layoutMatthew Draper2016-07-091-8/+8
| | | | [ci skip]
* Insert changelog entry for #25615Matthew Draper2016-07-091-0/+7
|
* Merge pull request #25624 from tinco/actioncable_write_raceMatthew Draper2016-07-092-2/+12
|\ | | | | | | Fix race condition in websocket stream write
| * fix race condition in websocket stream writeTinco Andringa2016-07-011-0/+4
| |
* | Merge pull request #24988 from mwear/action_cable_broadcast_notificationsMatthew Draper2016-07-043-6/+58
|\ \ | | | | | | Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast
| * | Add ActiveSupport::Notifications hook to Broadcaster#broadcastMatthew Wear2016-05-123-6/+58
| | | | | | | | | | | | | | | This addition of this notification hook will give users better visibility into the messages being sent over the PubSub adapter.
* | | Merge pull request #25030 from mmmpa/pull_requestMatthew Draper2016-07-042-1/+22
|\ \ \ | | | | | | | | ActionCable, sometimes add_channel is not called.
| * | | Add guard to broadcast.mmmpa2016-05-262-1/+22
| | | |
* | | | Merge pull request #25293 from y-yagi/remove_needless_commentsMatthew Draper2016-07-033-5/+0
|\ \ \ \ | | | | | | | | | | remove needless comments
| * | | | remove needless commentsyuuji.yaginuma2016-06-063-5/+0
| | | | | | | | | | | | | | | | | | | | Follow up to #25240.
* | | | | close hijacked i/o socket after use (fixes #25613)Tinco Andringa2016-07-012-0/+15
| |_|_|/ |/| | |
* | | | Periodic timers: delegate async instance_exec to the worker poolJeremy Daer2016-06-292-7/+9
| | | |
* | | | Merge pull request #24991 from maclover7/actioncable-npm-docsVipul A M2016-06-291-0/+68
|\ \ \ \ | | | | | | | | | | Add documentation about Action Cable npm package
| * | | | Add documentation about Action Cable npm packageJon Moss2016-05-261-0/+68
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Sorry, forgot to include in my main PR :( [ci skip] [Jon Moss, Zach Schneider]
* | | | Make client test run individually.Kasper Timm Hansen2016-06-281-1/+3
| | | | | | | | | | | | | | | | Require our dependency and forgo the core ext version.
* | | | Fix Action Cable README [ci skip]Rafael Mendonça França2016-06-261-5/+14
| | | |
* | | | Remove conflict line [ci skip]Ryuta Kamizono2016-06-271-1/+0
| | | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-06-261-2/+143
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: actioncable/README.md
| * | | | Fix and make example generic in README as well [ci skip]Vipul A M2016-06-151-3/+3
| | | | |
* | | | | client test have not using Pathname and hashwithindifferent accessGaurav Sharma2016-06-261-3/+0
| | | | |
* | | | | Allow actioncable connections from any port in developmentMichael Dever2016-06-161-1/+1
| |_|/ / |/| | |
* | | | Added "Download and Installation" section to Action Cable README [ci skip]Prathamesh Sonpatki2016-06-041-0/+10
| | | | | | | | | | | | | | | | | | | | - Only Action Cable README did not have this section, all of the other READMEs have this section.
* | | | Trim Action Cable README [ci skip]Prathamesh Sonpatki2016-06-041-161/+0
|/ / / | | | | | | | | | | | | | | | - Remove "Configuration", "Running the server", "Dependencies" and "Deployment" sections from the Action Cable README as they are already duplicated in the Action Cable overview guide.
* | | Properly support reloading for Action Cable channelsMatthew Draper2016-06-028-82/+56
| | |
* | | Merge pull request #25170 from maclover7/add-configuration-cableJeremy Daer2016-05-318-51/+69
|\ \ \ | | | | | | | | | | | | [Action Cable] Add `WebSocket` and `logger` configuration options
| * | | Add helper for testing against a mock WebSocket and serverJavan Makhmali2016-05-315-56/+48
| | | |
| * | | Reorganize `MockWebSocket`Jon Moss2016-05-312-22/+32
| | | |
| * | | Add configuration for `WebSocket` and `logger`Jon Moss2016-05-314-6/+22
| | | | | | | | | | | | | | | | [Javan Makhmali, Jon Moss]
* | | | Merge pull request #25216 from javan/actioncable/tune-sauce-labs-testsJeremy Daer2016-05-311-6/+6
|\ \ \ \ | | | | | | | | | | | | | | | Action Cable: Tune Sauce Labs tests
| * | | | Test single latest browser versionJavan Makhmali2016-05-311-6/+6
| |/ / / | | | | | | | | | | | | Cuts down the number of concurrent Sauce Labs VMs we need to spin up. Can add specific versions back in to target regressions if need be.
* / / / fix grammarRajat Bansal2016-05-312-2/+2
|/ / /
* / / Bash markdown syntaxAnubhav Saxena2016-05-271-1/+1
|/ / | | | | Added 'sh' for markdown formatting as bash.
* | CI: run Action Cable browser tests in Sauce LabsJon Moss2016-05-252-2/+27
| | | | | | | | | | | | | | | | Allow failures until test runs are consistently stable, not hanging. Closes #24943. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | | | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* | Build action_cable.js with BladeJavan Makhmali2016-05-243-42/+11
| |
* | Remove Blade gem dependencyVipul A M2016-05-211-2/+0
| | | | | | | | | | | | | | | | | | Apps that depend on Action Cable don't need Blade for app development, so we can remove the gem dependency. We do need Blade for Action Cable dev, so we bundle it in the Gemfile. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Merge pull request #25076 from jeroenvisser101/keep-to-max-lengthSean Griffin2016-05-212-2/+4
|\ \ | | | | | | Change comments to not exceed 80 characters
| * | Change comments to not exceed 80 charactersJeroen Visser2016-05-192-2/+4
| | | | | | | | | | | | Other generated files do keep to this, but action cable doesn't.
* | | Pass over Action Cable docsJon Moss2016-05-212-4/+4
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #24918 from prathamesh-sonpatki/cable-assetsRafael França2016-05-212-1/+20
|\ \ \ | |/ / |/| | Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
| * | Cable: Generate .js or .coffee files while generating channel as per the ↵Prathamesh Sonpatki2016-05-172-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
* | | Improve method descriptionRoman Pushkin2016-05-181-0/+1
|/ / | | | | Method description improved to reflect little bit more complicated scenario when names are camel-cased.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-05-141-2/+2
|\ \ | | | | | | | | | | | | Conflicts: guides/source/configuring.md
| * | Fix code formatting in docsJay Hayes2016-05-031-2/+2
| | |
* | | Publish Action Cable to NPM when we release.Jon Moss2016-05-112-0/+30
| |/ |/| | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>