| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
We are seeing cases where the websockets get stuck in the 'closing' state
after a tab has been in background for a while. So lets treat those websockets
as closed.
|
| |/ |
|
| | |
|
|\ \
| | |
| | | |
Full Action Cable documentation read through
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This PR checks all active Action Cable documentation for typos and other
fixes. It aims to make sure that when Rails 5 is released, that the
Action Cable docs are up to snuff with the other documentation included
with Rails.
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Once RubyGems 2.5.0 is required, then the duplicated files can be
removed, and symlinks can be used instead.
[ci skip]
|
| |/
|/| |
|
| | |
|
|\ \
| | |
| | | |
Make ActionCable logging less verbose in development
|
| |/
| |
| |
| |
| |
| | |
When running the ActionCable server in development I get a lot of output
in my logs, this commit sets a maximum length of 300 characters for a
broadcast log message.
|
|\ \
| | |
| | | |
Fix `unsubscribed` server side behavior
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this commit, the `unsubscribed` callbacks in Action Cable server
side channels were never called. This is because when a WebSocket
"goodbye" message was sent from the client, the Action Cable server
didn't properly clean up after the now closed WebSocket. This means that
memory could possibly skyrocket with this behavior, since part of this
commit is to properly remove closed subscriptions from the global
subscriptions hash. Say you have 10,000 users currently connected, and
then all 10,000 disconnect -- before this patch, Action Cable would
still hold onto information (and Ruby objects!) for all of these now
dead connections.
|
|/
|
|
|
| |
The Event hack was too much of a hack: on actually thinking about it,
there's a rather obvious race.
|
|\
| |
| | |
Inject Rails related configuration through Railtie
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `WorkerTest`'s `Receiver` is imporsonating an `ActionCable::Connection::Base`, but
just delegates the logger to `ActionCable.logger`.
This creates a mismatch as the connection requires the logger to be a
`TaggedLoggerProxy`'ied logger, while the server doesn't.
Thus to ensure an exception isn't raised when the worker tries to call `tag`
other tests have to assign a proxied logger to their test server.
Instead of forcing change on other tests, have Receiver adhere to the connection
contract and use a `TaggedLoggerProxy`.
As a consequence remove more setup from the tests.
|
| |
| |
| |
| |
| |
| |
| | |
Instead of depending on ApplicationCable::Connection being defined at initialize
we should inject it in the Railtie.
Thus we can kill more setup in the tests too.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
thereby coupling ourselves to Rails.
Instead add `app/channels` to Rails' app paths and assign the existent files
to `channel_paths`.
Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
and root definitions in the tests.
|
| | |
|
|\ \
| | |
| | | |
ActionCable README updates
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \ |
|
| | | | |
|
| |/ / |
|
| |\ \
| | | |
| | | | |
remove `faye-websocket` dependency from README [ci skip]
|
| | |/
| | |
| | |
| | | |
`faye-websocket` gem is no longer used from 322dca293b3716ccaa09e7e82046e539b0d2ffda.
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some existing examples used ActionCable.server.config but for
configuring allowed_request_origins that is overridden in development
mode. The correct place to set that is
Rails.application.config.action_cable which the ActionCable initializer
loads from. I thought the other two examples should be changed as well
just in case a default value that would override a configured value is
introduced for either log_tags or disable_request_forgery_protection in
the future.
|
| |
| |
| |
| | |
MANY FILES OPEN
|
| |
| |
| |
| | |
Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| | |
* Properly indent code sample in ActionCable::Channel::Streams
* Add a doc comment for #stop_all_streams
* Reformat + add <tt> blocks around code references in ActionCable::Base docs
* Clarify and a little better grammar on ActionCable::RemoteConnections
* Correct indentation and clean up ActionCable::Server::Broadcasting code sample
|
| |
| |
| |
| |
| |
| | |
And improve changelongs.
[ci skip]
|
| | |
|
| |\
| | |
| | | |
Redis sans EventMachine
|
| | |
| | |
| | |
| | |
| | |
| | | |
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
|
| | |
| | |
| | |
| | | |
None of the other components use them, so we should be consistent.
|
| |\ \
| | | |
| | | | |
Move Action Cable back to the main build
|
| | |/ |
|
| | | |
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
Action Cable Assets Compilation redux
|
| | | | |
|
| | |/ |
|
| |/ |
|
| |
| |
| |
| | |
The detach used by close! seems to be making EM very sad on Travis.
|
| |
| |
| |
| |
| | |
It's not strictly necessary, and maybe this will help with the current
test failure.
|
| | |
|