| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Follow up to #25240.
|
|
|
|
|
| |
- Only Action Cable README did not have this section, all of the other
READMEs have this section.
|
|
|
|
|
|
| |
- Remove "Configuration", "Running the server", "Dependencies" and "Deployment"
sections from the Action Cable README as they are already duplicated in the
Action Cable overview guide.
|
| |
|
|\
| |
| |
| | |
[Action Cable] Add `WebSocket` and `logger` configuration options
|
| | |
|
| | |
|
| |
| |
| |
| | |
[Javan Makhmali, Jon Moss]
|
|\ \
| | |
| | |
| | | |
Action Cable: Tune Sauce Labs tests
|
| |/
| |
| |
| | |
Cuts down the number of concurrent Sauce Labs VMs we need to spin up. Can add specific versions back in to target regressions if need be.
|
|/ |
|
|
|
| |
Added 'sh' for markdown formatting as bash.
|
|
|
|
|
|
|
|
| |
Allow failures until test runs are consistently stable, not hanging.
Closes #24943.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|
|
|
| |
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
|
| |
|
|
|
|
|
|
|
|
|
| |
Apps that depend on Action Cable don't need Blade for app development,
so we can remove the gem dependency.
We do need Blade for Action Cable dev, so we bundle it in the Gemfile.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\
| |
| | |
Change comments to not exceed 80 characters
|
| |
| |
| |
| | |
Other generated files do keep to this, but action cable doesn't.
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| |/
|/| |
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
javascript engine of the application
- Now we will detect what javascript engine user is using and based on
that we will generate either `.js` or `.coffee` version of the channel
file.
- This also needs a change in coffee-rails to override the `js_template`
method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
`config.app_generators.javascript_engine` to `:coffee` and using this
information we override the `js_template` to set the extension as
`.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
coffee-rails gem to hook into and change the extension to `.coffee`
without maintaining the actual asset files.
[Prathamesh Sonpatki, Matthew Draper]
|
|/
|
| |
Method description improved to reflect little bit more complicated scenario when names are camel-cased.
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/configuring.md
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
In #23935, cable file was to be provided by the javascript instead of coffeescript,
doc was also been modified to use javascript.
|
|\ \
| | |
| | |
| | | |
Preparing for 5.0.0.rc1 release
|
| | | |
|
|/ /
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| | |
This is an engine living in action_cable/engine.rb, convention is to
call these things *::Engine.
Looking at thi git history looks like the current *::Railtie was just
an accident.
|
|/
|
|
| |
default worker pool size was changed from 100 to 4 at #24376
|
| |
|
|\
| |
| | |
Actioncable and Actionpack documentation typos [ci skip]
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
| |
* Use separate stream handler builders for easy override and testing.
* Fix worker pool execution that was silently failing since it only
expected connection receivers.
Sparked by code in #24162.
|
|
|
|
|
|
|
|
|
| |
* Rewrite docs
* Support blocks in addition to method names and Proc args
* Check for valid arguments
* Convert `periodically :method_name` to Proc callbacks
* Drop periodic runner methods from the worker pool
* Ensure we clear active periodic timers after shutdown
|
|\
| |
| | |
Fix typos in ActionCable Channel [ci skip]
|
| | |
|
| |
| |
| |
| | |
`cable.js` is required for other Channels.
|
|\ \
| | |
| | | |
Fixed ActionCable::Connection::ClientSocketTest test
|
| | |
| | |
| | |
| | |
| | |
| | | |
ActionCable::Connection::StreamTest test name
- Only add attr_readers for required attributes
|
|\ \ \
| |/ /
|/| | |
update example to specify the Action Cable mount path [ci skip]
|
| | |
| | |
| | |
| | | |
Follow up to 8b69f1e
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Alternate implementation of #24162 with tests. The code had diverged
too far on master to pull that implemenation directly.
Fixes #23778
Close #24162
[Mattew Draper & Sean Griffin]
|
|/
|
|
|
|
|
|
|
| |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
| |
|
|\
| |
| |
| | |
ActionCable protocol negotiation
|