Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Fix CHANGELOG entry [ci skip] | Rafael Mendonça França | 2016-03-30 | 1 | -1/+1 | |
| | | ||||||
* | | Keep logging in the ActionCable::Channel::Base | Rafael Mendonça França | 2016-03-30 | 3 | -110/+6 | |
| | | | | | | | | | | | | To move Action Cable logging to a LoggingSubscriber we need to pass the log tags in the notification payload since Action Cable logging use the Channel instance to tag the logs. | |||||
* | | Merge pull request #23723 from mwear/action_cable_notifications | Rafael Mendonça França | 2016-03-29 | 5 | -8/+204 | |
|\ \ | | | | | | | | | | Add ActiveSupport::Notification to Channel::Base#perform_action | |||||
| * | | Add AS::Notifications and LogSubscriber to ActionCable::Channel | Matthew Wear | 2016-03-04 | 5 | -8/+204 | |
| | | | | | | | | | | | | | | | This commit adds ActiveSupport::Notifications instrumentation hooks and a LogSuscriber to ActionCable::Channel::Base. | |||||
* | | | Cable: Shush pop warnings when skipping Postgres tests. | Kasper Timm Hansen | 2016-03-26 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | `skip` raises an exception to abort the execution of the test, so `super` would never be called and thus `@rx_adapter` and `@tx_adapter` would never have been defined at the time of teardown. Define them just before skipping and zap the warnings. | |||||
* | | | Shush up EM::Hiredis when running tests. | Kasper Timm Hansen | 2016-03-26 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EM::Hiredis were spewing screenfuls of warnings when running the Action Cable tests. Copied over the technique that shushes up faye-websocket in the client tests, so we can reduce the noise ratio. Note: there's still warnings spewed after tests have finished when EM::Hiredis shuts down. I haven't been able to shush them up yet. | |||||
* | | | Cable: fix Faye periodic timer shutdown typo | Jeremy Daer | 2016-03-24 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #24259 from jeremy/cable/disconnected-client-errors | Jeremy Daer | 2016-03-23 | 5 | -1/+136 | |
|\ \ \ | | | | | | | | | Cable: Gracefully handle disconnected clients | |||||
| * | | | Gracefully handle disconnected clients | Jeremy Daer | 2016-03-20 | 5 | -1/+136 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll get `Errno::ECONNRESET` if the client forcibly disconnected. Just close the socket rather than raising the exception. Handle other errors in `ClientSocket#write`, too, mirroring the Faye error handling which swallows all `StandardError` on write. | |||||
* | | | | Fix WebSocket already open log message typo | Jon Evans | 2016-03-22 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Cable: add isolated tests and FAYE=1 test runs | Jeremy Daer | 2016-03-20 | 1 | -0/+8 | |
|/ / / | ||||||
* | / | Evented Redis adapter: log reconnect failures as errors, not just info | Jeremy Daer | 2016-03-17 | 1 | -1/+1 | |
| |/ |/| | | | | | [ci skip] | |||||
* | | AC: skip PG adapter tests if the db isn't available | Jeremy Daer | 2016-03-11 | 1 | -0/+7 | |
| | | ||||||
* | | Remove redundant regexp escapes in generators | Gadzhi Gadzhiev | 2016-03-08 | 1 | -1/+1 | |
|/ | ||||||
* | Return subscription object(s) when updating the collection | Javan Makhmali | 2016-03-04 | 1 | -3/+4 | |
| | ||||||
* | Make sure ActionCable.Subscriptions#create always returns the newly created ↵ | Pratik Naik | 2016-03-04 | 1 | -0/+2 | |
| | | | | subscription object | |||||
* | Store reference to Subscriptions instance for convenience | Javan Makhmali | 2016-03-03 | 1 | -5/+6 | |
| | ||||||
* | Implicity add Subscription instance to subscriptions collection | Javan Makhmali | 2016-03-03 | 2 | -13/+12 | |
| | ||||||
* | Share default mount path with client side .js | Javan Makhmali | 2016-03-03 | 3 | -3/+4 | |
| | ||||||
* | Fix location of default mount path value | Javan Makhmali | 2016-03-03 | 1 | -2/+3 | |
| | | | | #getConfig was implmented as general utility for reading action-cable-* meta tags (hence the `name` argument). Introduced in 8b69f1eeba753c38364fb88136b2503480f2de1d. | |||||
* | Defer starting connection monitor until a connection is opened | Javan Makhmali | 2016-03-03 | 3 | -41/+52 | |
| | ||||||
* | Establish WebSocket connection when first subscription is created. Fixes #24026 | Javan Makhmali | 2016-03-03 | 3 | -9/+10 | |
| | | | | | * More intention revealing than connecting on the first call to Connection#send * Fixes that calls to Connection#send would attempt to open a connection when the WebSocket's state is CONNECTING | |||||
* | Merge pull request #23992 from matthewd/em-option | Matthew Draper | 2016-03-04 | 29 | -51/+227 | |
|\ | | | | | Support faye-websocket + EventMachine as an option | |||||
| * | Support faye-websocket + EventMachine as an option | Matthew Draper | 2016-03-02 | 29 | -51/+227 | |
| | | ||||||
* | | ConnectionMonitor is once again notified of disconnect | Daniel Rhodes | 2016-03-03 | 2 | -0/+2 | |
| | | ||||||
* | | Fix CHANGELOG spacing [ci skip] | Jeremy Daer | 2016-03-02 | 1 | -12/+12 | |
| | | ||||||
* | | Accept JSON with no backslashes/escaping | Jon Moss | 2016-03-02 | 4 | -8/+27 | |
| | | | | | | | | | | | | | | Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer. | |||||
* | | Merge pull request #23976 from danielrhodes/enhancement/ac-ping-to-message-type | Matthew Draper | 2016-03-02 | 7 | -19/+24 | |
|\ \ | | | | | | | | | | ActionCable: Add a "welcome" and "ping" message type | |||||
| * | | Make ping into a message type | Daniel Rhodes | 2016-03-01 | 6 | -15/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work. | |||||
| * | | Added welcome message type and fix test hacks | Daniel Rhodes | 2016-03-01 | 5 | -5/+14 | |
| | | | ||||||
* | | | Merge pull request #23932 from arthurnn/arthurnn/remove_load_paths | Arthur Nogueira Neves | 2016-03-01 | 1 | -3/+0 | |
|\ \ \ | | | | | | | | | Remove load_paths file | |||||
| * | | | Remove load_paths file | Arthur Neves | 2016-02-27 | 1 | -3/+0 | |
| | | | | ||||||
* | | | | Merge pull request #23935 from y-yagi/convert_cable_coffee_to_javascript | Rafael França | 2016-03-01 | 1 | -1/+1 | |
|\ \ \ \ | |_|_|/ |/| | | | convert cable.coffee to cable.js | |||||
| * | | | convert cable.coffee to cable.js | yuuji.yaginuma | 2016-02-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | In order to eliminate the dependecy of CoffeeScript. | |||||
* | | | | Use AS::Executor / AS::Reloader to support reloading in ActionCable | Matthew Draper | 2016-03-02 | 8 | -24/+96 | |
| | | | | ||||||
* | | | | Remove inconsistency in the Action Cable README [ci skip] | Bouke van der Bijl | 2016-02-29 | 1 | -6/+2 | |
| |_|/ |/| | | ||||||
* | | | Merge pull request #23811 from iamvery/string-channel | David Heinemeier Hansson | 2016-02-28 | 5 | -1/+37 | |
|\ \ \ | |/ / |/| | | Ensure actioncable behaves as expected with non-string queues | |||||
| * | | Update changelog | Jay Hayes | 2016-02-24 | 1 | -0/+4 | |
| | | | ||||||
| * | | Ensure server broadcasts are to string queue names | Jay Hayes | 2016-02-24 | 2 | -1/+16 | |
| | | | | | | | | | | | | | | | | | | Similar to the channel streaming side, these values must be strings for ActionCable to behave as expected. The conversion will allow users to send string-convertible values and get the expected behavior. | |||||
| * | | Convert stream broadcasting to a string | Jay Hayes | 2016-02-24 | 2 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | | | | ActionCable does some things behind the scenes that expects these "broadcasting"s or "channel"s to be strings. However it's not immediately obvious that the value must be a string. So adding this conversion ensures things work as expected. | |||||
| * | | whitespace | Jay Hayes | 2016-02-24 | 1 | -1/+0 | |
| | | | ||||||
* | | | Add small Action Cable documentation fixes | Hayley Anderson | 2016-02-27 | 4 | -13/+13 | |
| |/ |/| | | | | | | | * Fix typos/grammar errors * Make capitalization/naming consistent | |||||
* | | Merge pull request #23916 from ↵ | Jeremy Daer | 2016-02-26 | 1 | -2/+6 | |
|\ \ | | | | | | | | | | | | | lifo/same-redis-connection-for-subscription-and-broadcast Always use redis_connector to create redis connections | |||||
| * | | Use redis_connector to create redis connections for both subscriptions and ↵ | Pratik Naik | 2016-02-26 | 1 | -2/+6 | |
| | | | | | | | | | | | | broadcasts | |||||
* | | | The async.callback call should live with the hijack | Matthew Draper | 2016-02-26 | 1 | -4/+5 | |
| | | | | | | | | | | | | If we're deferring one, we should defer the other too. | |||||
* | | | Merge pull request #23843 from maclover7/fix-23471 | Matthew Draper | 2016-02-25 | 3 | -10/+29 | |
|\ \ \ | | | | | | | | | Only hijack Rack socket when first needed | |||||
| * | | | Only hijack Rack socket when first needed | Jon Moss | 2016-02-24 | 3 | -10/+29 | |
| | |/ | |/| | | | | | | | Fixes #23471 | |||||
* | | | Only open Action Cable connection if data is being sent | Jon Moss | 2016-02-24 | 1 | -1/+3 | |
| | | | ||||||
* | | | Enable Action Cable routes by default | Jon Moss | 2016-02-24 | 4 | -5/+27 | |
|/ / | | | | | | | This also marks Action Cable routes as internal to Rails. | |||||
* | | Add Ruby formatting to CHANGELOG entry | claudiob | 2016-02-24 | 1 | -4/+5 | |
| | | | | | | | | [ci skip] |