aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable
Commit message (Collapse)AuthorAgeFilesLines
* fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-012-2/+2
|
* Prevent invocation of channel action if rejected connectionJon Moss2016-08-192-1/+16
| | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
* Add three new rubocop rulesRafael Mendonça França2016-08-163-26/+26
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Pass over changelogs [ci skip]Vipul A M2016-08-101-1/+1
|
* revises more Lint/EndAlignment offensesXavier Noria2016-08-081-6/+6
|
* copy-edits an exception messageXavier Noria2016-08-071-1/+1
| | | | | | | | | | | | | | Inserted spaces in the name of Rails components. Since I was on it, also used PostgreSQL instead of Postgres because albeit Postgres is an accepted alias, PostgreSQL is the official name and the actual name of the adapter. See https://wiki.postgresql.org/wiki/ProjectName with regard to PostgreSQL vs Postgres.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-072-3/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-062-4/+3
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-062-4/+4
|
* remove redundant curlies from hash argumentsXavier Noria2016-08-065-7/+7
|
* modernizes hash syntax in actioncableXavier Noria2016-08-061-2/+2
|
* applies new string literal convention to the rest of the projectXavier Noria2016-08-061-6/+6
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in the gemspecsXavier Noria2016-08-061-14/+14
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actioncable/testXavier Noria2016-08-0629-260/+260
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in actioncable/libXavier Noria2016-08-0628-90/+90
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Give importance to rails command in the comment section.Santosh Wadghule2016-07-131-1/+1
|
* Correct changelog layoutMatthew Draper2016-07-091-8/+8
| | | | [ci skip]
* Insert changelog entry for #25615Matthew Draper2016-07-091-0/+7
|
* Merge pull request #25624 from tinco/actioncable_write_raceMatthew Draper2016-07-092-2/+12
|\ | | | | | | Fix race condition in websocket stream write
| * fix race condition in websocket stream writeTinco Andringa2016-07-011-0/+4
| |
* | Merge pull request #24988 from mwear/action_cable_broadcast_notificationsMatthew Draper2016-07-043-6/+58
|\ \ | | | | | | Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast
| * | Add ActiveSupport::Notifications hook to Broadcaster#broadcastMatthew Wear2016-05-123-6/+58
| | | | | | | | | | | | | | | This addition of this notification hook will give users better visibility into the messages being sent over the PubSub adapter.
* | | Merge pull request #25030 from mmmpa/pull_requestMatthew Draper2016-07-042-1/+22
|\ \ \ | | | | | | | | ActionCable, sometimes add_channel is not called.
| * | | Add guard to broadcast.mmmpa2016-05-262-1/+22
| | | |
* | | | Merge pull request #25293 from y-yagi/remove_needless_commentsMatthew Draper2016-07-033-5/+0
|\ \ \ \ | | | | | | | | | | remove needless comments
| * | | | remove needless commentsyuuji.yaginuma2016-06-063-5/+0
| | | | | | | | | | | | | | | | | | | | Follow up to #25240.
* | | | | close hijacked i/o socket after use (fixes #25613)Tinco Andringa2016-07-012-0/+15
| |_|_|/ |/| | |
* | | | Periodic timers: delegate async instance_exec to the worker poolJeremy Daer2016-06-292-7/+9
| | | |
* | | | Merge pull request #24991 from maclover7/actioncable-npm-docsVipul A M2016-06-291-0/+68
|\ \ \ \ | | | | | | | | | | Add documentation about Action Cable npm package
| * | | | Add documentation about Action Cable npm packageJon Moss2016-05-261-0/+68
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Sorry, forgot to include in my main PR :( [ci skip] [Jon Moss, Zach Schneider]
* | | | Make client test run individually.Kasper Timm Hansen2016-06-281-1/+3
| | | | | | | | | | | | | | | | Require our dependency and forgo the core ext version.
* | | | Fix Action Cable README [ci skip]Rafael Mendonça França2016-06-261-5/+14
| | | |
* | | | Remove conflict line [ci skip]Ryuta Kamizono2016-06-271-1/+0
| | | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-06-261-2/+143
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: actioncable/README.md
| * | | | Fix and make example generic in README as well [ci skip]Vipul A M2016-06-151-3/+3
| | | | |
* | | | | client test have not using Pathname and hashwithindifferent accessGaurav Sharma2016-06-261-3/+0
| | | | |
* | | | | Allow actioncable connections from any port in developmentMichael Dever2016-06-161-1/+1
| |_|/ / |/| | |
* | | | Added "Download and Installation" section to Action Cable README [ci skip]Prathamesh Sonpatki2016-06-041-0/+10
| | | | | | | | | | | | | | | | | | | | - Only Action Cable README did not have this section, all of the other READMEs have this section.
* | | | Trim Action Cable README [ci skip]Prathamesh Sonpatki2016-06-041-161/+0
|/ / / | | | | | | | | | | | | | | | - Remove "Configuration", "Running the server", "Dependencies" and "Deployment" sections from the Action Cable README as they are already duplicated in the Action Cable overview guide.
* | | Properly support reloading for Action Cable channelsMatthew Draper2016-06-028-82/+56
| | |
* | | Merge pull request #25170 from maclover7/add-configuration-cableJeremy Daer2016-05-318-51/+69
|\ \ \ | | | | | | | | | | | | [Action Cable] Add `WebSocket` and `logger` configuration options
| * | | Add helper for testing against a mock WebSocket and serverJavan Makhmali2016-05-315-56/+48
| | | |
| * | | Reorganize `MockWebSocket`Jon Moss2016-05-312-22/+32
| | | |
| * | | Add configuration for `WebSocket` and `logger`Jon Moss2016-05-314-6/+22
| | | | | | | | | | | | | | | | [Javan Makhmali, Jon Moss]
* | | | Merge pull request #25216 from javan/actioncable/tune-sauce-labs-testsJeremy Daer2016-05-311-6/+6
|\ \ \ \ | | | | | | | | | | | | | | | Action Cable: Tune Sauce Labs tests
| * | | | Test single latest browser versionJavan Makhmali2016-05-311-6/+6
| |/ / / | | | | | | | | | | | | Cuts down the number of concurrent Sauce Labs VMs we need to spin up. Can add specific versions back in to target regressions if need be.
* / / / fix grammarRajat Bansal2016-05-312-2/+2
|/ / /
* / / Bash markdown syntaxAnubhav Saxena2016-05-271-1/+1
|/ / | | | | Added 'sh' for markdown formatting as bash.
* | CI: run Action Cable browser tests in Sauce LabsJon Moss2016-05-252-2/+27
| | | | | | | | | | | | | | | | Allow failures until test runs are consistently stable, not hanging. Closes #24943. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | | | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.