aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable
Commit message (Collapse)AuthorAgeFilesLines
* Use a gentler disconnectMatthew Draper2016-01-301-2/+2
| | | | The detach used by close! seems to be making EM very sad on Travis.
* Don't bother stopping EM between testsMatthew Draper2016-01-301-38/+3
| | | | | It's not strictly necessary, and maybe this will help with the current test failure.
* remove require loggingKesha Antonov2016-01-291-2/+0
|
* Keep the socket reference after closeMatthew Draper2016-01-301-3/+2
| | | | We may still try to send to it.
* Reduce the client count, in hope of a more consistent testMatthew Draper2016-01-301-3/+3
|
* Be more patient while gathering the expected responsesMatthew Draper2016-01-301-4/+3
|
* Handle more IO errors (especially, ECONNRESET)Matthew Draper2016-01-303-21/+78
| | | | | | Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor.
* Add a couple of tests that connect with a WS clientMatthew Draper2016-01-302-0/+251
|
* Synchronize the lazy setters in ServerMatthew Draper2016-01-305-15/+47
| | | | They're all at risk of races on the first requests.
* Fix arguments to on_closeMatthew Draper2016-01-302-5/+3
|
* Revert "Revert "Eliminate the EventMachine dependency""Matthew Draper2016-01-3025-99/+382
|
* Revert "Eliminate the EventMachine dependency"David Heinemeier Hansson2016-01-2725-382/+99
|
* [ci skip] Don’t explicitly mention EventMachineclaudiob2016-01-251-5/+4
| | | | | | | | | | Since #23152 eliminated the EventMachine dependency, we don’t need to explicitly mention EventMachine. Nevertheless, I'm not 100% sure about saying "the websocket-driver loop" driver… any suggestions, @matthewd or @pixeltrix ? :sweat_smile: [ci skip]
* Merge branch '5-0-beta-sec'Aaron Patterson2016-01-251-1/+1
|\ | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password
| * bumping versionAaron Patterson2016-01-251-1/+1
| |
* | Merge pull request #23185 from droptheplot/actioncable-custom-channelsKasper Timm Hansen2016-01-241-3/+5
|\ \ | | | | | | ActionCable: Allow adding custom paths for channels
| * | Rename channels_path var and fix channel_paths method for ActionCable configSergey Novikov2016-01-231-5/+5
| | |
| * | Allow adding custom paths for action_cable channelsSergey Novikov2016-01-221-2/+4
| | |
* | | Ditch the EM error logging helperMatthew Draper2016-01-242-9/+0
| | | | | | | | | | | | | | | | | | We're no longer doing our work in the EM event loop, so errors are quite unlikely, and if they do occur, they're not really our responsibility to handle.
* | | Import the relevant portions of faye-websocketMatthew Draper2016-01-2412-30/+331
| | | | | | | | | | | | (as adapted to use concurrent-ruby / nio4r instead of eventmachine)
* | | Using a hacked faye-websocket, drop EventMachineMatthew Draper2016-01-2415-65/+56
| | |
* | | Add tests for the ActionCable adaptersMatthew Draper2016-01-247-0/+227
| | |
* | | Allow subscription adapters to be shut downMatthew Draper2016-01-244-14/+40
| | |
* | | Add Async and Inline adaptersMatthew Draper2016-01-242-0/+44
| | | | | | | | | | | | | | | Just like their ActiveJob equivalents, these only work within the current process.
* | | Normalize on no arguments for the success callbackMatthew Draper2016-01-242-2/+2
| | |
* | | Split internal subscriber tracking from Postgres adapterMatthew Draper2016-01-243-24/+70
| | |
* | | fix path of Action Cable configuration file [ci skip]yuuji.yaginuma2016-01-231-2/+2
| | | | | | | | | | | | This changed in #22950.
* | | Move ApplicationCable::Channel section of readmeDerek Kniffin2016-01-221-7/+7
| | | | | | | | | I believe the paragraph starting with "This relies" belongs with the one above it.
* | | Use the correct reference to the redis connectionBrit Gardner2016-01-221-1/+1
|/ / | | | | | | | | Fixes #23193 This was throwing `There was an exception - NameError(undefined local variable or method `hi_redis_conn' for #<ActionCable::SubscriptionAdapter::Redis:0x007fb1449e2b70>)` on unsubscribe.
* | Small doc update per RF [ci skip]Jon Moss2016-01-201-4/+5
| |
* | Add CHANGELOG.md entry for #22950Jon Moss2016-01-201-0/+8
| | | | | | | | [ci skip]
* | Merge pull request #22950 from maclover7/adapterize-storage-actioncableMatthew Draper2016-01-2022-56/+311
|\ \ | | | | | | | | | Adapterize storage for ActionCable
| * | Fix code review commentsJon Moss2016-01-1814-55/+52
| | | | | | | | | | | | | | | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters
| * | Small PostgreSQL adapter refactors / cleanupJon Moss2016-01-182-15/+16
| | | | | | | | | | | | | | | - Escape the channel name when subscribing in PG - Refactor popping the queue to make it easier to read
| * | ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapterJon Moss2016-01-1811-21/+23
| | |
| * | All Redis deps are now optional, Postgres --> PostgreSQL adapterJon Moss2016-01-186-9/+17
| | |
| * | config_opts => cable, per @kaspthJon Moss2016-01-183-6/+7
| | |
| * | Listener no longer needs to be a singletonMatthew Draper2016-01-181-52/+58
| | | | | | | | | | | | | | | | | | | | | We now only create one adapter instance for the server, so it can hold the listener. This in turn allows the listener to get the PG connection from the adapter, which will be a good place to allow more flexible configuration.
| * | Tests passing and small refactoringJon Moss2016-01-187-37/+65
| | |
| * | Blanket unsubscribe doesn't appear to be usedMatthew Draper2016-01-181-6/+2
| | |
| * | Don't execute callbacks on our main listener threadMatthew Draper2016-01-181-1/+1
| | |
| * | Pull the action methods directly onto the adapterMatthew Draper2016-01-188-56/+51
| | |
| * | Add Postgres adapterJon Moss2016-01-183-0/+111
| | |
| * | Refactor storage_adapterJon Moss2016-01-181-11/+3
| | |
| * | Adapterize ActionCable storage and extract behaviorJon Moss2016-01-1813-38/+158
|/ /
* | Merge pull request #23096 from HayleyCAnderson/ha-action-cable-docsJon Moss2016-01-181-20/+31
|\ \ | | | | | | [ci skip] Improve Action Cable configuration explanations
| * | Improve Action Cable configuration explanationsHayley Anderson2016-01-181-20/+31
| | | | | | | | | | | | | | | | | | | | | | | | * Clarify wording around how defaults work * Clarify wording around what formatting versus information is required * Separate consumer configuration section since it is important and wordy * Add additional explanation of options for setting consumer configuration * Consolidate consumer configuration information to reduce confusion
* | | Fix the updated API (this sorts the concurrent-ruby switch with Basecamp)David Heinemeier Hansson2016-01-161-1/+1
| | |
* | | Revert "Merge pull request #22977 from rails/revert-22934-master"David Heinemeier Hansson2016-01-1614-35/+45
| | | | | | | | | | | | | | | This reverts commit d0393fccffc118a5de37654aa222774b66123393, reversing changes made to 3b7ccadfc1c8dfec61af898167e1300b17f5cf25.
* | | [ci skip] Fix typo in docsDAVID MOORE2016-01-151-1/+1
|/ / | | | | | | | | Found this small omission while reviewing the ActionCable docs. [Dave Moore]