aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | fix grammarRajat Bansal2016-05-312-2/+2
|/ / /
* / / Bash markdown syntaxAnubhav Saxena2016-05-271-1/+1
|/ / | | | | Added 'sh' for markdown formatting as bash.
* | CI: run Action Cable browser tests in Sauce LabsJon Moss2016-05-252-2/+27
| | | | | | | | | | | | | | | | Allow failures until test runs are consistently stable, not hanging. Closes #24943. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | | | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* | Build action_cable.js with BladeJavan Makhmali2016-05-243-42/+11
| |
* | Remove Blade gem dependencyVipul A M2016-05-211-2/+0
| | | | | | | | | | | | | | | | | | Apps that depend on Action Cable don't need Blade for app development, so we can remove the gem dependency. We do need Blade for Action Cable dev, so we bundle it in the Gemfile. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Merge pull request #25076 from jeroenvisser101/keep-to-max-lengthSean Griffin2016-05-212-2/+4
|\ \ | | | | | | Change comments to not exceed 80 characters
| * | Change comments to not exceed 80 charactersJeroen Visser2016-05-192-2/+4
| | | | | | | | | | | | Other generated files do keep to this, but action cable doesn't.
* | | Pass over Action Cable docsJon Moss2016-05-212-4/+4
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #24918 from prathamesh-sonpatki/cable-assetsRafael França2016-05-212-1/+20
|\ \ \ | |/ / |/| | Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
| * | Cable: Generate .js or .coffee files while generating channel as per the ↵Prathamesh Sonpatki2016-05-172-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
* | | Improve method descriptionRoman Pushkin2016-05-181-0/+1
|/ / | | | | Method description improved to reflect little bit more complicated scenario when names are camel-cased.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-05-141-2/+2
|\ \ | | | | | | | | | | | | Conflicts: guides/source/configuring.md
| * | Fix code formatting in docsJay Hayes2016-05-031-2/+2
| | |
* | | Publish Action Cable to NPM when we release.Jon Moss2016-05-112-0/+30
| |/ |/| | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-102-89/+3
| |
* | Kick off initial JavaScript testsJavan Makhmali2016-05-099-0/+4631
| |
* | change cable.coffee to cable.js [ci skip]yuuji.yaginuma2016-05-071-5/+10
| | | | | | | | | | In #23935, cable file was to be provided by the javascript instead of coffeescript, doc was also been modified to use javascript.
* | Merge commit 'fbdcf5221ad7ea3d40ad09651962fc85d101dd67'Matthew Draper2016-05-072-1/+6
|\ \ | | | | | | | | | Preparing for 5.0.0.rc1 release
| * | Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-062-1/+6
| | |
* | | http --> httpsJon Moss2016-05-061-1/+1
|/ / | | | | | | [ci skip]
* | renames ActionCable::Railtie to ActionCable::EngineXavier Noria2016-05-041-1/+1
| | | | | | | | | | | | | | | | This is an engine living in action_cable/engine.rb, convention is to call these things *::Engine. Looking at thi git history looks like the current *::Railtie was just an accident.
* | [ci skip] Fix ActionCable READMEwillnet2016-05-021-1/+1
|/ | | | default worker pool size was changed from 100 to 4 at #24376
* Prep Rails 5 beta 4eileencodes2016-04-272-1/+3
|
* Merge pull request #24669 from tomkadwill/action_pack_typosVipul A M2016-04-221-1/+1
|\ | | | | Actioncable and Actionpack documentation typos [ci skip]
| * Actioncable and Actionpack documentation typos [ci skip]Tom Kadwill2016-04-211-1/+1
| |
* | Log if redis connection is in stale/failed state.Vipul A M2016-04-211-0/+4
|/
* Cable: Extract stream handler constructionJeremy Daer2016-04-186-25/+75
| | | | | | | | * Use separate stream handler builders for easy override and testing. * Fix worker pool execution that was silently failing since it only expected connection receivers. Sparked by code in #24162.
* Cable: Periodic timers refreshJeremy Daer2016-04-184-39/+83
| | | | | | | | | * Rewrite docs * Support blocks in addition to method names and Proc args * Check for valid arguments * Convert `periodically :method_name` to Proc callbacks * Drop periodic runner methods from the worker pool * Ensure we clear active periodic timers after shutdown
* Merge pull request #24600 from tomkadwill/action-cabel-channel-typosVipul A M2016-04-184-5/+5
|\ | | | | Fix typos in ActionCable Channel [ci skip]
| * Fix typos in ActionCable Channel [ci skip]Tom Kadwill2016-04-184-5/+5
| |
* | don't remove `cable.js`yuuji.yaginuma2016-04-161-1/+3
| | | | | | | | `cable.js` is required for other Channels.
* | Merge pull request #24559 from vipulnsward/fix-ac-testsJeremy Daer2016-04-152-5/+3
|\ \ | | | | | | Fixed ActionCable::Connection::ClientSocketTest test
| * | - Fixed ActionCable::Connection::ClientSocketTest that was overriding ↵Vipul A M2016-04-152-5/+3
| | | | | | | | | | | | | | | | | | ActionCable::Connection::StreamTest test name - Only add attr_readers for required attributes
* | | Merge pull request #24557 from y-yagi/update_example_to_specify_ac_mount_pathVipul A M2016-04-151-4/+4
|\ \ \ | |/ / |/| | update example to specify the Action Cable mount path [ci skip]
| * | update example to specify the Action Cable mount path [ci skip]yuuji.yaginuma2016-04-151-4/+4
| | | | | | | | | | | | Follow up to 8b69f1e
* | | Run Action Cable callbacks through the worker poolSean Griffin2016-04-132-5/+30
|/ / | | | | | | | | | | | | | | | | | | Alternate implementation of #24162 with tests. The code had diverged too far on master to pull that implemenation directly. Fixes #23778 Close #24162 [Mattew Draper & Sean Griffin]
* / Generate `cable.js` file if does not exist when generating channelPrathamesh Sonpatki2016-04-122-0/+14
|/ | | | | | | | | - Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
* Cable typo: isSupportedProtocol -> isProtocolSupportedJeremy Daer2016-04-051-1/+1
|
* Merge pull request #24224 from danielrhodes/actioncable-websocket-protocolsJeremy Daer2016-04-059-24/+93
|\ | | | | | | ActionCable protocol negotiation
| * Added protocol negotiationDaniel Rhodes2016-04-058-24/+73
| | | | | | | | | | | | | | | | | | This is primarily for backwards compatibility for when or if the protocol is changed in future versions. If the server fails to respond with an acceptable protocol, the client disconnects and disables the monitor.
* | Cable message encodingJeremy Daer2016-03-3118-154/+245
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* | Cable: reconcile default worker pool size with low db conn pool sizeJeremy Daer2016-03-302-2/+12
| | | | | | | | | | | | | | | | | | | | | | Whack it down from 100 to 4. Large worker pools means large db connection counts. We aren't set up for that by default and most apps won't need it out of the box. We're better off tuning the default worker pool for low traffic, low resource consumption apps. Those who have higher traffic will scale up to meet demand.
* | Fix CHANGELOG entry [ci skip]Rafael Mendonça França2016-03-301-1/+1
| |
* | Keep logging in the ActionCable::Channel::BaseRafael Mendonça França2016-03-303-110/+6
| | | | | | | | | | | | To move Action Cable logging to a LoggingSubscriber we need to pass the log tags in the notification payload since Action Cable logging use the Channel instance to tag the logs.
* | Merge pull request #23723 from mwear/action_cable_notificationsRafael Mendonça França2016-03-295-8/+204
|\ \ | | | | | | | | | Add ActiveSupport::Notification to Channel::Base#perform_action
| * | Add AS::Notifications and LogSubscriber to ActionCable::ChannelMatthew Wear2016-03-045-8/+204
| | | | | | | | | | | | | | | This commit adds ActiveSupport::Notifications instrumentation hooks and a LogSuscriber to ActionCable::Channel::Base.
* | | Cable: Shush pop warnings when skipping Postgres tests.Kasper Timm Hansen2016-03-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | `skip` raises an exception to abort the execution of the test, so `super` would never be called and thus `@rx_adapter` and `@tx_adapter` would never have been defined at the time of teardown. Define them just before skipping and zap the warnings.
* | | Shush up EM::Hiredis when running tests.Kasper Timm Hansen2016-03-261-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EM::Hiredis were spewing screenfuls of warnings when running the Action Cable tests. Copied over the technique that shushes up faye-websocket in the client tests, so we can reduce the noise ratio. Note: there's still warnings spewed after tests have finished when EM::Hiredis shuts down. I haven't been able to shush them up yet.
* | | Cable: fix Faye periodic timer shutdown typoJeremy Daer2016-03-241-1/+1
| | |