Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 2 | -4/+3 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 2 | -4/+4 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 5 | -7/+7 |
| | |||||
* | modernizes hash syntax in actioncable | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | |||||
* | applies new string literal convention to the rest of the project | Xavier Noria | 2016-08-06 | 1 | -6/+6 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in the gemspecs | Xavier Noria | 2016-08-06 | 1 | -14/+14 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actioncable/test | Xavier Noria | 2016-08-06 | 29 | -260/+260 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actioncable/lib | Xavier Noria | 2016-08-06 | 28 | -90/+90 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Give importance to rails command in the comment section. | Santosh Wadghule | 2016-07-13 | 1 | -1/+1 |
| | |||||
* | Correct changelog layout | Matthew Draper | 2016-07-09 | 1 | -8/+8 |
| | | | | [ci skip] | ||||
* | Insert changelog entry for #25615 | Matthew Draper | 2016-07-09 | 1 | -0/+7 |
| | |||||
* | Merge pull request #25624 from tinco/actioncable_write_race | Matthew Draper | 2016-07-09 | 2 | -2/+12 |
|\ | | | | | | | Fix race condition in websocket stream write | ||||
| * | fix race condition in websocket stream write | Tinco Andringa | 2016-07-01 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #24988 from mwear/action_cable_broadcast_notifications | Matthew Draper | 2016-07-04 | 3 | -6/+58 |
|\ \ | | | | | | | Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast | ||||
| * | | Add ActiveSupport::Notifications hook to Broadcaster#broadcast | Matthew Wear | 2016-05-12 | 3 | -6/+58 |
| | | | | | | | | | | | | | | | This addition of this notification hook will give users better visibility into the messages being sent over the PubSub adapter. | ||||
* | | | Merge pull request #25030 from mmmpa/pull_request | Matthew Draper | 2016-07-04 | 2 | -1/+22 |
|\ \ \ | | | | | | | | | ActionCable, sometimes add_channel is not called. | ||||
| * | | | Add guard to broadcast. | mmmpa | 2016-05-26 | 2 | -1/+22 |
| | | | | |||||
* | | | | Merge pull request #25293 from y-yagi/remove_needless_comments | Matthew Draper | 2016-07-03 | 3 | -5/+0 |
|\ \ \ \ | | | | | | | | | | | remove needless comments | ||||
| * | | | | remove needless comments | yuuji.yaginuma | 2016-06-06 | 3 | -5/+0 |
| | | | | | | | | | | | | | | | | | | | | Follow up to #25240. | ||||
* | | | | | close hijacked i/o socket after use (fixes #25613) | Tinco Andringa | 2016-07-01 | 2 | -0/+15 |
| |_|_|/ |/| | | | |||||
* | | | | Periodic timers: delegate async instance_exec to the worker pool | Jeremy Daer | 2016-06-29 | 2 | -7/+9 |
| | | | | |||||
* | | | | Merge pull request #24991 from maclover7/actioncable-npm-docs | Vipul A M | 2016-06-29 | 1 | -0/+68 |
|\ \ \ \ | | | | | | | | | | | Add documentation about Action Cable npm package | ||||
| * | | | | Add documentation about Action Cable npm package | Jon Moss | 2016-05-26 | 1 | -0/+68 |
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Sorry, forgot to include in my main PR :( [ci skip] [Jon Moss, Zach Schneider] | ||||
* | | | | Make client test run individually. | Kasper Timm Hansen | 2016-06-28 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | Require our dependency and forgo the core ext version. | ||||
* | | | | Fix Action Cable README [ci skip] | Rafael Mendonça França | 2016-06-26 | 1 | -5/+14 |
| | | | | |||||
* | | | | Remove conflict line [ci skip] | Ryuta Kamizono | 2016-06-27 | 1 | -1/+0 |
| | | | | |||||
* | | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2016-06-26 | 1 | -2/+143 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | Conflicts: actioncable/README.md | ||||
| * | | | | Fix and make example generic in README as well [ci skip] | Vipul A M | 2016-06-15 | 1 | -3/+3 |
| | | | | | |||||
* | | | | | client test have not using Pathname and hashwithindifferent access | Gaurav Sharma | 2016-06-26 | 1 | -3/+0 |
| | | | | | |||||
* | | | | | Allow actioncable connections from any port in development | Michael Dever | 2016-06-16 | 1 | -1/+1 |
| |_|/ / |/| | | | |||||
* | | | | Added "Download and Installation" section to Action Cable README [ci skip] | Prathamesh Sonpatki | 2016-06-04 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | - Only Action Cable README did not have this section, all of the other READMEs have this section. | ||||
* | | | | Trim Action Cable README [ci skip] | Prathamesh Sonpatki | 2016-06-04 | 1 | -161/+0 |
|/ / / | | | | | | | | | | | | | | | | - Remove "Configuration", "Running the server", "Dependencies" and "Deployment" sections from the Action Cable README as they are already duplicated in the Action Cable overview guide. | ||||
* | | | Properly support reloading for Action Cable channels | Matthew Draper | 2016-06-02 | 8 | -82/+56 |
| | | | |||||
* | | | Merge pull request #25170 from maclover7/add-configuration-cable | Jeremy Daer | 2016-05-31 | 8 | -51/+69 |
|\ \ \ | | | | | | | | | | | | | [Action Cable] Add `WebSocket` and `logger` configuration options | ||||
| * | | | Add helper for testing against a mock WebSocket and server | Javan Makhmali | 2016-05-31 | 5 | -56/+48 |
| | | | | |||||
| * | | | Reorganize `MockWebSocket` | Jon Moss | 2016-05-31 | 2 | -22/+32 |
| | | | | |||||
| * | | | Add configuration for `WebSocket` and `logger` | Jon Moss | 2016-05-31 | 4 | -6/+22 |
| | | | | | | | | | | | | | | | | [Javan Makhmali, Jon Moss] | ||||
* | | | | Merge pull request #25216 from javan/actioncable/tune-sauce-labs-tests | Jeremy Daer | 2016-05-31 | 1 | -6/+6 |
|\ \ \ \ | | | | | | | | | | | | | | | | Action Cable: Tune Sauce Labs tests | ||||
| * | | | | Test single latest browser version | Javan Makhmali | 2016-05-31 | 1 | -6/+6 |
| |/ / / | | | | | | | | | | | | | Cuts down the number of concurrent Sauce Labs VMs we need to spin up. Can add specific versions back in to target regressions if need be. | ||||
* / / / | fix grammar | Rajat Bansal | 2016-05-31 | 2 | -2/+2 |
|/ / / | |||||
* / / | Bash markdown syntax | Anubhav Saxena | 2016-05-27 | 1 | -1/+1 |
|/ / | | | | | Added 'sh' for markdown formatting as bash. | ||||
* | | CI: run Action Cable browser tests in Sauce Labs | Jon Moss | 2016-05-25 | 2 | -2/+27 |
| | | | | | | | | | | | | | | | | Allow failures until test runs are consistently stable, not hanging. Closes #24943. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Remove package:clean task | Javan Makhmali | 2016-05-24 | 1 | -1/+0 |
| | | | | | | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task. | ||||
* | | Build action_cable.js with Blade | Javan Makhmali | 2016-05-24 | 3 | -42/+11 |
| | | |||||
* | | Remove Blade gem dependency | Vipul A M | 2016-05-21 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | Apps that depend on Action Cable don't need Blade for app development, so we can remove the gem dependency. We do need Blade for Action Cable dev, so we bundle it in the Gemfile. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com> | ||||
* | | Merge pull request #25076 from jeroenvisser101/keep-to-max-length | Sean Griffin | 2016-05-21 | 2 | -2/+4 |
|\ \ | | | | | | | Change comments to not exceed 80 characters | ||||
| * | | Change comments to not exceed 80 characters | Jeroen Visser | 2016-05-19 | 2 | -2/+4 |
| | | | | | | | | | | | | Other generated files do keep to this, but action cable doesn't. | ||||
* | | | Pass over Action Cable docs | Jon Moss | 2016-05-21 | 2 | -4/+4 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #24918 from prathamesh-sonpatki/cable-assets | Rafael França | 2016-05-21 | 2 | -1/+20 |
|\ \ \ | |/ / |/| | | Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application | ||||
| * | | Cable: Generate .js or .coffee files while generating channel as per the ↵ | Prathamesh Sonpatki | 2016-05-17 | 2 | -1/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper] |