| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This PR checks all active Action Cable documentation for typos and other
fixes. It aims to make sure that when Rails 5 is released, that the
Action Cable docs are up to snuff with the other documentation included
with Rails.
[ci skip]
|
|\
| |
| | |
Inject Rails related configuration through Railtie
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `WorkerTest`'s `Receiver` is imporsonating an `ActionCable::Connection::Base`, but
just delegates the logger to `ActionCable.logger`.
This creates a mismatch as the connection requires the logger to be a
`TaggedLoggerProxy`'ied logger, while the server doesn't.
Thus to ensure an exception isn't raised when the worker tries to call `tag`
other tests have to assign a proxied logger to their test server.
Instead of forcing change on other tests, have Receiver adhere to the connection
contract and use a `TaggedLoggerProxy`.
As a consequence remove more setup from the tests.
|
| |
| |
| |
| |
| |
| |
| | |
Instead of depending on ApplicationCable::Connection being defined at initialize
we should inject it in the Railtie.
Thus we can kill more setup in the tests too.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
thereby coupling ourselves to Rails.
Instead add `app/channels` to Rails' app paths and assign the existent files
to `channel_paths`.
Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
and root definitions in the tests.
|
| | |
|
|\ \
| | |
| | | |
ActionCable README updates
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \ |
|
| | | | |
|
| |/ / |
|
| |\ \
| | | |
| | | | |
remove `faye-websocket` dependency from README [ci skip]
|
| | |/
| | |
| | |
| | | |
`faye-websocket` gem is no longer used from 322dca293b3716ccaa09e7e82046e539b0d2ffda.
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some existing examples used ActionCable.server.config but for
configuring allowed_request_origins that is overridden in development
mode. The correct place to set that is
Rails.application.config.action_cable which the ActionCable initializer
loads from. I thought the other two examples should be changed as well
just in case a default value that would override a configured value is
introduced for either log_tags or disable_request_forgery_protection in
the future.
|
| |
| |
| |
| | |
MANY FILES OPEN
|
| |
| |
| |
| | |
Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| | |
* Properly indent code sample in ActionCable::Channel::Streams
* Add a doc comment for #stop_all_streams
* Reformat + add <tt> blocks around code references in ActionCable::Base docs
* Clarify and a little better grammar on ActionCable::RemoteConnections
* Correct indentation and clean up ActionCable::Server::Broadcasting code sample
|
| |
| |
| |
| |
| |
| | |
And improve changelongs.
[ci skip]
|
| | |
|
| |\
| | |
| | | |
Redis sans EventMachine
|
| | |
| | |
| | |
| | |
| | |
| | | |
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
|
| | |
| | |
| | |
| | | |
None of the other components use them, so we should be consistent.
|
| |\ \
| | | |
| | | | |
Move Action Cable back to the main build
|
| | |/ |
|
| | | |
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
Action Cable Assets Compilation redux
|
| | | | |
|
| | |/ |
|
| |/ |
|
| |
| |
| |
| | |
The detach used by close! seems to be making EM very sad on Travis.
|
| |
| |
| |
| |
| | |
It's not strictly necessary, and maybe this will help with the current
test failure.
|
| | |
|
| |
| |
| |
| | |
We may still try to send to it.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Also, address the possibility of the listen thread dying and needing to
be respawned. As a bonus, we now defer construction of the thread until
we are first given something to monitor.
|
| | |
|
| |
| |
| |
| | |
They're all at risk of races on the first requests.
|
| | |
|
| | |
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
| |
Since #23152 eliminated the EventMachine dependency, we don’t need to
explicitly mention EventMachine.
Nevertheless, I'm not 100% sure about saying "the websocket-driver loop"
driver… any suggestions, @matthewd or @pixeltrix ? :sweat_smile:
[ci skip]
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* 5-0-beta-sec:
bumping version
fix version update task to deal with .beta1.1
Eliminate instance level writers for class accessors
allow :file to be outside rails root, but anything else must be inside the rails view directory
Don't short-circuit reject_if proc
stop caching mime types globally
use secure string comparisons for basic auth username / password
|
| | |
|
|\ \
| | |
| | | |
ActionCable: Allow adding custom paths for channels
|