aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/test/connection/identifier_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Include `ActiveSupport::Testing::MethodCallAssertions` to ↵bogdanvlviv2018-06-081-3/+0
| | | | | | | | | `ActionCable::TestCase` Remove all `include ActiveSupport::Testing::MethodCallAssertions` in actioncable's tests since we can do it only in `ActionCable::TestCase` in order to prevent code duplication. We use the same approach for other modules of Rails.
* Use Ruby instead of mochautilum2018-05-311-5/+8
|
* remove unnecessary mocking in ActionCable testsutilum2018-05-221-16/+11
|
* assert_calledutilum2018-04-261-2/+3
|
* assert_not_calledutilum2018-04-261-2/+6
|
* Use frozen string literal in actioncable/Kir Shatrov2017-07-231-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Privatize unneededly protected methods in Action Cable testsAkira Matsuda2016-12-241-1/+1
|
* applies new string literal convention in actioncable/testXavier Noria2016-08-061-10/+10
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Cable message encodingJeremy Daer2016-03-311-4/+2
| | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* Support faye-websocket + EventMachine as an optionMatthew Draper2016-03-021-1/+1
|
* Revert "Revert "Eliminate the EventMachine dependency""Matthew Draper2016-01-301-2/+2
|
* Revert "Eliminate the EventMachine dependency"David Heinemeier Hansson2016-01-271-2/+2
|
* Import the relevant portions of faye-websocketMatthew Draper2016-01-241-2/+2
| | | | (as adapted to use concurrent-ruby / nio4r instead of eventmachine)
* Fix code review commentsJon Moss2016-01-181-4/+4
| | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters
* Tests passing and small refactoringJon Moss2016-01-181-5/+5
|
* Get ready to merge into RailsDavid Heinemeier Hansson2015-12-141-0/+77
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 08:41:44 +0000